[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #232: [IOTDB-130]Dynamic parameters adapter

[GitBox <gi...@apache.org>]

qiaojialin commented on a change in pull request #232: [IOTDB-130]Dynamic parameters adapter
URL: https://github.com/apache/incubator-iotdb/pull/232#discussion_r302384120
 
 

 ##########
 File path: iotdb/iotdb/conf/iotdb-engine.properties
 ##########
 @@ -25,6 +25,18 @@ rpc_address=0.0.0.0
 
 rpc_port=6667
 
+####################
+### Dynamic Parameter Adapter Configuration
+####################
+
+# Is dynamic parameter adapter enable. It's recommended for users to enable parameter adapter.
+# The adapter can dynamically adjust the following two parameters according to the memory load of the system:
+# 1. tsfile_size_threshold which is introduced below.
+# 2. group_size_in_byte which is introduced in tsfile-format.properties.
 
 Review comment:
   It would be better to add a parameter called memtable_size in iotdb-engine.properties, separating this with group_size_in_byte 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services