You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/04/12 21:58:16 UTC

[GitHub] [incubator-mxnet] Zha0q1 opened a new pull request #20157: [v1.x] fix mx2onnx wheel

Zha0q1 opened a new pull request #20157:
URL: https://github.com/apache/incubator-mxnet/pull/20157


   Move the _op_translations_opsetxx files outside the invisible _op_translation folder


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 merged pull request #20157: [v1.x] fix mx2onnx wheel

Posted by GitBox <gi...@apache.org>.
Zha0q1 merged pull request #20157:
URL: https://github.com/apache/incubator-mxnet/pull/20157


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] waytrue17 commented on pull request #20157: [v1.x] fix mx2onnx wheel

Posted by GitBox <gi...@apache.org>.
waytrue17 commented on pull request #20157:
URL: https://github.com/apache/incubator-mxnet/pull/20157#issuecomment-819193574


   > > Why would we remove the `_op_translation` folder? I think having the folder is better for tracking and maintenance, especially when we start to support more and more versions that ONNX will release.
   > 
   > The folder is invisible to setup.py. Let me see how I can keep the folder while still be able to pack the wheel correctly, I am guessing it's because the underscore?
   
   Yeah, maybe we can try changing the folder name 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20157: [v1.x] fix mx2onnx wheel

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20157:
URL: https://github.com/apache/incubator-mxnet/pull/20157#issuecomment-818269740


   Hey @Zha0q1 , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [miscellaneous, windows-cpu, unix-cpu, windows-gpu, clang, centos-gpu, sanity, unix-gpu, centos-cpu, website, edge]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #20157: [v1.x] fix mx2onnx wheel

Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #20157:
URL: https://github.com/apache/incubator-mxnet/pull/20157#issuecomment-819154572


   > Why would we remove the `_op_translation` folder? I think having the folder is better for tracking and maintenance, especially when we start to support more and more versions that ONNX will release.
   
   The folder is invisible to setup.py. Let me see how I can keep the folder while still be able to pack the wheel correctly, I am guessing it's because the underscore?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] waytrue17 commented on pull request #20157: [v1.x] fix mx2onnx wheel

Posted by GitBox <gi...@apache.org>.
waytrue17 commented on pull request #20157:
URL: https://github.com/apache/incubator-mxnet/pull/20157#issuecomment-819141072


   Why would we remove the `_op_translation` folder? I think having the folder is better for tracking and maintenance, especially when we start to support more and more versions that ONNX will release.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org