Re: [PR] feat(java): channel stream reader [incubator-fury]

["chaokunyang (via GitHub)" <gi...@apache.org>]

chaokunyang commented on code in PR #1483:
URL: https://github.com/apache/incubator-fury/pull/1483#discussion_r1556748821


##########
java/fury-core/src/test/java/org/apache/fury/StreamTest.java:
##########
@@ -204,4 +207,38 @@ public void testJavaOutputStream() throws IOException {
       assertEquals(newObj, beanA);
     }
   }
+
+  @Test
+  public void testReadableChannel() throws IOException {
+    Fury fury = Fury.builder().requireClassRegistration(false).build();
+    BeanA beanA = BeanA.createBeanA(2);
+    {
+      ByteArrayOutputStream bas = new ByteArrayOutputStream();

Review Comment:
   How about using try-with for auto resource release



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org