Groovy macro documentation

[Mario Garcia <ma...@gmail.com>]

Hi all:

I sent a WIP with some groovy-macro documentation. The main problem with
the PR is that there're two tests failing. I've been checking tests code
and I can't see anything that may cause these tests to fail.

I'll be reviewing the whole thing during the weekend but it would be better
if anyone else could look into this.

Of course I'd love to receive feedback related to the documentation. I'm
sure there must be some typos, or something that should be explained
better...

Cheers
Mario

Re: Groovy macro documentation

[Paul King <pa...@asert.com.au>]

I'll try to review over the next little while too. Looks very
promising at first glance! Exciting to see a good start!

Paul.

On Fri, Oct 7, 2016 at 9:17 PM, Guillaume Laforge <gl...@gmail.com> wrote:
> For reference, here's the PR:
> https://github.com/apache/groovy/pull/439
>
> On Fri, Oct 7, 2016 at 1:00 PM, Sergei Egorov <bs...@gmail.com> wrote:
>>
>> Hey Mario,
>>
>> Wow! This is great! Didn't know you're working on it. I'll be happy to
>> review :)
>>
>>
>> Cheers,
>> Sergei
>>
>> On Fri, Oct 7, 2016 at 1:53 PM Mario Garcia <ma...@gmail.com> wrote:
>>>
>>> Hi all:
>>>
>>> I sent a WIP with some groovy-macro documentation. The main problem with
>>> the PR is that there're two tests failing. I've been checking tests code and
>>> I can't see anything that may cause these tests to fail.
>>>
>>> I'll be reviewing the whole thing during the weekend but it would be
>>> better if anyone else could look into this.
>>>
>>> Of course I'd love to receive feedback related to the documentation. I'm
>>> sure there must be some typos, or something that should be explained
>>> better...
>>>
>>> Cheers
>>>
>>> Mario
>
>
>
>
> --
> Guillaume Laforge
> Apache Groovy committer & PMC Vice-President
> Developer Advocate @ Google Cloud Platform
>
> Blog: http://glaforge.appspot.com/
> Social: @glaforge / Google+

Re: Groovy macro documentation

[Guillaume Laforge <gl...@gmail.com>]

For reference, here's the PR:
https://github.com/apache/groovy/pull/439

On Fri, Oct 7, 2016 at 1:00 PM, Sergei Egorov <bs...@gmail.com> wrote:

> Hey Mario,
>
> Wow! This is great! Didn't know you're working on it. I'll be happy to
> review :)
>
>
> Cheers,
> Sergei
>
> On Fri, Oct 7, 2016 at 1:53 PM Mario Garcia <ma...@gmail.com> wrote:
>
>> Hi all:
>>
>> I sent a WIP with some groovy-macro documentation. The main problem with
>> the PR is that there're two tests failing. I've been checking tests code
>> and I can't see anything that may cause these tests to fail.
>>
>> I'll be reviewing the whole thing during the weekend but it would be
>> better if anyone else could look into this.
>>
>> Of course I'd love to receive feedback related to the documentation. I'm
>> sure there must be some typos, or something that should be explained
>> better...
>>
>> Cheers
>>
>> Mario
>>
>


-- 
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform

Blog: http://glaforge.appspot.com/
Social: @glaforge <http://twitter.com/glaforge> / Google+
<https://plus.google.com/u/0/114130972232398734985/posts>

Re: Groovy macro documentation

[Sergei Egorov <bs...@gmail.com>]

Hey Mario,

Wow! This is great! Didn't know you're working on it. I'll be happy to
review :)


Cheers,
Sergei

On Fri, Oct 7, 2016 at 1:53 PM Mario Garcia <ma...@gmail.com> wrote:

> Hi all:
>
> I sent a WIP with some groovy-macro documentation. The main problem with
> the PR is that there're two tests failing. I've been checking tests code
> and I can't see anything that may cause these tests to fail.
>
> I'll be reviewing the whole thing during the weekend but it would be
> better if anyone else could look into this.
>
> Of course I'd love to receive feedback related to the documentation. I'm
> sure there must be some typos, or something that should be explained
> better...
>
> Cheers
>
> Mario
>