[GitHub] vdiravka commented on a change in pull request #1651: DRILL-7042: Fix deb and rpm package issues

[GitBox <gi...@apache.org>]

vdiravka commented on a change in pull request #1651: DRILL-7042: Fix deb and rpm package issues
URL: https://github.com/apache/drill/pull/1651#discussion_r261575882
 
 

 ##########
 File path: distribution/pom.xml
 ##########
 @@ -371,42 +369,81 @@
               </execution>
             </executions>
             <configuration>
-              <copyright>2013 ASF</copyright>
+              <license>http://www.apache.org/licenses/LICENSE-2.0</license>
 
 Review comment:
   * There is no 1.16.0 branch, the last Drill release is 1.15.0. But current Drill [master](https://github.com/apache/drill) branch has [1.16.0-SNAPSHOT](https://github.com/apache/drill/blob/master/pom.xml#L33) version
   * No, you didn't remove these files. You removed only their mentions in Drill Maven plugins. This is your branch with this files: https://github.com/nareshgbhat/drill/tree/DRILL-7042/distribution/src/deb/control
   * You will have `rpm` with this name after rebase onto Drill master branch. And you are right `<release>SNAPSHOT</release>` is redundant.
   
   So please:
   1. rebase your branch onto Drill master branch and force push your changes 
   2. remove `conffiles` and `control` files 
   3. update `<license>` content

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services