You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Devaraj Das (JIRA)" <ji...@apache.org> on 2010/04/15 02:34:03 UTC

[jira] Created: (HADOOP-6706) Relogin behavior for RPC clients could be improved

Relogin behavior for RPC clients could be improved
--------------------------------------------------

                 Key: HADOOP-6706
                 URL: https://issues.apache.org/jira/browse/HADOOP-6706
             Project: Hadoop Common
          Issue Type: Bug
          Components: security
    Affects Versions: 0.22.0
            Reporter: Devaraj Das
            Assignee: Devaraj Das
             Fix For: 0.22.0


Currently, the relogin in the RPC client happens on only a SaslException. But we have seen cases where other exceptions are thrown (like IllegalStateException when the client's ticket is invalid). This jira is to fix that behavior.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HADOOP-6706) Relogin behavior for RPC clients could be improved

Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jitendra Nath Pandey updated HADOOP-6706:
-----------------------------------------

    Attachment: HADOOP-6706.7.patch

> Relogin behavior for RPC clients could be improved
> --------------------------------------------------
>
>                 Key: HADOOP-6706
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6706
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6706-bp20-2.patch, 6706.bp20.1.patch, 6706.bp20.patch, HADOOP-6706-BP20-fix1.patch, HADOOP-6706-BP20-fix2.patch, HADOOP-6706-BP20-fix3.patch, HADOOP-6706.2.patch, HADOOP-6706.4.patch, HADOOP-6706.5.patch, HADOOP-6706.6.patch, HADOOP-6706.7.patch
>
>
> Currently, the relogin in the RPC client happens on only a SaslException. But we have seen cases where other exceptions are thrown (like IllegalStateException when the client's ticket is invalid). This jira is to fix that behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6706) Relogin behavior for RPC clients could be improved

Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Boris Shkolnik updated HADOOP-6706:
-----------------------------------

    Attachment: HADOOP-6706-BP20-fix1.patch

FIX on top .

> Relogin behavior for RPC clients could be improved
> --------------------------------------------------
>
>                 Key: HADOOP-6706
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6706
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6706-bp20-2.patch, 6706.bp20.1.patch, 6706.bp20.patch, HADOOP-6706-BP20-fix1.patch
>
>
> Currently, the relogin in the RPC client happens on only a SaslException. But we have seen cases where other exceptions are thrown (like IllegalStateException when the client's ticket is invalid). This jira is to fix that behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6706) Relogin behavior for RPC clients could be improved

Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jitendra Nath Pandey updated HADOOP-6706:
-----------------------------------------

    Status: Open  (was: Patch Available)

> Relogin behavior for RPC clients could be improved
> --------------------------------------------------
>
>                 Key: HADOOP-6706
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6706
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6706-bp20-2.patch, 6706.bp20.1.patch, 6706.bp20.patch, HADOOP-6706-BP20-fix1.patch, HADOOP-6706-BP20-fix2.patch, HADOOP-6706-BP20-fix3.patch, HADOOP-6706.2.patch, HADOOP-6706.4.patch
>
>
> Currently, the relogin in the RPC client happens on only a SaslException. But we have seen cases where other exceptions are thrown (like IllegalStateException when the client's ticket is invalid). This jira is to fix that behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6706) Relogin behavior for RPC clients could be improved

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894117#action_12894117 ] 

Hadoop QA commented on HADOOP-6706:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12450920/HADOOP-6706.5.patch
  against trunk revision 980648.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 javadoc.  The javadoc tool appears to have generated 1 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/651/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/651/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/651/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/651/console

This message is automatically generated.

> Relogin behavior for RPC clients could be improved
> --------------------------------------------------
>
>                 Key: HADOOP-6706
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6706
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6706-bp20-2.patch, 6706.bp20.1.patch, 6706.bp20.patch, HADOOP-6706-BP20-fix1.patch, HADOOP-6706-BP20-fix2.patch, HADOOP-6706-BP20-fix3.patch, HADOOP-6706.2.patch, HADOOP-6706.4.patch, HADOOP-6706.5.patch
>
>
> Currently, the relogin in the RPC client happens on only a SaslException. But we have seen cases where other exceptions are thrown (like IllegalStateException when the client's ticket is invalid). This jira is to fix that behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6706) Relogin behavior for RPC clients could be improved

Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Devaraj Das updated HADOOP-6706:
--------------------------------

    Attachment: 6706-bp20-2.patch

Updates the relogin behavior even more. Closes the RPC socket on a connection failure. (patch for Y20s).

> Relogin behavior for RPC clients could be improved
> --------------------------------------------------
>
>                 Key: HADOOP-6706
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6706
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6706-bp20-2.patch, 6706.bp20.1.patch, 6706.bp20.patch
>
>
> Currently, the relogin in the RPC client happens on only a SaslException. But we have seen cases where other exceptions are thrown (like IllegalStateException when the client's ticket is invalid). This jira is to fix that behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6706) Relogin behavior for RPC clients could be improved

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893844#action_12893844 ] 

Hadoop QA commented on HADOOP-6706:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12450869/HADOOP-6706.4.patch
  against trunk revision 980533.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 javadoc.  The javadoc tool appears to have generated 1 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/650/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/650/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/650/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/650/console

This message is automatically generated.

> Relogin behavior for RPC clients could be improved
> --------------------------------------------------
>
>                 Key: HADOOP-6706
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6706
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6706-bp20-2.patch, 6706.bp20.1.patch, 6706.bp20.patch, HADOOP-6706-BP20-fix1.patch, HADOOP-6706-BP20-fix2.patch, HADOOP-6706-BP20-fix3.patch, HADOOP-6706.2.patch, HADOOP-6706.4.patch
>
>
> Currently, the relogin in the RPC client happens on only a SaslException. But we have seen cases where other exceptions are thrown (like IllegalStateException when the client's ticket is invalid). This jira is to fix that behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6706) Relogin behavior for RPC clients could be improved

Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894690#action_12894690 ] 

Devaraj Das commented on HADOOP-6706:
-------------------------------------

Looks like due to the order in which the patches from HADOOP-6706 and HADOOP-6718 got applied, there is a small problem in the part where the exception thrown by setupSaslConnection is handled. handleSaslConnection is not called anymore. Please remove that call from your patch.

> Relogin behavior for RPC clients could be improved
> --------------------------------------------------
>
>                 Key: HADOOP-6706
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6706
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6706-bp20-2.patch, 6706.bp20.1.patch, 6706.bp20.patch, HADOOP-6706-BP20-fix1.patch, HADOOP-6706-BP20-fix2.patch, HADOOP-6706-BP20-fix3.patch, HADOOP-6706.2.patch, HADOOP-6706.4.patch, HADOOP-6706.5.patch, HADOOP-6706.6.patch
>
>
> Currently, the relogin in the RPC client happens on only a SaslException. But we have seen cases where other exceptions are thrown (like IllegalStateException when the client's ticket is invalid). This jira is to fix that behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6706) Relogin behavior for RPC clients could be improved

Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Devaraj Das updated HADOOP-6706:
--------------------------------

        Status: Resolved  (was: Patch Available)
    Resolution: Fixed

I just committed this. Thanks, Jitendra for the trunk patches.

> Relogin behavior for RPC clients could be improved
> --------------------------------------------------
>
>                 Key: HADOOP-6706
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6706
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6706-bp20-2.patch, 6706.bp20.1.patch, 6706.bp20.patch, HADOOP-6706-BP20-fix1.patch, HADOOP-6706-BP20-fix2.patch, HADOOP-6706-BP20-fix3.patch, HADOOP-6706.2.patch, HADOOP-6706.4.patch, HADOOP-6706.5.patch, HADOOP-6706.6.patch, HADOOP-6706.7.patch, HADOOP-6706.8.patch
>
>
> Currently, the relogin in the RPC client happens on only a SaslException. But we have seen cases where other exceptions are thrown (like IllegalStateException when the client's ticket is invalid). This jira is to fix that behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6706) Relogin behavior for RPC clients could be improved

Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Boris Shkolnik updated HADOOP-6706:
-----------------------------------

    Attachment: HADOOP-6706-BP20-fix2.patch

addressed comments from Devaraj

> Relogin behavior for RPC clients could be improved
> --------------------------------------------------
>
>                 Key: HADOOP-6706
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6706
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6706-bp20-2.patch, 6706.bp20.1.patch, 6706.bp20.patch, HADOOP-6706-BP20-fix1.patch, HADOOP-6706-BP20-fix2.patch
>
>
> Currently, the relogin in the RPC client happens on only a SaslException. But we have seen cases where other exceptions are thrown (like IllegalStateException when the client's ticket is invalid). This jira is to fix that behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6706) Relogin behavior for RPC clients could be improved

Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Boris Shkolnik updated HADOOP-6706:
-----------------------------------

    Attachment: HADOOP-6706-BP20-fix3.patch

removed unneeded imports.

> Relogin behavior for RPC clients could be improved
> --------------------------------------------------
>
>                 Key: HADOOP-6706
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6706
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6706-bp20-2.patch, 6706.bp20.1.patch, 6706.bp20.patch, HADOOP-6706-BP20-fix1.patch, HADOOP-6706-BP20-fix2.patch, HADOOP-6706-BP20-fix3.patch
>
>
> Currently, the relogin in the RPC client happens on only a SaslException. But we have seen cases where other exceptions are thrown (like IllegalStateException when the client's ticket is invalid). This jira is to fix that behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6706) Relogin behavior for RPC clients could be improved

Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jitendra Nath Pandey updated HADOOP-6706:
-----------------------------------------

    Status: Patch Available  (was: Open)

> Relogin behavior for RPC clients could be improved
> --------------------------------------------------
>
>                 Key: HADOOP-6706
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6706
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6706-bp20-2.patch, 6706.bp20.1.patch, 6706.bp20.patch, HADOOP-6706-BP20-fix1.patch, HADOOP-6706-BP20-fix2.patch, HADOOP-6706-BP20-fix3.patch, HADOOP-6706.2.patch, HADOOP-6706.4.patch, HADOOP-6706.5.patch, HADOOP-6706.6.patch, HADOOP-6706.7.patch
>
>
> Currently, the relogin in the RPC client happens on only a SaslException. But we have seen cases where other exceptions are thrown (like IllegalStateException when the client's ticket is invalid). This jira is to fix that behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6706) Relogin behavior for RPC clients could be improved

Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894206#action_12894206 ] 

Kan Zhang commented on HADOOP-6706:
-----------------------------------

+1, patch looks good. Couple nits.

bq. It's better to call disposeSasl() immediately after closeConnection() in handleSaslConnectionFailure().

bq. Please don't format lines you're not changing otherwise. This will make patch easier to read.

> Relogin behavior for RPC clients could be improved
> --------------------------------------------------
>
>                 Key: HADOOP-6706
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6706
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6706-bp20-2.patch, 6706.bp20.1.patch, 6706.bp20.patch, HADOOP-6706-BP20-fix1.patch, HADOOP-6706-BP20-fix2.patch, HADOOP-6706-BP20-fix3.patch, HADOOP-6706.2.patch, HADOOP-6706.4.patch, HADOOP-6706.5.patch
>
>
> Currently, the relogin in the RPC client happens on only a SaslException. But we have seen cases where other exceptions are thrown (like IllegalStateException when the client's ticket is invalid). This jira is to fix that behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6706) Relogin behavior for RPC clients could be improved

Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jitendra Nath Pandey updated HADOOP-6706:
-----------------------------------------

    Attachment: HADOOP-6706.8.patch

Updated patch fixing the findbugs warning.

> Relogin behavior for RPC clients could be improved
> --------------------------------------------------
>
>                 Key: HADOOP-6706
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6706
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6706-bp20-2.patch, 6706.bp20.1.patch, 6706.bp20.patch, HADOOP-6706-BP20-fix1.patch, HADOOP-6706-BP20-fix2.patch, HADOOP-6706-BP20-fix3.patch, HADOOP-6706.2.patch, HADOOP-6706.4.patch, HADOOP-6706.5.patch, HADOOP-6706.6.patch, HADOOP-6706.7.patch, HADOOP-6706.8.patch
>
>
> Currently, the relogin in the RPC client happens on only a SaslException. But we have seen cases where other exceptions are thrown (like IllegalStateException when the client's ticket is invalid). This jira is to fix that behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6706) Relogin behavior for RPC clients could be improved

Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jitendra Nath Pandey updated HADOOP-6706:
-----------------------------------------

    Attachment: HADOOP-6706.6.patch

New patch addressing the comments.

> Relogin behavior for RPC clients could be improved
> --------------------------------------------------
>
>                 Key: HADOOP-6706
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6706
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6706-bp20-2.patch, 6706.bp20.1.patch, 6706.bp20.patch, HADOOP-6706-BP20-fix1.patch, HADOOP-6706-BP20-fix2.patch, HADOOP-6706-BP20-fix3.patch, HADOOP-6706.2.patch, HADOOP-6706.4.patch, HADOOP-6706.5.patch, HADOOP-6706.6.patch
>
>
> Currently, the relogin in the RPC client happens on only a SaslException. But we have seen cases where other exceptions are thrown (like IllegalStateException when the client's ticket is invalid). This jira is to fix that behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6706) Relogin behavior for RPC clients could be improved

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894754#action_12894754 ] 

Hadoop QA commented on HADOOP-6706:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12451090/HADOOP-6706.8.patch
  against trunk revision 981688.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 javadoc.  The javadoc tool appears to have generated 1 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/660/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/660/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/660/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/660/console

This message is automatically generated.

> Relogin behavior for RPC clients could be improved
> --------------------------------------------------
>
>                 Key: HADOOP-6706
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6706
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6706-bp20-2.patch, 6706.bp20.1.patch, 6706.bp20.patch, HADOOP-6706-BP20-fix1.patch, HADOOP-6706-BP20-fix2.patch, HADOOP-6706-BP20-fix3.patch, HADOOP-6706.2.patch, HADOOP-6706.4.patch, HADOOP-6706.5.patch, HADOOP-6706.6.patch, HADOOP-6706.7.patch, HADOOP-6706.8.patch
>
>
> Currently, the relogin in the RPC client happens on only a SaslException. But we have seen cases where other exceptions are thrown (like IllegalStateException when the client's ticket is invalid). This jira is to fix that behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6706) Relogin behavior for RPC clients could be improved

Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jitendra Nath Pandey updated HADOOP-6706:
-----------------------------------------

    Status: Open  (was: Patch Available)

> Relogin behavior for RPC clients could be improved
> --------------------------------------------------
>
>                 Key: HADOOP-6706
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6706
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6706-bp20-2.patch, 6706.bp20.1.patch, 6706.bp20.patch, HADOOP-6706-BP20-fix1.patch, HADOOP-6706-BP20-fix2.patch, HADOOP-6706-BP20-fix3.patch, HADOOP-6706.2.patch, HADOOP-6706.4.patch, HADOOP-6706.5.patch
>
>
> Currently, the relogin in the RPC client happens on only a SaslException. But we have seen cases where other exceptions are thrown (like IllegalStateException when the client's ticket is invalid). This jira is to fix that behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6706) Relogin behavior for RPC clients could be improved

Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857954#action_12857954 ] 

Devaraj Das commented on HADOOP-6706:
-------------------------------------

One note on the patch is that this is a stop-gap solution (and is lame, in that it banks on exception handling to do relogins). The ideal solution is to use the Refreshable interface and in that case we don't have to rely on exceptions being thrown before attempting relogins. However, as Owen noted in http://tinyurl.com/y6putxk, the patch that uses the Refreshable interface doesn't seem to be working as expected.

> Relogin behavior for RPC clients could be improved
> --------------------------------------------------
>
>                 Key: HADOOP-6706
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6706
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6706.bp20.patch
>
>
> Currently, the relogin in the RPC client happens on only a SaslException. But we have seen cases where other exceptions are thrown (like IllegalStateException when the client's ticket is invalid). This jira is to fix that behavior.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HADOOP-6706) Relogin behavior for RPC clients could be improved

Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jitendra Nath Pandey updated HADOOP-6706:
-----------------------------------------

    Attachment: HADOOP-6706.4.patch

Patch for latest trunk.

> Relogin behavior for RPC clients could be improved
> --------------------------------------------------
>
>                 Key: HADOOP-6706
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6706
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6706-bp20-2.patch, 6706.bp20.1.patch, 6706.bp20.patch, HADOOP-6706-BP20-fix1.patch, HADOOP-6706-BP20-fix2.patch, HADOOP-6706-BP20-fix3.patch, HADOOP-6706.2.patch, HADOOP-6706.4.patch
>
>
> Currently, the relogin in the RPC client happens on only a SaslException. But we have seen cases where other exceptions are thrown (like IllegalStateException when the client's ticket is invalid). This jira is to fix that behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6706) Relogin behavior for RPC clients could be improved

Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jitendra Nath Pandey updated HADOOP-6706:
-----------------------------------------

    Status: Patch Available  (was: Open)

> Relogin behavior for RPC clients could be improved
> --------------------------------------------------
>
>                 Key: HADOOP-6706
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6706
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6706-bp20-2.patch, 6706.bp20.1.patch, 6706.bp20.patch, HADOOP-6706-BP20-fix1.patch, HADOOP-6706-BP20-fix2.patch, HADOOP-6706-BP20-fix3.patch, HADOOP-6706.2.patch, HADOOP-6706.4.patch, HADOOP-6706.5.patch, HADOOP-6706.6.patch
>
>
> Currently, the relogin in the RPC client happens on only a SaslException. But we have seen cases where other exceptions are thrown (like IllegalStateException when the client's ticket is invalid). This jira is to fix that behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6706) Relogin behavior for RPC clients could be improved

Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Devaraj Das updated HADOOP-6706:
--------------------------------

    Attachment: 6706.bp20.patch

Attaching a patch for the Y20 branch. "Exception" is caught and a relogin is attempted. We were debating whether to have relogin done outside the exception block before doing a saslConnect. But even in that case, we need to be able to handle exceptions since some other thread might be currently using the subject credentials that we are just about to destroy (in relogin) and that thread should retry the connection after a relogin. In any case the exception handling is required.

> Relogin behavior for RPC clients could be improved
> --------------------------------------------------
>
>                 Key: HADOOP-6706
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6706
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6706.bp20.patch
>
>
> Currently, the relogin in the RPC client happens on only a SaslException. But we have seen cases where other exceptions are thrown (like IllegalStateException when the client's ticket is invalid). This jira is to fix that behavior.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HADOOP-6706) Relogin behavior for RPC clients could be improved

Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jitendra Nath Pandey updated HADOOP-6706:
-----------------------------------------

    Attachment: HADOOP-6706.2.patch

Patch for trunk.
Incorporates HADOOP-6718 and HADOOP-6776

> Relogin behavior for RPC clients could be improved
> --------------------------------------------------
>
>                 Key: HADOOP-6706
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6706
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6706-bp20-2.patch, 6706.bp20.1.patch, 6706.bp20.patch, HADOOP-6706-BP20-fix1.patch, HADOOP-6706-BP20-fix2.patch, HADOOP-6706-BP20-fix3.patch, HADOOP-6706.2.patch
>
>
> Currently, the relogin in the RPC client happens on only a SaslException. But we have seen cases where other exceptions are thrown (like IllegalStateException when the client's ticket is invalid). This jira is to fix that behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6706) Relogin behavior for RPC clients could be improved

Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jitendra Nath Pandey updated HADOOP-6706:
-----------------------------------------

    Status: Open  (was: Patch Available)

> Relogin behavior for RPC clients could be improved
> --------------------------------------------------
>
>                 Key: HADOOP-6706
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6706
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6706-bp20-2.patch, 6706.bp20.1.patch, 6706.bp20.patch, HADOOP-6706-BP20-fix1.patch, HADOOP-6706-BP20-fix2.patch, HADOOP-6706-BP20-fix3.patch, HADOOP-6706.2.patch, HADOOP-6706.4.patch, HADOOP-6706.5.patch, HADOOP-6706.6.patch, HADOOP-6706.7.patch
>
>
> Currently, the relogin in the RPC client happens on only a SaslException. But we have seen cases where other exceptions are thrown (like IllegalStateException when the client's ticket is invalid). This jira is to fix that behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6706) Relogin behavior for RPC clients could be improved

Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jitendra Nath Pandey updated HADOOP-6706:
-----------------------------------------

    Status: Patch Available  (was: Open)

> Relogin behavior for RPC clients could be improved
> --------------------------------------------------
>
>                 Key: HADOOP-6706
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6706
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6706-bp20-2.patch, 6706.bp20.1.patch, 6706.bp20.patch, HADOOP-6706-BP20-fix1.patch, HADOOP-6706-BP20-fix2.patch, HADOOP-6706-BP20-fix3.patch, HADOOP-6706.2.patch, HADOOP-6706.4.patch
>
>
> Currently, the relogin in the RPC client happens on only a SaslException. But we have seen cases where other exceptions are thrown (like IllegalStateException when the client's ticket is invalid). This jira is to fix that behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6706) Relogin behavior for RPC clients could be improved

Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jitendra Nath Pandey updated HADOOP-6706:
-----------------------------------------

    Status: Open  (was: Patch Available)

> Relogin behavior for RPC clients could be improved
> --------------------------------------------------
>
>                 Key: HADOOP-6706
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6706
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6706-bp20-2.patch, 6706.bp20.1.patch, 6706.bp20.patch, HADOOP-6706-BP20-fix1.patch, HADOOP-6706-BP20-fix2.patch, HADOOP-6706-BP20-fix3.patch, HADOOP-6706.2.patch, HADOOP-6706.4.patch, HADOOP-6706.5.patch, HADOOP-6706.6.patch, HADOOP-6706.7.patch, HADOOP-6706.8.patch
>
>
> Currently, the relogin in the RPC client happens on only a SaslException. But we have seen cases where other exceptions are thrown (like IllegalStateException when the client's ticket is invalid). This jira is to fix that behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6706) Relogin behavior for RPC clients could be improved

Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857915#action_12857915 ] 

Jitendra Nath Pandey commented on HADOOP-6706:
----------------------------------------------

patch looks good.

> Relogin behavior for RPC clients could be improved
> --------------------------------------------------
>
>                 Key: HADOOP-6706
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6706
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6706.bp20.patch
>
>
> Currently, the relogin in the RPC client happens on only a SaslException. But we have seen cases where other exceptions are thrown (like IllegalStateException when the client's ticket is invalid). This jira is to fix that behavior.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HADOOP-6706) Relogin behavior for RPC clients could be improved

Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894724#action_12894724 ] 

Jitendra Nath Pandey commented on HADOOP-6706:
----------------------------------------------

New patch addressing the comment.

> Relogin behavior for RPC clients could be improved
> --------------------------------------------------
>
>                 Key: HADOOP-6706
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6706
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6706-bp20-2.patch, 6706.bp20.1.patch, 6706.bp20.patch, HADOOP-6706-BP20-fix1.patch, HADOOP-6706-BP20-fix2.patch, HADOOP-6706-BP20-fix3.patch, HADOOP-6706.2.patch, HADOOP-6706.4.patch, HADOOP-6706.5.patch, HADOOP-6706.6.patch, HADOOP-6706.7.patch
>
>
> Currently, the relogin in the RPC client happens on only a SaslException. But we have seen cases where other exceptions are thrown (like IllegalStateException when the client's ticket is invalid). This jira is to fix that behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6706) Relogin behavior for RPC clients could be improved

Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jitendra Nath Pandey updated HADOOP-6706:
-----------------------------------------

    Attachment: HADOOP-6706.5.patch

New patch uploaded. Previous patch had an error.

> Relogin behavior for RPC clients could be improved
> --------------------------------------------------
>
>                 Key: HADOOP-6706
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6706
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6706-bp20-2.patch, 6706.bp20.1.patch, 6706.bp20.patch, HADOOP-6706-BP20-fix1.patch, HADOOP-6706-BP20-fix2.patch, HADOOP-6706-BP20-fix3.patch, HADOOP-6706.2.patch, HADOOP-6706.4.patch, HADOOP-6706.5.patch
>
>
> Currently, the relogin in the RPC client happens on only a SaslException. But we have seen cases where other exceptions are thrown (like IllegalStateException when the client's ticket is invalid). This jira is to fix that behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6706) Relogin behavior for RPC clients could be improved

Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jitendra Nath Pandey updated HADOOP-6706:
-----------------------------------------

    Status: Open  (was: Patch Available)

> Relogin behavior for RPC clients could be improved
> --------------------------------------------------
>
>                 Key: HADOOP-6706
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6706
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6706-bp20-2.patch, 6706.bp20.1.patch, 6706.bp20.patch, HADOOP-6706-BP20-fix1.patch, HADOOP-6706-BP20-fix2.patch, HADOOP-6706-BP20-fix3.patch, HADOOP-6706.2.patch
>
>
> Currently, the relogin in the RPC client happens on only a SaslException. But we have seen cases where other exceptions are thrown (like IllegalStateException when the client's ticket is invalid). This jira is to fix that behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6706) Relogin behavior for RPC clients could be improved

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894731#action_12894731 ] 

Hadoop QA commented on HADOOP-6706:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12451082/HADOOP-6706.7.patch
  against trunk revision 981688.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 javadoc.  The javadoc tool appears to have generated 1 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 1 new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/659/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/659/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/659/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/659/console

This message is automatically generated.

> Relogin behavior for RPC clients could be improved
> --------------------------------------------------
>
>                 Key: HADOOP-6706
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6706
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6706-bp20-2.patch, 6706.bp20.1.patch, 6706.bp20.patch, HADOOP-6706-BP20-fix1.patch, HADOOP-6706-BP20-fix2.patch, HADOOP-6706-BP20-fix3.patch, HADOOP-6706.2.patch, HADOOP-6706.4.patch, HADOOP-6706.5.patch, HADOOP-6706.6.patch, HADOOP-6706.7.patch
>
>
> Currently, the relogin in the RPC client happens on only a SaslException. But we have seen cases where other exceptions are thrown (like IllegalStateException when the client's ticket is invalid). This jira is to fix that behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6706) Relogin behavior for RPC clients could be improved

Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jitendra Nath Pandey updated HADOOP-6706:
-----------------------------------------

    Status: Patch Available  (was: Open)

> Relogin behavior for RPC clients could be improved
> --------------------------------------------------
>
>                 Key: HADOOP-6706
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6706
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6706-bp20-2.patch, 6706.bp20.1.patch, 6706.bp20.patch, HADOOP-6706-BP20-fix1.patch, HADOOP-6706-BP20-fix2.patch, HADOOP-6706-BP20-fix3.patch, HADOOP-6706.2.patch, HADOOP-6706.4.patch, HADOOP-6706.5.patch, HADOOP-6706.6.patch, HADOOP-6706.7.patch, HADOOP-6706.8.patch
>
>
> Currently, the relogin in the RPC client happens on only a SaslException. But we have seen cases where other exceptions are thrown (like IllegalStateException when the client's ticket is invalid). This jira is to fix that behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6706) Relogin behavior for RPC clients could be improved

Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Devaraj Das updated HADOOP-6706:
--------------------------------

    Attachment: 6706.bp20.1.patch

Attaching a patch that fixes a bug in the earlier version of the Y20s patch. Not for commit.

> Relogin behavior for RPC clients could be improved
> --------------------------------------------------
>
>                 Key: HADOOP-6706
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6706
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6706.bp20.1.patch, 6706.bp20.patch
>
>
> Currently, the relogin in the RPC client happens on only a SaslException. But we have seen cases where other exceptions are thrown (like IllegalStateException when the client's ticket is invalid). This jira is to fix that behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6706) Relogin behavior for RPC clients could be improved

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894219#action_12894219 ] 

Hadoop QA commented on HADOOP-6706:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12450934/HADOOP-6706.6.patch
  against trunk revision 980953.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 javadoc.  The javadoc tool appears to have generated 1 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/654/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/654/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/654/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/654/console

This message is automatically generated.

> Relogin behavior for RPC clients could be improved
> --------------------------------------------------
>
>                 Key: HADOOP-6706
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6706
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6706-bp20-2.patch, 6706.bp20.1.patch, 6706.bp20.patch, HADOOP-6706-BP20-fix1.patch, HADOOP-6706-BP20-fix2.patch, HADOOP-6706-BP20-fix3.patch, HADOOP-6706.2.patch, HADOOP-6706.4.patch, HADOOP-6706.5.patch, HADOOP-6706.6.patch
>
>
> Currently, the relogin in the RPC client happens on only a SaslException. But we have seen cases where other exceptions are thrown (like IllegalStateException when the client's ticket is invalid). This jira is to fix that behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6706) Relogin behavior for RPC clients could be improved

Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894681#action_12894681 ] 

Jitendra Nath Pandey commented on HADOOP-6706:
----------------------------------------------

javadoc warnings are in KerberosName.java and SecurityUtil.java and are unrelated to this patch.

The patch was manually tested on Y20 branch.

> Relogin behavior for RPC clients could be improved
> --------------------------------------------------
>
>                 Key: HADOOP-6706
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6706
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6706-bp20-2.patch, 6706.bp20.1.patch, 6706.bp20.patch, HADOOP-6706-BP20-fix1.patch, HADOOP-6706-BP20-fix2.patch, HADOOP-6706-BP20-fix3.patch, HADOOP-6706.2.patch, HADOOP-6706.4.patch, HADOOP-6706.5.patch, HADOOP-6706.6.patch
>
>
> Currently, the relogin in the RPC client happens on only a SaslException. But we have seen cases where other exceptions are thrown (like IllegalStateException when the client's ticket is invalid). This jira is to fix that behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6706) Relogin behavior for RPC clients could be improved

Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jitendra Nath Pandey updated HADOOP-6706:
-----------------------------------------

    Status: Patch Available  (was: Open)

> Relogin behavior for RPC clients could be improved
> --------------------------------------------------
>
>                 Key: HADOOP-6706
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6706
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6706-bp20-2.patch, 6706.bp20.1.patch, 6706.bp20.patch, HADOOP-6706-BP20-fix1.patch, HADOOP-6706-BP20-fix2.patch, HADOOP-6706-BP20-fix3.patch, HADOOP-6706.2.patch
>
>
> Currently, the relogin in the RPC client happens on only a SaslException. But we have seen cases where other exceptions are thrown (like IllegalStateException when the client's ticket is invalid). This jira is to fix that behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6706) Relogin behavior for RPC clients could be improved

Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892548#action_12892548 ] 

Jitendra Nath Pandey commented on HADOOP-6706:
----------------------------------------------

HADOOP-6706.2.patch is not for commit. It also includes the patch for HADOOP-6656.

> Relogin behavior for RPC clients could be improved
> --------------------------------------------------
>
>                 Key: HADOOP-6706
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6706
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6706-bp20-2.patch, 6706.bp20.1.patch, 6706.bp20.patch, HADOOP-6706-BP20-fix1.patch, HADOOP-6706-BP20-fix2.patch, HADOOP-6706-BP20-fix3.patch, HADOOP-6706.2.patch
>
>
> Currently, the relogin in the RPC client happens on only a SaslException. But we have seen cases where other exceptions are thrown (like IllegalStateException when the client's ticket is invalid). This jira is to fix that behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6706) Relogin behavior for RPC clients could be improved

Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jitendra Nath Pandey updated HADOOP-6706:
-----------------------------------------

    Status: Patch Available  (was: Open)

> Relogin behavior for RPC clients could be improved
> --------------------------------------------------
>
>                 Key: HADOOP-6706
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6706
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6706-bp20-2.patch, 6706.bp20.1.patch, 6706.bp20.patch, HADOOP-6706-BP20-fix1.patch, HADOOP-6706-BP20-fix2.patch, HADOOP-6706-BP20-fix3.patch, HADOOP-6706.2.patch, HADOOP-6706.4.patch, HADOOP-6706.5.patch
>
>
> Currently, the relogin in the RPC client happens on only a SaslException. But we have seen cases where other exceptions are thrown (like IllegalStateException when the client's ticket is invalid). This jira is to fix that behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6706) Relogin behavior for RPC clients could be improved

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892540#action_12892540 ] 

Hadoop QA commented on HADOOP-6706:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12450536/HADOOP-6706.2.patch
  against trunk revision 979387.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    -1 javadoc.  The javadoc tool appears to have generated 1 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/637/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/637/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/637/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/637/console

This message is automatically generated.

> Relogin behavior for RPC clients could be improved
> --------------------------------------------------
>
>                 Key: HADOOP-6706
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6706
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.22.0
>
>         Attachments: 6706-bp20-2.patch, 6706.bp20.1.patch, 6706.bp20.patch, HADOOP-6706-BP20-fix1.patch, HADOOP-6706-BP20-fix2.patch, HADOOP-6706-BP20-fix3.patch, HADOOP-6706.2.patch
>
>
> Currently, the relogin in the RPC client happens on only a SaslException. But we have seen cases where other exceptions are thrown (like IllegalStateException when the client's ticket is invalid). This jira is to fix that behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.