You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Dimitri Unruh (Created) (JIRA)" <ji...@apache.org> on 2011/09/29 09:52:45 UTC
[jira] [Created] (OFBIZ-4453) Refactoring JMS Handling
Refactoring JMS Handling
------------------------
Key: OFBIZ-4453
URL: https://issues.apache.org/jira/browse/OFBIZ-4453
Project: OFBiz
Issue Type: Improvement
Components: framework
Reporter: Dimitri Unruh
This is the main ticket for the JMS refactoring tasks.
I would like to start here some concept discussion ant the create sub-tasks...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4453) Refactoring JMS Handling
Posted by "Martin Kreidenweis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117143#comment-13117143 ]
Martin Kreidenweis commented on OFBIZ-4453:
-------------------------------------------
I'd like to make two remarks:
I think the JMS connection should be reused. Currently the JMSServiceEngine does a new lookup and creates a new connection for every service call. This is not particularly performant.
Security is an issue: sending the serialized userLogin entity provides no security at all. So anybody with access to the JMS Topic can run any service on an OFBiz instance currently. There probably is no easy way to fix this, but people need to know about it. Maybe this is no OFBiz issue at all but an operations issue: the messaging server and connections have to be secured properly.
> Refactoring JMS Handling
> ------------------------
>
> Key: OFBIZ-4453
> URL: https://issues.apache.org/jira/browse/OFBIZ-4453
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Dimitri Unruh
>
> This is the main ticket for the JMS refactoring tasks.
> I would like to start here some concept discussion ant the create sub-tasks...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4453) Refactoring JMS Handling
Posted by "Martin Kreidenweis (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Kreidenweis updated OFBIZ-4453:
--------------------------------------
Attachment: JMS-keep-connection.patch
We already made some code changes to reuse the ActiveMQ connection for sending data:
* Created JmsServiceJndiConfiguration class, which has the JNDI specific configuration
* Created JmsServiceSession class, which holds all data associated to an open connection to ActiveMW so that all resources can be closed appropriately
* Adapted the JmsServiceEngine to check if the connection was not open and to reopen a connection on failing to connect to ActiveMQ
> Refactoring JMS Handling
> ------------------------
>
> Key: OFBIZ-4453
> URL: https://issues.apache.org/jira/browse/OFBIZ-4453
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Dimitri Unruh
> Attachments: JMS-keep-connection.patch
>
>
> This is the main ticket for the JMS refactoring tasks.
> I would like to start here some concept discussion ant the create sub-tasks...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4453) Refactoring JMS Handling
Posted by "BJ Freeman (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118293#comment-13118293 ]
BJ Freeman commented on OFBIZ-4453:
-----------------------------------
Since JMSservice is commented out could you give a reason you see this important.
More for my edification
> Refactoring JMS Handling
> ------------------------
>
> Key: OFBIZ-4453
> URL: https://issues.apache.org/jira/browse/OFBIZ-4453
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Dimitri Unruh
> Attachments: JMS-keep-connection.patch
>
>
> This is the main ticket for the JMS refactoring tasks.
> I would like to start here some concept discussion ant the create sub-tasks...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira