You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/02/24 20:24:00 UTC
[jira] [Commented] (GEODE-8971) Batches with incomplete
transactions when stopping the gateway sender
[ https://issues.apache.org/jira/browse/GEODE-8971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17290242#comment-17290242 ]
ASF GitHub Bot commented on GEODE-8971:
---------------------------------------
albertogpz opened a new pull request #6052:
URL: https://github.com/apache/geode/pull/6052
…transaction-events enabled
When the gateway sender is stopped there is a high probability that batches with
incomplete transactions are sent even if group-transaction-events is enabled.
The reason is that once the stop command reaches the gateway sender, it immediately
stops queueing events, and this could happen in the middle of receiving events for the
same transaction. If this is the case, some events for the transaction may have
reached the queue right before the stop command was received and the rest of events
for that transaction would not make it to the queue (they would be dropped) because
they arrived right after the stop command was received at the gateway sender.
One way to solve this issue to allow for a grace period when the gateway sender
is stopped during which only events that belong to transactions already
in the queue are queued. Any other event received by the gateway sender
during this grace period would be dropped. After this grace period
the gateway sender will be effectively stopped.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Batches with incomplete transactions when stopping the gateway sender
> ---------------------------------------------------------------------
>
> Key: GEODE-8971
> URL: https://issues.apache.org/jira/browse/GEODE-8971
> Project: Geode
> Issue Type: Improvement
> Components: wan
> Affects Versions: 1.14.0
> Reporter: Alberto Gomez
> Assignee: Alberto Gomez
> Priority: Major
>
> When the gateway sender is stopped there is a high probability that batches with incomplete transactions are sent even if group-transaction-events is enabled.
> The reason is that once the stop command reaches the gateway sender, it immediately stops queueing events, and this could happen in the middle of receiving events for the same transaction. If this is the case, some events for the transaction may have reached the queue right before the stop command was received and the rest of events for that transaction would not make it to the queue (they would be dropped) because they arrived right after the stop command was received at the gateway sender.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)