You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by "nickva (via GitHub)" <gi...@apache.org> on 2023/05/10 17:27:41 UTC
[GitHub] [couchdb] nickva opened a new pull request, #4593: Merge 3.3.x to main
nickva opened a new pull request, #4593:
URL: https://github.com/apache/couchdb/pull/4593
Bring in 3.3.x branch changes into main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva merged pull request #4593: Merge 3.3.x to main
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva merged PR #4593:
URL: https://github.com/apache/couchdb/pull/4593
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] pgj commented on a diff in pull request #4593: Merge 3.3.x to main
Posted by "pgj (via GitHub)" <gi...@apache.org>.
pgj commented on code in PR #4593:
URL: https://github.com/apache/couchdb/pull/4593#discussion_r1190867553
##########
src/docs/src/whatsnew/3.3.rst:
##########
@@ -83,6 +83,7 @@ Features and Enhancements
* :ghissue:`4347`: Remove failed ``couch_plugins`` experiment, fixes more
``undef`` errors.
* :ghissue:`4348`: Fix ``undef`` error in ``weatherreport``.
+* :ghissue:`4353`: Allow starting of more than one replication job. (D’OH!)
Review Comment:
"D'OH"? Should not the release notes stick to a more formal technical style? I am just curious.
##########
dev/run:
##########
@@ -475,7 +475,6 @@ def boot_nouveau(ctx):
"server",
"nouveau.yaml",
]
-
Review Comment:
Was not this an unintended change? If not, why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] pgj commented on a diff in pull request #4593: Merge 3.3.x to main
Posted by "pgj (via GitHub)" <gi...@apache.org>.
pgj commented on code in PR #4593:
URL: https://github.com/apache/couchdb/pull/4593#discussion_r1191782917
##########
src/docs/src/whatsnew/3.3.rst:
##########
@@ -83,6 +83,7 @@ Features and Enhancements
* :ghissue:`4347`: Remove failed ``couch_plugins`` experiment, fixes more
``undef`` errors.
* :ghissue:`4348`: Fix ``undef`` error in ``weatherreport``.
+* :ghissue:`4353`: Allow starting of more than one replication job. (D’OH!)
Review Comment:
Thanks for the explanation :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] big-r81 commented on a diff in pull request #4593: Merge 3.3.x to main
Posted by "big-r81 (via GitHub)" <gi...@apache.org>.
big-r81 commented on code in PR #4593:
URL: https://github.com/apache/couchdb/pull/4593#discussion_r1191525165
##########
src/docs/src/whatsnew/3.3.rst:
##########
@@ -83,6 +83,7 @@ Features and Enhancements
* :ghissue:`4347`: Remove failed ``couch_plugins`` experiment, fixes more
``undef`` errors.
* :ghissue:`4348`: Fix ``undef`` error in ``weatherreport``.
+* :ghissue:`4353`: Allow starting of more than one replication job. (D’OH!)
Review Comment:
Something like
`A big bowl of candy! OK, no, not really. If you got this far…thank you for reading.`
as the last point...
A slight smile is always good at the end ... 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva commented on a diff in pull request #4593: Merge 3.3.x to main
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on code in PR #4593:
URL: https://github.com/apache/couchdb/pull/4593#discussion_r1191514727
##########
dev/run:
##########
@@ -475,7 +475,6 @@ def boot_nouveau(ctx):
"server",
"nouveau.yaml",
]
-
Review Comment:
It just showed as a diff between the 3.3.x branch and I thought'd bring it over to minimize differences.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva commented on a diff in pull request #4593: Merge 3.3.x to main
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on code in PR #4593:
URL: https://github.com/apache/couchdb/pull/4593#discussion_r1191519009
##########
src/docs/src/whatsnew/3.3.rst:
##########
@@ -83,6 +83,7 @@ Features and Enhancements
* :ghissue:`4347`: Remove failed ``couch_plugins`` experiment, fixes more
``undef`` errors.
* :ghissue:`4348`: Fix ``undef`` error in ``weatherreport``.
+* :ghissue:`4353`: Allow starting of more than one replication job. (D’OH!)
Review Comment:
Nah, we like to be a bit informal and whimsical with our release notes. They often reflect the personality of whoever writes them. We have [Star Trek references](https://docs.couchdb.org/en/stable/whatsnew/3.3.html#highlights), [Rainbow Gnomes](https://docs.couchdb.org/en/stable/whatsnew/3.1.html#features-and-enhancements), [Party cats](https://docs.couchdb.org/en/stable/whatsnew/3.0.html#upgrade-notes) and other such things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] pgj commented on a diff in pull request #4593: Merge 3.3.x to main
Posted by "pgj (via GitHub)" <gi...@apache.org>.
pgj commented on code in PR #4593:
URL: https://github.com/apache/couchdb/pull/4593#discussion_r1191782507
##########
dev/run:
##########
@@ -475,7 +475,6 @@ def boot_nouveau(ctx):
"server",
"nouveau.yaml",
]
-
Review Comment:
Ah, now it makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org