You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/06 02:30:39 UTC

[GitHub] [dolphinscheduler] ChrisYuan opened a new pull request, #11326: add postgresql config in doc: datasource-setting

ChrisYuan opened a new pull request, #11326:
URL: https://github.com/apache/dolphinscheduler/pull/11326

   ## Purpose of the pull request
   
   fix issue #11217, improve the datasource-setting doc by adding postgresql.
   
   ## Brief change log
   
   - fix a type '次为非重要信息' -> '此为非重要信息'
   - add how to create database/user and give permission in postgresql 
   - add postgresql datasource config example
   
   ## Verify this pull request
   
   This pull request is code cleanup without any test coverage.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] ChrisYuan commented on a diff in pull request #11326: [Fix-11217] [Doc] add postgresql config in doc: datasource-setting

Posted by GitBox <gi...@apache.org>.
ChrisYuan commented on code in PR #11326:
URL: https://github.com/apache/dolphinscheduler/pull/11326#discussion_r943044734


##########
docs/docs/en/guide/howto/datasource-setting.md:
##########
@@ -51,16 +52,44 @@ mysql> GRANT ALL PRIVILEGES ON dolphinscheduler.* TO '{user}'@'localhost';
 mysql> FLUSH PRIVILEGES;
 ``` 
 
-Then, modify `./bin/env/dolphinscheduler_env.sh` to use mysql, change {user} and {password} to what you set in the previous step.
+For PostgreSQL: 
+```shell
+# Use psql-tools to login PostgreSQL
+psql
+# Create a database
+postgres=# CREATE DATABASE dolphinscheduler;
+# Replace {user} and {password} with your username and password

Review Comment:
   Hi there, is it a bit strange for changing postresql part only? I think '{}' is clear for others, let's keep it or talk?



##########
docs/docs/en/guide/howto/datasource-setting.md:
##########
@@ -51,16 +52,44 @@ mysql> GRANT ALL PRIVILEGES ON dolphinscheduler.* TO '{user}'@'localhost';
 mysql> FLUSH PRIVILEGES;
 ``` 
 
-Then, modify `./bin/env/dolphinscheduler_env.sh` to use mysql, change {user} and {password} to what you set in the previous step.
+For PostgreSQL: 
+```shell
+# Use psql-tools to login PostgreSQL
+psql
+# Create a database
+postgres=# CREATE DATABASE dolphinscheduler;
+# Replace {user} and {password} with your username and password

Review Comment:
   OK, got it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] EricGao888 merged pull request #11326: [Fix-11217] [Doc] add postgresql config in doc: datasource-setting

Posted by GitBox <gi...@apache.org>.
EricGao888 merged PR #11326:
URL: https://github.com/apache/dolphinscheduler/pull/11326


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #11326: [Fix-11217] [Doc] add postgresql config in doc: datasource-setting

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #11326:
URL: https://github.com/apache/dolphinscheduler/pull/11326#discussion_r940991098


##########
docs/docs/en/guide/howto/datasource-setting.md:
##########
@@ -20,7 +20,8 @@ export SPRING_DATASOURCE_PASSWORD={password}
 ## Pseudo-Cluster/Cluster Initialize the Database
 
 DolphinScheduler metadata is stored in the relational database. Currently, supports PostgreSQL and MySQL. If you use MySQL, you need to manually download [mysql-connector-java driver][mysql] (8.0.16) and move it to the libs directory of DolphinScheduler
-which is `api-server/libs/` and `alert-server/libs` and `master-server/libs` and `worker-server/libs`. Let's take MySQL as an example for how to initialize the database:
+which is `api-server/libs/` and `alert-server/libs` and `master-server/libs` and `worker-server/libs`, just ignore this steps if you use PostgreSQL. Let's walk through how to initialize the database in MySQL

Review Comment:
   How about adding note syntax for mysql part?
   
   ```md
   NOTE: If you use MySQL, you need to manually download [mysql-connector-java driver][mysql] (8.0.16) and move it to the libs directory of DolphinScheduler ....
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #11326: [Fix-11217] [Doc] add postgresql config in doc: datasource-setting

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #11326:
URL: https://github.com/apache/dolphinscheduler/pull/11326#discussion_r940995766


##########
docs/docs/en/guide/howto/datasource-setting.md:
##########
@@ -51,16 +52,44 @@ mysql> GRANT ALL PRIVILEGES ON dolphinscheduler.* TO '{user}'@'localhost';
 mysql> FLUSH PRIVILEGES;
 ``` 
 
-Then, modify `./bin/env/dolphinscheduler_env.sh` to use mysql, change {user} and {password} to what you set in the previous step.
+For PostgreSQL: 
+```shell
+# Use psql-tools to login PostgreSQL
+psql
+# Create a database
+postgres=# CREATE DATABASE dolphinscheduler;
+# Replace {user} and {password} with your username and password

Review Comment:
   I think we should use `<>` for the required parameter, could you please also change the other place?
   ```suggestion
   # Replace <user> and <password> with your username and password
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] ChrisYuan commented on a diff in pull request #11326: [Fix-11217] [Doc] add postgresql config in doc: datasource-setting

Posted by GitBox <gi...@apache.org>.
ChrisYuan commented on code in PR #11326:
URL: https://github.com/apache/dolphinscheduler/pull/11326#discussion_r943040240


##########
docs/docs/en/guide/howto/datasource-setting.md:
##########
@@ -20,7 +20,8 @@ export SPRING_DATASOURCE_PASSWORD={password}
 ## Pseudo-Cluster/Cluster Initialize the Database
 
 DolphinScheduler metadata is stored in the relational database. Currently, supports PostgreSQL and MySQL. If you use MySQL, you need to manually download [mysql-connector-java driver][mysql] (8.0.16) and move it to the libs directory of DolphinScheduler
-which is `api-server/libs/` and `alert-server/libs` and `master-server/libs` and `worker-server/libs`. Let's take MySQL as an example for how to initialize the database:
+which is `api-server/libs/` and `alert-server/libs` and `master-server/libs` and `worker-server/libs`, just ignore this steps if you use PostgreSQL. Let's walk through how to initialize the database in MySQL

Review Comment:
   oh, I know, let me change it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] ChrisYuan commented on a diff in pull request #11326: [Fix-11217] [Doc] add postgresql config in doc: datasource-setting

Posted by GitBox <gi...@apache.org>.
ChrisYuan commented on code in PR #11326:
URL: https://github.com/apache/dolphinscheduler/pull/11326#discussion_r943040049


##########
docs/docs/en/guide/howto/datasource-setting.md:
##########
@@ -51,16 +52,44 @@ mysql> GRANT ALL PRIVILEGES ON dolphinscheduler.* TO '{user}'@'localhost';
 mysql> FLUSH PRIVILEGES;
 ``` 
 
-Then, modify `./bin/env/dolphinscheduler_env.sh` to use mysql, change {user} and {password} to what you set in the previous step.
+For PostgreSQL: 
+```shell
+# Use psql-tools to login PostgreSQL
+psql
+# Create a database
+postgres=# CREATE DATABASE dolphinscheduler;
+# Replace {user} and {password} with your username and password

Review Comment:
   OK, got it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] ChrisYuan commented on a diff in pull request #11326: [Fix-11217] [Doc] add postgresql config in doc: datasource-setting

Posted by GitBox <gi...@apache.org>.
ChrisYuan commented on code in PR #11326:
URL: https://github.com/apache/dolphinscheduler/pull/11326#discussion_r962344460


##########
docs/docs/en/guide/howto/datasource-setting.md:
##########
@@ -19,8 +22,10 @@ export SPRING_DATASOURCE_PASSWORD={password}
 
 ## Pseudo-Cluster/Cluster Initialize the Database
 
-DolphinScheduler metadata is stored in the relational database. Currently, supports PostgreSQL and MySQL. If you use MySQL, you need to manually download [mysql-connector-java driver][mysql] (8.0.16) and move it to the libs directory of DolphinScheduler
-which is `api-server/libs/` and `alert-server/libs` and `master-server/libs` and `worker-server/libs` and `tools/libs`. Let's take MySQL as an example for how to initialize the database:
+DolphinScheduler metadata is stored in the relational database. Currently, supports PostgreSQL and MySQL. Let's walk through how to initialize the database in MySQL and PostgreSQL :

Review Comment:
   > In tech writing, we usually avoid `passive voice` unless necessary.
   
   OK, thanks for your advice, keep this rule in the future.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] EricGao888 commented on pull request #11326: [Fix-11217] [Doc] add postgresql config in doc: datasource-setting

Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #11326:
URL: https://github.com/apache/dolphinscheduler/pull/11326#issuecomment-1236495635

   @ChrisYuan Good job! Thanks for your contributions!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] ChrisYuan commented on pull request #11326: [Fix-11217] [Doc] add postgresql config in doc: datasource-setting

Posted by GitBox <gi...@apache.org>.
ChrisYuan commented on PR #11326:
URL: https://github.com/apache/dolphinscheduler/pull/11326#issuecomment-1236377766

   ping, please review, thanks~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #11326: [Fix-11217] [Doc] add postgresql config in doc: datasource-setting

Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #11326:
URL: https://github.com/apache/dolphinscheduler/pull/11326#discussion_r962342313


##########
docs/docs/en/guide/howto/datasource-setting.md:
##########
@@ -19,8 +22,10 @@ export SPRING_DATASOURCE_PASSWORD={password}
 
 ## Pseudo-Cluster/Cluster Initialize the Database
 
-DolphinScheduler metadata is stored in the relational database. Currently, supports PostgreSQL and MySQL. If you use MySQL, you need to manually download [mysql-connector-java driver][mysql] (8.0.16) and move it to the libs directory of DolphinScheduler
-which is `api-server/libs/` and `alert-server/libs` and `master-server/libs` and `worker-server/libs` and `tools/libs`. Let's take MySQL as an example for how to initialize the database:
+DolphinScheduler metadata is stored in the relational database. Currently, supports PostgreSQL and MySQL. Let's walk through how to initialize the database in MySQL and PostgreSQL :

Review Comment:
   In tech writing, we usually avoid `passive voice` unless necessary.



##########
docs/docs/en/guide/howto/datasource-setting.md:
##########
@@ -19,8 +22,10 @@ export SPRING_DATASOURCE_PASSWORD={password}
 
 ## Pseudo-Cluster/Cluster Initialize the Database
 
-DolphinScheduler metadata is stored in the relational database. Currently, supports PostgreSQL and MySQL. If you use MySQL, you need to manually download [mysql-connector-java driver][mysql] (8.0.16) and move it to the libs directory of DolphinScheduler
-which is `api-server/libs/` and `alert-server/libs` and `master-server/libs` and `worker-server/libs` and `tools/libs`. Let's take MySQL as an example for how to initialize the database:
+DolphinScheduler metadata is stored in the relational database. Currently, supports PostgreSQL and MySQL. Let's walk through how to initialize the database in MySQL and PostgreSQL :

Review Comment:
   ```suggestion
   DolphinScheduler stores metadata in `relational database`. Currently, we support `PostgreSQL` and `MySQL`. Let's walk through how to initialize the database in `MySQL` and `PostgreSQL` :
   ```



##########
docs/docs/zh/guide/howto/datasource-setting.md:
##########
@@ -19,8 +21,10 @@ export SPRING_DATASOURCE_PASSWORD={password}
 
 ## 伪分布式/分布式安装初始化数据库
 
-DolphinScheduler 元数据存储在关系型数据库中，目前支持 PostgreSQL 和 MySQL，如果使用 MySQL 则需要手动下载 [mysql-connector-java 驱动][mysql] (8.0.16) 并移动到 DolphinScheduler 的每个模块的 libs 目录下
-其中包括 `api-server/libs/` 和 `alert-server/libs` 和 `master-server/libs` 和 `worker-server/libs` 和 `tools/libs`。下面以 MySQL 为例，说明如何初始化数据库
+DolphinScheduler 元数据存储在关系型数据库中，目前支持 PostgreSQL 和 MySQL。下面分别介绍如何使用 MySQL 和 PostgresQL 初始化数据库.

Review Comment:
   ```suggestion
   DolphinScheduler 元数据存储在关系型数据库中，目前支持 PostgreSQL 和 MySQL。下面分别介绍如何使用 MySQL 和 PostgresQL 初始化数据库。
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] ChrisYuan commented on a diff in pull request #11326: [Fix-11217] [Doc] add postgresql config in doc: datasource-setting

Posted by GitBox <gi...@apache.org>.
ChrisYuan commented on code in PR #11326:
URL: https://github.com/apache/dolphinscheduler/pull/11326#discussion_r943050046


##########
docs/docs/en/guide/howto/datasource-setting.md:
##########
@@ -20,7 +20,8 @@ export SPRING_DATASOURCE_PASSWORD={password}
 ## Pseudo-Cluster/Cluster Initialize the Database
 
 DolphinScheduler metadata is stored in the relational database. Currently, supports PostgreSQL and MySQL. If you use MySQL, you need to manually download [mysql-connector-java driver][mysql] (8.0.16) and move it to the libs directory of DolphinScheduler
-which is `api-server/libs/` and `alert-server/libs` and `master-server/libs` and `worker-server/libs`. Let's take MySQL as an example for how to initialize the database:
+which is `api-server/libs/` and `alert-server/libs` and `master-server/libs` and `worker-server/libs`, just ignore this steps if you use PostgreSQL. Let's walk through how to initialize the database in MySQL

Review Comment:
   changed, please recheck, thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org