You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "DavisVaughan (via GitHub)" <gi...@apache.org> on 2026/01/06 03:02:07 UTC
[PR] Remove old `add =` tests [arrow]
DavisVaughan opened a new pull request, #48731:
URL: https://github.com/apache/arrow/pull/48731
Hi there, we are working on dplyr 1.2.0 and your package was flagged in our reverse dependency checks.
The `add` argument to `group_by()` is now defunct. You should use `.add` instead.
It looks like arrow was already doing this, it just had some outdated tests that relied on the old way.
You'll need to update your package to stay on CRAN.
We are still working on dplyr 1.2.0, but you can consider this an (at minimum) 2 week notice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove old `add =` tests [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #48731:
URL: https://github.com/apache/arrow/pull/48731#issuecomment-3712923078
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - Contributing Overview](https://arrow.apache.org/docs/developers/overview.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove old `add =` tests [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane merged PR #48731:
URL: https://github.com/apache/arrow/pull/48731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove old `add =` tests [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #48731:
URL: https://github.com/apache/arrow/pull/48731#issuecomment-3722153360
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 4cc41f43a3e6044a30c0c77af3b157681d1e1770.
There weren't enough matching historic benchmark results to make a call on whether there were regressions.
The [full Conbench report](https://github.com/apache/arrow/runs/59763979273) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove old `add =` tests [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on PR #48731:
URL: https://github.com/apache/arrow/pull/48731#issuecomment-3720040119
This looks good, would you mind also removing `add` from the `group_by` signature as well? It's ok if you don't want to, but would be nice to have it cleaned up all at once IMHO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove old `add =` tests [arrow]
Posted by "DavisVaughan (via GitHub)" <gi...@apache.org>.
DavisVaughan commented on PR #48731:
URL: https://github.com/apache/arrow/pull/48731#issuecomment-3720122725
I just realized I was branched off a 2 year old `main` 😱 , that was the cause of the merge conflict
So I just rebased on current `main` to fix that and also removed `add` from your `group_by()` S3 methods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org