[jira] [Commented] (HBASE-21357) RS should abort if OOM in Reader thread

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-21357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680199#comment-16680199 ] 

Hudson commented on HBASE-21357:
--------------------------------

SUCCESS: Integrated in Jenkins build HBase-1.3-IT #499 (See [https://builds.apache.org/job/HBase-1.3-IT/499/])
HBASE-21357 RS should abort if OOM in Reader thread (apurtell: rev f5495b7c84c4af21b4955fc9ec4eb3dd5c9d5f26)
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java


> RS should abort if OOM in Reader thread
> ---------------------------------------
>
>                 Key: HBASE-21357
>                 URL: https://issues.apache.org/jira/browse/HBASE-21357
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.4.8
>            Reporter: Allan Yang
>            Assignee: Allan Yang
>            Priority: Major
>             Fix For: 1.5.0, 1.3.3, 1.4.9
>
>         Attachments: HBASE-21357.branch-1.001.patch, HBASE-21357.branch-1.001.patch
>
>
> It is a bit strange, we will abort the RS if OOM in Listener thread, Responder thread and in CallRunner thread, only not in Reader thread... 
> We should abort RS if OOM happens in Reader thread, too. If not, the reader thread exists because of OOM, and the selector closes. Later connection select to this reader will be ignored
> {code}
> try {
>               if (key.isValid()) {
>                 if (key.isAcceptable())
>                   doAccept(key);
>               }
>             } catch (IOException ignored) {
>               if (LOG.isTraceEnabled()) LOG.trace("ignored", ignored);
>             }
> {code}
> Leaving the client (or Master and other RS)'s call wait until SocketTimeout.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)