[jira] [Resolved] (CALCITE-5340) Tests should fail when actual and expected XML reference files are not identical

["Alessandro Solimando (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CALCITE-5340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alessandro Solimando resolved CALCITE-5340.
-------------------------------------------
    Resolution: Fixed

Fixed via [{{f0c6cd5}}|https://github.com/apache/calcite/commit/f0c6cd5a52cfd954dd89fe7a2a422fe6e60ed28e], thanks a lot [~libenchao] for the review!

> Tests should fail when actual and expected XML reference files are not identical
> --------------------------------------------------------------------------------
>
>                 Key: CALCITE-5340
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5340
>             Project: Calcite
>          Issue Type: Bug
>          Components: build, tests
>    Affects Versions: 1.32.0
>            Reporter: Alessandro Solimando
>            Assignee: Alessandro Solimando
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Calcite has several XML reference files for tests.
> When a new test is added, those files should be updated by copying the new, automatically-generated, version.
> Sometimes the files are updated manually, and differ from the automatic generation, which makes it harder for the next developer to rely on automatic generation.
> Following the [discussion|https://lists.apache.org/thread/m567vhcmxyt7thprbs22botpnvjg98mj] in the ML, it is desirable to have tests failing upon discrepancies.
> This ticket aims at tracking the effort towards this goal.
> _DiffRepository_ class is responsible for diffing, so it's the first candidate to consider for adding such a check.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)