[GitHub] [ignite-3] PakhomovAlexander commented on a diff in pull request #2151: IGNITE-19518 Validate unit after node restart

["PakhomovAlexander (via GitHub)" <gi...@apache.org>]

PakhomovAlexander commented on code in PR #2151:
URL: https://github.com/apache/ignite-3/pull/2151#discussion_r1224101496


##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/ClusterPerTestIntegrationTest.java:
##########
@@ -135,6 +135,10 @@ protected int initialNodes() {
         return 3;
     }
 
+    protected int[] cmgMetastoreNodes() {

Review Comment:
   ```suggestion
       protected int[] cmgNodes() {
   ```



##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/Cluster.java:
##########
@@ -119,35 +120,59 @@ public Cluster(TestInfo testInfo, Path workDir, String defaultNodeBootstrapConfi
         this.defaultNodeBootstrapConfigTemplate = defaultNodeBootstrapConfigTemplate;
     }
 
+    public void startAndInit(int nodeCount) {
+        startAndInit(nodeCount, new int[] { 0 });
+    }
+
     /**
      * Starts the cluster with the given number of nodes and initializes it.
      *
      * @param nodeCount Number of nodes in the cluster.
+     * @param cmgNodes Indices of CMG nodes.
      */
-    public void startAndInit(int nodeCount) {
-        startAndInit(nodeCount, builder -> {});
+    public void startAndInit(int nodeCount, int[] cmgNodes) {
+        startAndInit(nodeCount, cmgNodes, builder -> {});
     }
 
     /**
      * Starts the cluster with the given number of nodes and initializes it.
      *
      * @param nodeCount Number of nodes in the cluster.
+     * @param cmgNodes Indices of CMG nodes.
      * @param initParametersConfigurator Configure {@link InitParameters} before initializing the cluster.
      */
-    public void startAndInit(int nodeCount, Consumer<InitParametersBuilder> initParametersConfigurator) {
-        startAndInit(nodeCount, defaultNodeBootstrapConfigTemplate, initParametersConfigurator);
+    public void startAndInit(int nodeCount, int[] cmgNodes, Consumer<InitParametersBuilder> initParametersConfigurator) {
+        startAndInit(nodeCount, cmgNodes, defaultNodeBootstrapConfigTemplate, initParametersConfigurator);
+    }
+
+    /**
+     * Starts the cluster with the given number of nodes and initializes it.

Review Comment:
   Could you mention that the first node will represent a CMG?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org