[GitHub] [cassandra-accord] belliottsmith commented on a diff in pull request #28: CASSANDRA-18203: CEP-15: (C*) Improve Burn Tests to include thread scheduling

["belliottsmith (via GitHub)" <gi...@apache.org>]

belliottsmith commented on code in PR #28:
URL: https://github.com/apache/cassandra-accord/pull/28#discussion_r1096030158


##########
accord-core/src/test/java/accord/impl/basic/DelayedExecutorService.java:
##########
@@ -0,0 +1,107 @@
+package accord.impl.basic;
+
+import accord.burn.random.Decision;
+import accord.burn.random.IntRange;
+import accord.burn.random.RandomInt;
+import accord.burn.random.SegmentedIntRange;
+import org.apache.cassandra.concurrent.FutureTask;
+
+import java.util.Collections;
+import java.util.List;
+import java.util.Random;
+import java.util.concurrent.AbstractExecutorService;
+import java.util.concurrent.Callable;
+import java.util.concurrent.Executors;
+import java.util.concurrent.TimeUnit;
+
+public class DelayedExecutorService extends AbstractExecutorService
+{
+    private final PendingQueue pending;
+    private final Random random;
+    private final RandomInt jitterInNano;
+
+    public DelayedExecutorService(PendingQueue pending, Random random)
+    {
+        this.pending = pending;
+        this.random = random;
+        this.jitterInNano = new SegmentedIntRange(
+                new IntRange(microToNanos(0), microToNanos(50)),
+                new IntRange(microToNanos(50), msToNanos(5)),
+                // this is different from Apache Cassandra Simulator as this is computed differently for each executor

Review Comment:
   Here's my attempt: https://github.com/belliottsmith/cassandra-accord/tree/18203-suggest
   
   This looks to produce some interesting patterns by switching between large and small ranges with some chance, and the length of a large/small period is used to determine how likely we are to switch. It appears to produce a correct distribution over a long enough sample period while still giving very lengthy periods of high jitter.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org