You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/09/15 03:39:20 UTC

[GitHub] [hudi] boundarymate commented on a diff in pull request #3951: [HUDI-2715] The BitCaskDiskMap iterator may cause memory leak

boundarymate commented on code in PR #3951:
URL: https://github.com/apache/hudi/pull/3951#discussion_r971492356


##########
hudi-common/src/main/java/org/apache/hudi/common/util/collection/BitCaskDiskMap.java:
##########
@@ -275,6 +282,7 @@ public void close() {
         }
       }
       writeOnlyFile.delete();
+      this.iterators.forEach(ClosableIterator::close);

Review Comment:
   Hi danny
   Why not close in finally?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org