You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@karaf.apache.org by "Andrei Pozolotin (Created) (JIRA)" <ji...@apache.org> on 2011/11/30 17:47:40 UTC
[jira] [Created] (KARAF-1066) make features xml parser more
forgiving
make features xml parser more forgiving
---------------------------------------
Key: KARAF-1066
URL: https://issues.apache.org/jira/browse/KARAF-1066
Project: Karaf
Issue Type: Bug
Components: karaf-tooling
Reporter: Andrei Pozolotin
features-maven-plugin:2.2.4:add-features-to-repo
1) currently, an entry in features.xml like this works fine:
<repository>mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features</repository>
2) but plugin blows up with exception, if format is like this
<repository>
mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features
</repository>
"Error populating repository: Illegal character in scheme name at index 0:"
3) I suggest to make features xml parser more forgiving
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (KARAF-1066) make features xml parser more
forgiving
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Freeman Fang resolved KARAF-1066.
---------------------------------
Resolution: Fixed
Fix Version/s: 3.0.0
2.3.0
2.2.9
commit fix
http://svn.apache.org/viewvc?rev=1372747&view=rev for trunk
http://svn.apache.org/viewvc?rev=1372749&view=rev for 2.3.x branch
http://svn.apache.org/viewvc?rev=1372748&view=rev for 2.2.x branch
> make features xml parser more forgiving
> ---------------------------------------
>
> Key: KARAF-1066
> URL: https://issues.apache.org/jira/browse/KARAF-1066
> Project: Karaf
> Issue Type: Bug
> Components: karaf-tooling
> Reporter: Andrei Pozolotin
> Assignee: Freeman Fang
> Fix For: 2.2.9, 2.3.0, 3.0.0
>
> Attachments: karaf-3.0_1066.diff
>
>
> features-maven-plugin:2.2.4:add-features-to-repo
> 1) currently, an entry in features.xml like this works fine:
> <repository>mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features</repository>
> 2) but plugin blows up with exception, if format is like this
> <repository>
> mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features
> </repository>
> "Error populating repository: Illegal character in scheme name at index 0:"
> 3) I suggest to make features xml parser more forgiving
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (KARAF-1066) make features xml parser more
forgiving
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on KARAF-1066 started by Freeman Fang.
> make features xml parser more forgiving
> ---------------------------------------
>
> Key: KARAF-1066
> URL: https://issues.apache.org/jira/browse/KARAF-1066
> Project: Karaf
> Issue Type: Bug
> Components: karaf-tooling
> Reporter: Andrei Pozolotin
> Assignee: Freeman Fang
> Attachments: karaf-3.0_1066.diff
>
>
> features-maven-plugin:2.2.4:add-features-to-repo
> 1) currently, an entry in features.xml like this works fine:
> <repository>mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features</repository>
> 2) but plugin blows up with exception, if format is like this
> <repository>
> mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features
> </repository>
> "Error populating repository: Illegal character in scheme name at index 0:"
> 3) I suggest to make features xml parser more forgiving
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-1066) make features xml parser more
forgiving
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13437631#comment-13437631 ]
Freeman Fang commented on KARAF-1066:
-------------------------------------
apply patch which add AddFeaturesToRepoMojoTest on behalf of Heath Kesler with thanks
http://svn.apache.org/viewvc?rev=1374896&view=rev for 2.3.x branch
http://svn.apache.org/viewvc?rev=1374897&view=rev for 2.2.x branch
> make features xml parser more forgiving
> ---------------------------------------
>
> Key: KARAF-1066
> URL: https://issues.apache.org/jira/browse/KARAF-1066
> Project: Karaf
> Issue Type: Bug
> Components: karaf-tooling
> Reporter: Andrei Pozolotin
> Assignee: Freeman Fang
> Fix For: 2.2.9, 2.3.0, 3.0.0
>
> Attachments: karaf-2.3_1066_test.diff, karaf-3.0_1066.diff, karaf-3.0_1066_test.diff, karaf-3.0_1066_test_failure.diff
>
>
> features-maven-plugin:2.2.4:add-features-to-repo
> 1) currently, an entry in features.xml like this works fine:
> <repository>mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features</repository>
> 2) but plugin blows up with exception, if format is like this
> <repository>
> mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features
> </repository>
> "Error populating repository: Illegal character in scheme name at index 0:"
> 3) I suggest to make features xml parser more forgiving
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-1066) make features xml parser more
forgiving
Posted by "Andreas Pieber (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160190#comment-13160190 ]
Andreas Pieber commented on KARAF-1066:
---------------------------------------
also +1
> make features xml parser more forgiving
> ---------------------------------------
>
> Key: KARAF-1066
> URL: https://issues.apache.org/jira/browse/KARAF-1066
> Project: Karaf
> Issue Type: Bug
> Components: karaf-tooling
> Reporter: Andrei Pozolotin
>
> features-maven-plugin:2.2.4:add-features-to-repo
> 1) currently, an entry in features.xml like this works fine:
> <repository>mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features</repository>
> 2) but plugin blows up with exception, if format is like this
> <repository>
> mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features
> </repository>
> "Error populating repository: Illegal character in scheme name at index 0:"
> 3) I suggest to make features xml parser more forgiving
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-1066) make features xml parser more
forgiving
Posted by "Heath Kesler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434206#comment-13434206 ]
Heath Kesler commented on KARAF-1066:
-------------------------------------
I did test the trim() against a test I have for the RepositoryImpl class and it fails when there is a space in the URI, should I open a different jira for that or just continue to track it here?
Thanks for helping me on this.
I will add the test that fails to this jira so you can verify it.
> make features xml parser more forgiving
> ---------------------------------------
>
> Key: KARAF-1066
> URL: https://issues.apache.org/jira/browse/KARAF-1066
> Project: Karaf
> Issue Type: Bug
> Components: karaf-tooling
> Reporter: Andrei Pozolotin
> Assignee: Freeman Fang
> Fix For: 2.2.9, 2.3.0, 3.0.0
>
> Attachments: karaf-3.0_1066.diff, karaf-3.0_1066_test.diff
>
>
> features-maven-plugin:2.2.4:add-features-to-repo
> 1) currently, an entry in features.xml like this works fine:
> <repository>mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features</repository>
> 2) but plugin blows up with exception, if format is like this
> <repository>
> mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features
> </repository>
> "Error populating repository: Illegal character in scheme name at index 0:"
> 3) I suggest to make features xml parser more forgiving
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-1066) make features xml parser more
forgiving
Posted by "Jean-Baptiste Onofré (Commented JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160181#comment-13160181 ]
Jean-Baptiste Onofré commented on KARAF-1066:
---------------------------------------------
Agree with that ;)
> make features xml parser more forgiving
> ---------------------------------------
>
> Key: KARAF-1066
> URL: https://issues.apache.org/jira/browse/KARAF-1066
> Project: Karaf
> Issue Type: Bug
> Components: karaf-tooling
> Reporter: Andrei Pozolotin
>
> features-maven-plugin:2.2.4:add-features-to-repo
> 1) currently, an entry in features.xml like this works fine:
> <repository>mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features</repository>
> 2) but plugin blows up with exception, if format is like this
> <repository>
> mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features
> </repository>
> "Error populating repository: Illegal character in scheme name at index 0:"
> 3) I suggest to make features xml parser more forgiving
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (KARAF-1066) make features xml parser more
forgiving
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Freeman Fang reassigned KARAF-1066:
-----------------------------------
Assignee: Freeman Fang
> make features xml parser more forgiving
> ---------------------------------------
>
> Key: KARAF-1066
> URL: https://issues.apache.org/jira/browse/KARAF-1066
> Project: Karaf
> Issue Type: Bug
> Components: karaf-tooling
> Reporter: Andrei Pozolotin
> Assignee: Freeman Fang
> Attachments: karaf-3.0_1066.diff
>
>
> features-maven-plugin:2.2.4:add-features-to-repo
> 1) currently, an entry in features.xml like this works fine:
> <repository>mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features</repository>
> 2) but plugin blows up with exception, if format is like this
> <repository>
> mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features
> </repository>
> "Error populating repository: Illegal character in scheme name at index 0:"
> 3) I suggest to make features xml parser more forgiving
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-1066) make features xml parser more
forgiving
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433933#comment-13433933 ]
Freeman Fang commented on KARAF-1066:
-------------------------------------
Hi Heath,
Thanks for this patch
I think in the RepositoryImpl.java, simply using
uri = uri.trim();
is better than
uri = uri.replaceAll("\\s", "");
from your patch. As String.trim() can trim whitespace, \t\r\n from the string, but won't remove any whitespace in the middle of the string, so it avoid the potential risk if URI have whitespace.
Moreover, you patch is valuable when parse the features.xml during runtime, but this issue is mainly about the features-maven-plugin:add-features-to-repo have issues, so your patch doesn't really fix it, we should fix it in some where like AddToRepositoryMojo.java.
I'll take care of it and fix it soon.
Best Regards
Freeman
> make features xml parser more forgiving
> ---------------------------------------
>
> Key: KARAF-1066
> URL: https://issues.apache.org/jira/browse/KARAF-1066
> Project: Karaf
> Issue Type: Bug
> Components: karaf-tooling
> Reporter: Andrei Pozolotin
> Assignee: Freeman Fang
> Attachments: karaf-3.0_1066.diff
>
>
> features-maven-plugin:2.2.4:add-features-to-repo
> 1) currently, an entry in features.xml like this works fine:
> <repository>mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features</repository>
> 2) but plugin blows up with exception, if format is like this
> <repository>
> mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features
> </repository>
> "Error populating repository: Illegal character in scheme name at index 0:"
> 3) I suggest to make features xml parser more forgiving
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-1066) make features xml parser more
forgiving
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434741#comment-13434741 ]
Freeman Fang commented on KARAF-1066:
-------------------------------------
apply patch which add AddToRepositoryMojoTest on behalf of Heath Kesler with thanks
http://svn.apache.org/viewvc?rev=1373188&view=rev
@Heath,
Do you wanna backport AddToRepositoryMojoTest to Karaf 2.x line?
> make features xml parser more forgiving
> ---------------------------------------
>
> Key: KARAF-1066
> URL: https://issues.apache.org/jira/browse/KARAF-1066
> Project: Karaf
> Issue Type: Bug
> Components: karaf-tooling
> Reporter: Andrei Pozolotin
> Assignee: Freeman Fang
> Fix For: 2.2.9, 2.3.0, 3.0.0
>
> Attachments: karaf-3.0_1066.diff, karaf-3.0_1066_test.diff, karaf-3.0_1066_test_failure.diff
>
>
> features-maven-plugin:2.2.4:add-features-to-repo
> 1) currently, an entry in features.xml like this works fine:
> <repository>mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features</repository>
> 2) but plugin blows up with exception, if format is like this
> <repository>
> mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features
> </repository>
> "Error populating repository: Illegal character in scheme name at index 0:"
> 3) I suggest to make features xml parser more forgiving
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KARAF-1066) make features xml parser more
forgiving
Posted by "Heath Kesler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Heath Kesler updated KARAF-1066:
--------------------------------
Attachment: karaf-3.0_1066_test.diff
Freeman, here is a test to exercise the changes you made for the AddToRepositoryMojo class.
> make features xml parser more forgiving
> ---------------------------------------
>
> Key: KARAF-1066
> URL: https://issues.apache.org/jira/browse/KARAF-1066
> Project: Karaf
> Issue Type: Bug
> Components: karaf-tooling
> Reporter: Andrei Pozolotin
> Assignee: Freeman Fang
> Fix For: 2.2.9, 2.3.0, 3.0.0
>
> Attachments: karaf-3.0_1066.diff, karaf-3.0_1066_test.diff
>
>
> features-maven-plugin:2.2.4:add-features-to-repo
> 1) currently, an entry in features.xml like this works fine:
> <repository>mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features</repository>
> 2) but plugin blows up with exception, if format is like this
> <repository>
> mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features
> </repository>
> "Error populating repository: Illegal character in scheme name at index 0:"
> 3) I suggest to make features xml parser more forgiving
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-1066) make features xml parser more
forgiving
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433935#comment-13433935 ]
Freeman Fang commented on KARAF-1066:
-------------------------------------
apply patch on behalf of Heath Kesler with thanks
http://svn.apache.org/viewvc?rev=1372740&view=rev
> make features xml parser more forgiving
> ---------------------------------------
>
> Key: KARAF-1066
> URL: https://issues.apache.org/jira/browse/KARAF-1066
> Project: Karaf
> Issue Type: Bug
> Components: karaf-tooling
> Reporter: Andrei Pozolotin
> Assignee: Freeman Fang
> Attachments: karaf-3.0_1066.diff
>
>
> features-maven-plugin:2.2.4:add-features-to-repo
> 1) currently, an entry in features.xml like this works fine:
> <repository>mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features</repository>
> 2) but plugin blows up with exception, if format is like this
> <repository>
> mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features
> </repository>
> "Error populating repository: Illegal character in scheme name at index 0:"
> 3) I suggest to make features xml parser more forgiving
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KARAF-1066) make features xml parser more
forgiving
Posted by "Heath Kesler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Heath Kesler updated KARAF-1066:
--------------------------------
Attachment: karaf-3.0_1066_test_failure.diff
Here is the patch that will exercise the test failure when a non-encoded white space is in the uri.
Let me know what you think.
> make features xml parser more forgiving
> ---------------------------------------
>
> Key: KARAF-1066
> URL: https://issues.apache.org/jira/browse/KARAF-1066
> Project: Karaf
> Issue Type: Bug
> Components: karaf-tooling
> Reporter: Andrei Pozolotin
> Assignee: Freeman Fang
> Fix For: 2.2.9, 2.3.0, 3.0.0
>
> Attachments: karaf-3.0_1066.diff, karaf-3.0_1066_test.diff, karaf-3.0_1066_test_failure.diff
>
>
> features-maven-plugin:2.2.4:add-features-to-repo
> 1) currently, an entry in features.xml like this works fine:
> <repository>mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features</repository>
> 2) but plugin blows up with exception, if format is like this
> <repository>
> mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features
> </repository>
> "Error populating repository: Illegal character in scheme name at index 0:"
> 3) I suggest to make features xml parser more forgiving
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-1066) make features xml parser more
forgiving
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434736#comment-13434736 ]
Freeman Fang commented on KARAF-1066:
-------------------------------------
Hi Heath,
First of all, I don't think we should change content of the URI, so if any user has unencoded whitespace inside URI, they should get exception so that they know they do something wrong, just like if users has typo in URI hence can't get files they should know that they do something wrong and they need correct it themselves.
But remove the whitespace \t\r\n from begining or end of the URI is OK, it doesn't change the URI content, it just get a better format URI.
Btw, I like your AddToRepositoryMojoTest, it prove the trim works, and I will apply it to trunk(with minor change, I don't wanna the space inside URI and actually your test not run into URI parse)
Freeman
> make features xml parser more forgiving
> ---------------------------------------
>
> Key: KARAF-1066
> URL: https://issues.apache.org/jira/browse/KARAF-1066
> Project: Karaf
> Issue Type: Bug
> Components: karaf-tooling
> Reporter: Andrei Pozolotin
> Assignee: Freeman Fang
> Fix For: 2.2.9, 2.3.0, 3.0.0
>
> Attachments: karaf-3.0_1066.diff, karaf-3.0_1066_test.diff, karaf-3.0_1066_test_failure.diff
>
>
> features-maven-plugin:2.2.4:add-features-to-repo
> 1) currently, an entry in features.xml like this works fine:
> <repository>mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features</repository>
> 2) but plugin blows up with exception, if format is like this
> <repository>
> mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features
> </repository>
> "Error populating repository: Illegal character in scheme name at index 0:"
> 3) I suggest to make features xml parser more forgiving
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KARAF-1066) make features xml parser more
forgiving
Posted by "Heath Kesler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Heath Kesler updated KARAF-1066:
--------------------------------
Attachment: karaf-2.3_1066_test.diff
Freeman, here is the test for the 2.3 branch
> make features xml parser more forgiving
> ---------------------------------------
>
> Key: KARAF-1066
> URL: https://issues.apache.org/jira/browse/KARAF-1066
> Project: Karaf
> Issue Type: Bug
> Components: karaf-tooling
> Reporter: Andrei Pozolotin
> Assignee: Freeman Fang
> Fix For: 2.2.9, 2.3.0, 3.0.0
>
> Attachments: karaf-2.3_1066_test.diff, karaf-3.0_1066.diff, karaf-3.0_1066_test.diff, karaf-3.0_1066_test_failure.diff
>
>
> features-maven-plugin:2.2.4:add-features-to-repo
> 1) currently, an entry in features.xml like this works fine:
> <repository>mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features</repository>
> 2) but plugin blows up with exception, if format is like this
> <repository>
> mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features
> </repository>
> "Error populating repository: Illegal character in scheme name at index 0:"
> 3) I suggest to make features xml parser more forgiving
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KARAF-1066) make features xml parser more
forgiving
Posted by "Heath Kesler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Heath Kesler updated KARAF-1066:
--------------------------------
Attachment: karaf-3.0_1066.diff
the repo parsing now removes all white space and newline/endline using regexp "\\s".
I don't think we can have URI's with spaces, but I could be wrong.
I implemented a test also that exercised the issue using a repo2.xml file.
> make features xml parser more forgiving
> ---------------------------------------
>
> Key: KARAF-1066
> URL: https://issues.apache.org/jira/browse/KARAF-1066
> Project: Karaf
> Issue Type: Bug
> Components: karaf-tooling
> Reporter: Andrei Pozolotin
> Attachments: karaf-3.0_1066.diff
>
>
> features-maven-plugin:2.2.4:add-features-to-repo
> 1) currently, an entry in features.xml like this works fine:
> <repository>mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features</repository>
> 2) but plugin blows up with exception, if format is like this
> <repository>
> mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features
> </repository>
> "Error populating repository: Illegal character in scheme name at index 0:"
> 3) I suggest to make features xml parser more forgiving
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-1066) make features xml parser more
forgiving
Posted by "Heath Kesler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435019#comment-13435019 ]
Heath Kesler commented on KARAF-1066:
-------------------------------------
Hi Freeman, your comments make sense, thanks for the feedback.
I will backport the test to the karaf 2.x also.
> make features xml parser more forgiving
> ---------------------------------------
>
> Key: KARAF-1066
> URL: https://issues.apache.org/jira/browse/KARAF-1066
> Project: Karaf
> Issue Type: Bug
> Components: karaf-tooling
> Reporter: Andrei Pozolotin
> Assignee: Freeman Fang
> Fix For: 2.2.9, 2.3.0, 3.0.0
>
> Attachments: karaf-3.0_1066.diff, karaf-3.0_1066_test.diff, karaf-3.0_1066_test_failure.diff
>
>
> features-maven-plugin:2.2.4:add-features-to-repo
> 1) currently, an entry in features.xml like this works fine:
> <repository>mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features</repository>
> 2) but plugin blows up with exception, if format is like this
> <repository>
> mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features
> </repository>
> "Error populating repository: Illegal character in scheme name at index 0:"
> 3) I suggest to make features xml parser more forgiving
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-1066) make features xml parser more
forgiving
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433934#comment-13433934 ]
Freeman Fang commented on KARAF-1066:
-------------------------------------
Hi,
I'm going to apply your patch with the change I mentioned firstly and then fix the AddToRepositoryMojo issue.
Freeman
> make features xml parser more forgiving
> ---------------------------------------
>
> Key: KARAF-1066
> URL: https://issues.apache.org/jira/browse/KARAF-1066
> Project: Karaf
> Issue Type: Bug
> Components: karaf-tooling
> Reporter: Andrei Pozolotin
> Assignee: Freeman Fang
> Attachments: karaf-3.0_1066.diff
>
>
> features-maven-plugin:2.2.4:add-features-to-repo
> 1) currently, an entry in features.xml like this works fine:
> <repository>mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features</repository>
> 2) but plugin blows up with exception, if format is like this
> <repository>
> mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features
> </repository>
> "Error populating repository: Illegal character in scheme name at index 0:"
> 3) I suggest to make features xml parser more forgiving
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-1066) make features xml parser more
forgiving
Posted by "Heath Kesler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434138#comment-13434138 ]
Heath Kesler commented on KARAF-1066:
-------------------------------------
@Freeman - thanks for the feedback, I had thought about using trim but was not sure about white spaces in the uri and since the tests passed I left it with the replaceAll.
The test I wrote fails with white spaces in the URI using trim(). I will look at the patch you wrote and see what you did differently.
> make features xml parser more forgiving
> ---------------------------------------
>
> Key: KARAF-1066
> URL: https://issues.apache.org/jira/browse/KARAF-1066
> Project: Karaf
> Issue Type: Bug
> Components: karaf-tooling
> Reporter: Andrei Pozolotin
> Assignee: Freeman Fang
> Fix For: 2.2.9, 2.3.0, 3.0.0
>
> Attachments: karaf-3.0_1066.diff
>
>
> features-maven-plugin:2.2.4:add-features-to-repo
> 1) currently, an entry in features.xml like this works fine:
> <repository>mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features</repository>
> 2) but plugin blows up with exception, if format is like this
> <repository>
> mvn:org.apache.karaf.assemblies.features/standard/2.2.4/xml/features
> </repository>
> "Error populating repository: Illegal character in scheme name at index 0:"
> 3) I suggest to make features xml parser more forgiving
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira