[GitHub] [ozone] JyotinderSingh commented on a diff in pull request #3473: HDDS-6819. Add LEGACY to AllowedBucketLayouts in CreateBucketHandler

[GitBox <gi...@apache.org>]

JyotinderSingh commented on code in PR #3473:
URL: https://github.com/apache/ozone/pull/3473#discussion_r887575650


##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/bucket/CreateBucketHandler.java:
##########
@@ -62,7 +62,7 @@ public class CreateBucketHandler extends BucketHandler {
   enum AllowedBucketLayouts {

Review Comment:
   We can simplify the Enum. The constructor, toString override, and member variable were only required for the case where we wanted to allow an empty string to be passed as a value to the layout option.
   Since now we are disallowing the empty string as a value - we can remove reduce the complexity here.
   ```suggestion
     enum AllowedBucketLayouts { FILE_SYSTEM_OPTIMIZED, OBJECT_STORE, LEGACY }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org