You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Zhitao Li <zh...@gmail.com> on 2017/04/18 18:23:06 UTC
Review Request 58513: Remove unnecessary patch after protobuf upgrade
to 3.2.0.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58513/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar and Joseph Wu.
Bugs: MESOS-7228
https://issues.apache.org/jira/browse/MESOS-7228
Repository: mesos
Description
-------
The patch should already be included in protobuf 3.0.0, so
this is not necessary anymore.
Diffs
-----
3rdparty/protobuf-2.6.1.patch bfd3bb2c600383ef05bdb4ea9df0188b4a560315
Diff: https://reviews.apache.org/r/58513/diff/1/
Testing
-------
Thanks,
Zhitao Li
Re: Review Request 58513: Remove unnecessary patch after protobuf
upgrade to 3.2.0.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58513/#review172314
-----------------------------------------------------------
Ship it!
Ship It!
- Anand Mazumdar
On April 18, 2017, 10:48 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58513/
> -----------------------------------------------------------
>
> (Updated April 18, 2017, 10:48 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Joseph Wu.
>
>
> Bugs: MESOS-7228
> https://issues.apache.org/jira/browse/MESOS-7228
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The patch should already be included in protobuf 3.0.0, so
> this is not necessary anymore.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt bb61ef0514fb164f35b34bb6be1bbebb4d1a1861
> 3rdparty/Makefile.am 61d832b2d83cdeaf95341c062e8493ab72d0724e
> 3rdparty/protobuf-2.6.1.patch bfd3bb2c600383ef05bdb4ea9df0188b4a560315
>
>
> Diff: https://reviews.apache.org/r/58513/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 58513: Remove unnecessary patch after protobuf
upgrade to 3.2.0.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58513/#review175166
-----------------------------------------------------------
Fix it, then Ship it!
Please rebase.
3rdparty/CMakeLists.txt
Line 349 (original), 348 (patched)
<https://reviews.apache.org/r/58513/#comment248557>
This line can be removed as well.
- Chun-Hung Hsiao
On April 18, 2017, 10:48 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58513/
> -----------------------------------------------------------
>
> (Updated April 18, 2017, 10:48 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Joseph Wu.
>
>
> Bugs: MESOS-7228
> https://issues.apache.org/jira/browse/MESOS-7228
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The patch should already be included in protobuf 3.0.0, so
> this is not necessary anymore.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt bb61ef0514fb164f35b34bb6be1bbebb4d1a1861
> 3rdparty/Makefile.am 61d832b2d83cdeaf95341c062e8493ab72d0724e
> 3rdparty/protobuf-2.6.1.patch bfd3bb2c600383ef05bdb4ea9df0188b4a560315
>
>
> Diff: https://reviews.apache.org/r/58513/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 58513: Remove unnecessary patch after protobuf
upgrade to 3.3.0.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58513/
-----------------------------------------------------------
(Updated May 24, 2017, 4:16 p.m.)
Review request for mesos, Anand Mazumdar and Joseph Wu.
Changes
-------
Removed dependency on discarded review.
Bugs: MESOS-7228
https://issues.apache.org/jira/browse/MESOS-7228
Repository: mesos
Description
-------
The patch should already be included in protobuf 3.0.0, so
this is not necessary anymore.
Diffs
-----
3rdparty/CMakeLists.txt cb118f6c454c3bb36990e292a31703e4a3f99483
3rdparty/Makefile.am 61d832b2d83cdeaf95341c062e8493ab72d0724e
3rdparty/protobuf-2.6.1.patch bfd3bb2c600383ef05bdb4ea9df0188b4a560315
Diff: https://reviews.apache.org/r/58513/diff/4/
Testing
-------
Thanks,
Zhitao Li
Re: Review Request 58513: Remove unnecessary patch after protobuf
upgrade to 3.3.0.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58513/
-----------------------------------------------------------
(Updated May 19, 2017, 5:53 p.m.)
Review request for mesos, Anand Mazumdar and Joseph Wu.
Changes
-------
use 3.3.0 instead.
Summary (updated)
-----------------
Remove unnecessary patch after protobuf upgrade to 3.3.0.
Bugs: MESOS-7228
https://issues.apache.org/jira/browse/MESOS-7228
Repository: mesos
Description
-------
The patch should already be included in protobuf 3.0.0, so
this is not necessary anymore.
Diffs (updated)
-----
3rdparty/CMakeLists.txt cb118f6c454c3bb36990e292a31703e4a3f99483
3rdparty/Makefile.am 61d832b2d83cdeaf95341c062e8493ab72d0724e
3rdparty/protobuf-2.6.1.patch bfd3bb2c600383ef05bdb4ea9df0188b4a560315
Diff: https://reviews.apache.org/r/58513/diff/4/
Changes: https://reviews.apache.org/r/58513/diff/3-4/
Testing
-------
Thanks,
Zhitao Li
Re: Review Request 58513: Remove unnecessary patch after protobuf
upgrade to 3.2.0.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58513/
-----------------------------------------------------------
(Updated May 17, 2017, 3:46 a.m.)
Review request for mesos, Anand Mazumdar and Joseph Wu.
Changes
-------
rebase.
Bugs: MESOS-7228
https://issues.apache.org/jira/browse/MESOS-7228
Repository: mesos
Description
-------
The patch should already be included in protobuf 3.0.0, so
this is not necessary anymore.
Diffs (updated)
-----
3rdparty/CMakeLists.txt cb118f6c454c3bb36990e292a31703e4a3f99483
3rdparty/Makefile.am 61d832b2d83cdeaf95341c062e8493ab72d0724e
3rdparty/protobuf-2.6.1.patch bfd3bb2c600383ef05bdb4ea9df0188b4a560315
Diff: https://reviews.apache.org/r/58513/diff/3/
Changes: https://reviews.apache.org/r/58513/diff/2-3/
Testing
-------
Thanks,
Zhitao Li
Re: Review Request 58513: Remove unnecessary patch after protobuf
upgrade to 3.2.0.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58513/
-----------------------------------------------------------
(Updated April 18, 2017, 10:48 p.m.)
Review request for mesos, Anand Mazumdar and Joseph Wu.
Changes
-------
Remove patch commands in make file.
Bugs: MESOS-7228
https://issues.apache.org/jira/browse/MESOS-7228
Repository: mesos
Description
-------
The patch should already be included in protobuf 3.0.0, so
this is not necessary anymore.
Diffs (updated)
-----
3rdparty/CMakeLists.txt bb61ef0514fb164f35b34bb6be1bbebb4d1a1861
3rdparty/Makefile.am 61d832b2d83cdeaf95341c062e8493ab72d0724e
3rdparty/protobuf-2.6.1.patch bfd3bb2c600383ef05bdb4ea9df0188b4a560315
Diff: https://reviews.apache.org/r/58513/diff/2/
Changes: https://reviews.apache.org/r/58513/diff/1-2/
Testing
-------
Thanks,
Zhitao Li