You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@juddi.apache.org by "Geir Magnusson Jr (JIRA)" <ju...@ws.apache.org> on 2005/02/13 02:33:12 UTC
[jira] Created: (JUDDI-54) When updating a business w/ a service, existing service key gets recreated
When updating a business w/ a service, existing service key gets recreated
--------------------------------------------------------------------------
Key: JUDDI-54
URL: http://issues.apache.org/jira/browse/JUDDI-54
Project: jUDDI
Type: Bug
Components: Apache Scout Requests
Reporter: Geir Magnusson Jr
Assigned to: Steve Viens
If you have an exiting business (Organization in JAXR parlance) that has a service, and you make an update to that business using save_business, any service key gets overwritten with a new one.
The fix seems to be :
Index: JDBCDataStore.java
===================================================================
RCS file: /home/cvspublic/ws-juddi/src/java/org/apache/juddi/datastore/jdbc/JDBCDataStore.java,v
retrieving revision 1.9
diff -r1.9 JDBCDataStore.java
460a461,467
>
> String serviceKey = service.getServiceKey();
>
> if ((serviceKey == null) || (serviceKey.length() == 0)) {
> service.setServiceKey(uuidgen.uuidgen());
> }
>
462d468
< service.setServiceKey(uuidgen.uuidgen());
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Resolved: (JUDDI-54) When updating a business w/ a service, existing service key gets recreated
Posted by "Steve Viens (JIRA)" <ju...@ws.apache.org>.
[ http://issues.apache.org/jira/browse/JUDDI-54?page=history ]
Steve Viens resolved JUDDI-54:
------------------------------
Resolution: Fixed
This was also an issue for bindingKeys when saving a Service (via saveService). The fix has been applied in both places.
The recommended fix has been applied.
> When updating a business w/ a service, existing service key gets recreated
> --------------------------------------------------------------------------
>
> Key: JUDDI-54
> URL: http://issues.apache.org/jira/browse/JUDDI-54
> Project: jUDDI
> Type: Bug
> Components: Apache Scout Requests
> Reporter: Geir Magnusson Jr
> Assignee: Steve Viens
>
> If you have an exiting business (Organization in JAXR parlance) that has a service, and you make an update to that business using save_business, any service key gets overwritten with a new one.
> The fix seems to be :
> Index: JDBCDataStore.java
> ===================================================================
> RCS file: /home/cvspublic/ws-juddi/src/java/org/apache/juddi/datastore/jdbc/JDBCDataStore.java,v
> retrieving revision 1.9
> diff -r1.9 JDBCDataStore.java
> 460a461,467
> >
> > String serviceKey = service.getServiceKey();
> >
> > if ((serviceKey == null) || (serviceKey.length() == 0)) {
> > service.setServiceKey(uuidgen.uuidgen());
> > }
> >
> 462d468
> < service.setServiceKey(uuidgen.uuidgen());
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
Re: [jira] Created: (JUDDI-54) When updating a business w/ a service, existing service key gets recreated
Posted by Geir Magnusson Jr <ge...@4quarters.com>.
On Feb 13, 2005, at 11:18 AM, Steve Viens wrote:
> Geir,
>
> Good catch. It occurred to me that this may have also been a problem
> with bindingKeys in the saveService method of JDBCDataStore and it was.
> I've applied the recommended fix to both the saveBusiness and
> saveService methods.
Yes, I was going to hunt down the rest of the places, but wanted to be
sure that there wasn't some restriction in UDDI that said that
'subordinate' entities had to refresh keys, or -ish. That wouldn't
make sense to me, as you wouldn't want to change that value while some
client knew about it... But I wanted to be sure.
>
> I've marked the issue as 'resolved' in JIRA. If you have a moment to
> confirm that the fix is working as you expect it to please let me know
> and I'll 'close' it.
Sure. Will do
geir
>
> Thanks.
>
> Steve
>
> -----Original Message-----
> From: Geir Magnusson Jr (JIRA) [mailto:juddi-dev@ws.apache.org]
> Sent: Saturday, February 12, 2005 8:33 PM
> To: juddi-dev@ws.apache.org
> Subject: [jira] Created: (JUDDI-54) When updating a business w/ a
> service, existing service key gets recreated
>
>
> When updating a business w/ a service, existing service key gets
> recreated
> -----------------------------------------------------------------------
> -
> --
>
> Key: JUDDI-54
> URL: http://issues.apache.org/jira/browse/JUDDI-54
> Project: jUDDI
> Type: Bug
> Components: Apache Scout Requests
> Reporter: Geir Magnusson Jr
> Assigned to: Steve Viens
>
>
> If you have an exiting business (Organization in JAXR parlance) that
> has
> a service, and you make an update to that business using save_business,
> any service key gets overwritten with a new one.
>
> The fix seems to be :
>
> Index: JDBCDataStore.java
> ===================================================================
> RCS file:
> /home/cvspublic/ws-juddi/src/java/org/apache/juddi/datastore/jdbc/
> JDBCDa
> taStore.java,v
> retrieving revision 1.9
> diff -r1.9 JDBCDataStore.java
> 460a461,467
>>
>> String serviceKey = service.getServiceKey();
>>
>> if ((serviceKey == null) || (serviceKey.length() == 0)) {
>> service.setServiceKey(uuidgen.uuidgen());
>> }
>>
> 462d468
> < service.setServiceKey(uuidgen.uuidgen());
>
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
> http://issues.apache.org/jira/secure/Administrators.jspa
> -
> If you want more information on JIRA, or have a bug to report see:
> http://www.atlassian.com/software/jira
>
>
>
>
--
Geir Magnusson Jr +1-203-665-6437
geir@gluecode.com
RE: [jira] Created: (JUDDI-54) When updating a business w/ a service, existing service key gets recreated
Posted by Steve Viens <st...@viens.net>.
Geir,
Good catch. It occurred to me that this may have also been a problem
with bindingKeys in the saveService method of JDBCDataStore and it was.
I've applied the recommended fix to both the saveBusiness and
saveService methods.
I've marked the issue as 'resolved' in JIRA. If you have a moment to
confirm that the fix is working as you expect it to please let me know
and I'll 'close' it.
Thanks.
Steve
-----Original Message-----
From: Geir Magnusson Jr (JIRA) [mailto:juddi-dev@ws.apache.org]
Sent: Saturday, February 12, 2005 8:33 PM
To: juddi-dev@ws.apache.org
Subject: [jira] Created: (JUDDI-54) When updating a business w/ a
service, existing service key gets recreated
When updating a business w/ a service, existing service key gets
recreated
------------------------------------------------------------------------
--
Key: JUDDI-54
URL: http://issues.apache.org/jira/browse/JUDDI-54
Project: jUDDI
Type: Bug
Components: Apache Scout Requests
Reporter: Geir Magnusson Jr
Assigned to: Steve Viens
If you have an exiting business (Organization in JAXR parlance) that has
a service, and you make an update to that business using save_business,
any service key gets overwritten with a new one.
The fix seems to be :
Index: JDBCDataStore.java
===================================================================
RCS file:
/home/cvspublic/ws-juddi/src/java/org/apache/juddi/datastore/jdbc/JDBCDa
taStore.java,v
retrieving revision 1.9
diff -r1.9 JDBCDataStore.java
460a461,467
>
> String serviceKey = service.getServiceKey();
>
> if ((serviceKey == null) || (serviceKey.length() == 0)) {
> service.setServiceKey(uuidgen.uuidgen());
> }
>
462d468
< service.setServiceKey(uuidgen.uuidgen());
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Closed: (JUDDI-54) When updating a business w/ a service, existing service key gets recreated
Posted by "Steve Viens (JIRA)" <ju...@ws.apache.org>.
[ http://issues.apache.org/jira/browse/JUDDI-54?page=history ]
Steve Viens closed JUDDI-54:
----------------------------
Fixed - applied patch provided by Gier. When saving a Business or Service. New ServiceKey and BindingKey values were were being generated and used when they should not have been. These values should only be generated when saving new Services or Bindings.
> When updating a business w/ a service, existing service key gets recreated
> --------------------------------------------------------------------------
>
> Key: JUDDI-54
> URL: http://issues.apache.org/jira/browse/JUDDI-54
> Project: jUDDI
> Type: Bug
> Components: Apache Scout Requests
> Reporter: Geir Magnusson Jr
> Assignee: Steve Viens
>
> If you have an exiting business (Organization in JAXR parlance) that has a service, and you make an update to that business using save_business, any service key gets overwritten with a new one.
> The fix seems to be :
> Index: JDBCDataStore.java
> ===================================================================
> RCS file: /home/cvspublic/ws-juddi/src/java/org/apache/juddi/datastore/jdbc/JDBCDataStore.java,v
> retrieving revision 1.9
> diff -r1.9 JDBCDataStore.java
> 460a461,467
> >
> > String serviceKey = service.getServiceKey();
> >
> > if ((serviceKey == null) || (serviceKey.length() == 0)) {
> > service.setServiceKey(uuidgen.uuidgen());
> > }
> >
> 462d468
> < service.setServiceKey(uuidgen.uuidgen());
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira