Re: [INFO] End of the Google Summer of Code 2015

[Ramesh Reddy <ra...@redhat.com>]

If not present we should throw an serialization error rather than computing one for the user. We need to enforce the basic contract that user need to follow when building an entity. I can take look again once you have finished the changes.

Ramesh..

----- Original Message -----
> Hi Ramesh,
> Thanks for your valuable feedback, I have wrote the code so that if
> entity.getId() is present it will give the priority and Serializer will not
> handle by it self. But if it is not needed we can remove those, I more than
> happy to make those changes.
> Regards
> Kevin
> 
> On Fri, Aug 28, 2015 at 9:12 PM, Ramesh Reddy <ra...@redhat.com> wrote:
> 
> > Thanks Christian.
> >
> > I got loaded in the IDE, yes the pattern with which this being done is
> > wrong. "Serializer" should NOT know or make any decisions as to what is an
> > entity id, read link, write link etc. Serializer responsibility should be
> > just providing the services serialization. Now, that responsibility falls
> > on the "entity" object. That means, it is the responsibility of the
> > developer to build those entities with right information on them. That is
> > the reason you might have noticed, during the XML serialization I changed
> > the Tech service data to be more complete. As library developers we can
> > provide the utilities like in the "JsonEntityMetadataBuilder" but not force
> > in using them.
> >
> > yes, this needs to be reworked little bit, which is not much IMO. Just use
> > "entity.getId()" and build the right annotations. The user who is building
> > the entity will have all the details to build an id.
> >
> > HTH.
> >
> > Ramesh..
> >
> > ----- Original Message -----
> > > Hi Ramesh,
> > >
> > > sorry I forgot that. The branch is called "OLINGO-567" just like the
> > issue.
> > > You can find it in git web here:
> > >
> > https://git-wip-us.apache.org/repos/asf?p=olingo-odata4.git;a=shortlog;h=refs/heads/OLINGO-567
> > >
> > > This utility class is used to construct the metadata full information
> > which
> > > is serialized into the payload. So for example to create the entity id
> > > string which can then be found under the @odata.id annotation the method
> > > "getEntityIDValue" is used. Basically it is a helper to construct the
> > > annotation value strings.
> > >
> > > Maybe as a clarification. When I am talking about annotations I mean the
> > > odata predefined payload annotations. The specification part can be found
> > > here:
> > >
> > http://docs.oasis-open.org/odata/odata-json-format/v4.0/errata02/os/odata-json-format-v4.0-errata02-os-complete.html#_Toc403940614
> > > I am not talking about vocabulary based annotations.
> > >
> > > Btw if there would be an integrated way to use github as a host for our
> > git
> > > repository while still being an Apache project I would go for that as
> > well
> > > :)
> > >
> > > Best Regards,
> > > Christian
> > >
> > > -----Original Message-----
> > > From: Ramesh Reddy [mailto:rareddy@redhat.com]
> > > Sent: Mittwoch, 26. August 2015 17:14
> > > To: dev@olingo.apache.org
> > > Subject: Re: [INFO] End of the Google Summer of Code 2015
> > >
> > > What branch this is in? I would like to download the code into IDE. That
> > > looked like tag, sorry I got spoiled with GITHUB. I need to see where
> > this
> > > is being used, and what is importance of this utility class?
> > >
> > > ----- Original Message -----
> > > > Hi Ramesh,
> > > >
> > > > Here is the code. I am talking about line 63 for example:
> > > >
> > https://git-wip-us.apache.org/repos/asf?p=olingo-odata4.git;a=blob;f=lib/server-core/src/main/java/org/apache/olingo/server/core/serializer/utils/JsonEntityMetadataBuilder.java;h=c6d1814363177a52348bcebfc522f9067811fb0e;hb=949dc2125a693c662b0d40a724a8a123451e8aca
> > > >
> > > > Quote:   "EdmEntitySet edmEntitySet =
> > > >
> > edm.getEntityContainer().getEntitySet(contextURL.getEntitySetOrSingletonOrType());"
> > > >
> > > > Best Regards,
> > > > Christian
> > > >
> > > > -----Original Message-----
> > > > From: Ramesh Reddy [mailto:rareddy@redhat.com]
> > > > Sent: Mittwoch, 26. August 2015 15:26
> > > > To: dev@olingo.apache.org
> > > > Subject: Re: [INFO] End of the Google Summer of Code 2015
> > > >
> > > > Christian,
> > > >
> > > > I am not sure I follow the context of the issue, can you point me to
> > the
> > > > code? I am not sure where the annotations are coming into picture on
> > the
> > > > server side.
> > > >
> > > > Thanks
> > > >
> > > > Ramesh..
> > > >
> > > > ----- Original Message -----
> > > > > Hi Ramesh,
> > > > >
> > > > > I am still looking into the merge. There was some parts of the code
> > which
> > > > > I
> > > > > wanted to discuss on the mailinglist before merging it into the
> > master.
> > > > > So
> > > > > I
> > > > > don`t know if it will make it into the first release.
> > > > >
> > > > > My main concern with the code was that the first part of the context
> > URL
> > > > > String is used to resolve the EntitySet which is needed for some
> > OData
> > > > > Annotations. On one hand this is nice because we do not have to
> > change
> > > > > the
> > > > > API between minimal and full. On the other hand it is not clear to a
> > user
> > > > > where and how we extract the EntitySet information. WDYT? How did you
> > > > > solve
> > > > > this within the XMLSerializer where you needed the EntitySet
> > information?
> > > > >
> > > > > Best Regards,
> > > > > Christian
> > > > >
> > > > > -----Original Message-----
> > > > > From: Ramesh Reddy [mailto:rareddy@redhat.com]
> > > > > Sent: Dienstag, 25. August 2015 17:08
> > > > > To: dev@olingo.apache.org
> > > > > Subject: Re: [INFO] End of the Google Summer of Code 2015
> > > > >
> > > > > Great job Kevin and Christian.
> > > > >
> > > > > Is there a possibility to get the "odata.metadata=full" format
> > support
> > > > > merged
> > > > > into the master now as this is fully defined already in V4 spec?
> > > > >
> > > > > Thanks
> > > > >
> > > > > Ramesh..
> > > > >
> > > > > ----- Original Message -----
> > > > > > Hi all,
> > > > > >
> > > > > > The Google Summer of Code 2015 is coming to an end. Since March
> > this
> > > > > > year
> > > > > > Kevin Ratnasekera has been working for Apache Olingo as part of the
> > > > > > GSoC.
> > > > > > As
> > > > > > a result we have odata.metadata=full format support for responses
> > and a
> > > > > > first implementation for the json metadata document format. Once
> > the
> > > > > > OData
> > > > > > V4 specification which contains this format definition is released
> > we
> > > > > > will
> > > > > > be able to merge this code into the master branch.
> > > > > >
> > > > > > I would like to take this opportunity to thank Kevin a lot for his
> > > > > > engagement
> > > > > > during this time and I think he did a great job!
> > > > > >
> > > > > > The Json Metadata Document Implementation can be found here:
> > > > > >
> > https://git-wip-us.apache.org/repos/asf?p=olingo-odata4.git;a=shortlog;h=refs/heads/jsonMetadata
> > > > > >
> > > > > > Best Regards,
> > > > > > Christian
> > > > > >
> > > > >
> > > >
> > >
> >
>