You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2022/04/28 09:10:41 UTC

[GitHub] [thrift] ctubbsii commented on a diff in pull request #2592: THRIFT-5564: setup compiler-building github action

ctubbsii commented on code in PR #2592:
URL: https://github.com/apache/thrift/pull/2592#discussion_r860658773


##########
.github/workflows/build_compiler.yml:
##########
@@ -0,0 +1,43 @@
+name: Build-Thrift-Compiler
+on: [push]

Review Comment:
   This should build for PRs, too.
   
   ```suggestion
   on:
     push:
       branches: [ '*' ]
     pull_request:
       branches: [ '*' ]
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org