[GitHub] markusthoemmes commented on a change in pull request #4078: Add ability to not store activations for specified namespace.

[GitBox <gi...@apache.org>]

markusthoemmes commented on a change in pull request #4078: Add ability to not store activations for specified namespace.
URL: https://github.com/apache/incubator-openwhisk/pull/4078#discussion_r228044796
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/core/database/ArtifactActivationStore.scala
 ##########
 @@ -40,9 +40,16 @@ class ArtifactActivationStore(actorSystem: ActorSystem, actorMaterializer: Actor
     implicit transid: TransactionId,
     notifier: Option[CacheChangeNotification]): Future[DocInfo] = {
 
-    logging.debug(this, s"recording activation '${activation.activationId}'")
-
-    val res = WhiskActivation.put(artifactStore, activation)
+    val skipStoring = context.user.limits.disableActivationStore.getOrElse(false)
 
 Review comment:
   It indeed should be done at source. The option says `disableActivationStore`, so we should in theory circumvent the ActivationStore call as a whole.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services