You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iotdb.apache.org by ro...@apache.org on 2023/07/31 06:39:01 UTC
[iotdb] 01/01: Disable some pipe extractor's features due to unstability
This is an automated email from the ASF dual-hosted git repository.
rong pushed a commit to branch disable-unstable-pipe
in repository https://gitbox.apache.org/repos/asf/iotdb.git
commit bf97725911550fc00455c3e42530dd0658809f1f
Author: Steve Yurong Su <ro...@apache.org>
AuthorDate: Mon Jul 31 14:38:33 2023 +0800
Disable some pipe extractor's features due to unstability
---
.../pipe/extractor/IoTDBDataRegionExtractor.java | 39 ++--------------------
1 file changed, 2 insertions(+), 37 deletions(-)
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/extractor/IoTDBDataRegionExtractor.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/extractor/IoTDBDataRegionExtractor.java
index 35749c31a83..fb587e7c5be 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/extractor/IoTDBDataRegionExtractor.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/extractor/IoTDBDataRegionExtractor.java
@@ -25,8 +25,6 @@ import org.apache.iotdb.db.pipe.extractor.historical.PipeHistoricalDataRegionExt
import org.apache.iotdb.db.pipe.extractor.historical.PipeHistoricalDataRegionTsFileExtractor;
import org.apache.iotdb.db.pipe.extractor.realtime.PipeRealtimeDataRegionExtractor;
import org.apache.iotdb.db.pipe.extractor.realtime.PipeRealtimeDataRegionFakeExtractor;
-import org.apache.iotdb.db.pipe.extractor.realtime.PipeRealtimeDataRegionHybridExtractor;
-import org.apache.iotdb.db.pipe.extractor.realtime.PipeRealtimeDataRegionLogExtractor;
import org.apache.iotdb.db.pipe.extractor.realtime.PipeRealtimeDataRegionTsFileExtractor;
import org.apache.iotdb.db.storageengine.StorageEngine;
import org.apache.iotdb.pipe.api.PipeExtractor;
@@ -46,9 +44,6 @@ import static org.apache.iotdb.db.pipe.config.constant.PipeExtractorConstant.EXT
import static org.apache.iotdb.db.pipe.config.constant.PipeExtractorConstant.EXTRACTOR_REALTIME_ENABLE;
import static org.apache.iotdb.db.pipe.config.constant.PipeExtractorConstant.EXTRACTOR_REALTIME_MODE;
import static org.apache.iotdb.db.pipe.config.constant.PipeExtractorConstant.EXTRACTOR_REALTIME_MODE_FILE;
-import static org.apache.iotdb.db.pipe.config.constant.PipeExtractorConstant.EXTRACTOR_REALTIME_MODE_FORCED_LOG;
-import static org.apache.iotdb.db.pipe.config.constant.PipeExtractorConstant.EXTRACTOR_REALTIME_MODE_HYBRID;
-import static org.apache.iotdb.db.pipe.config.constant.PipeExtractorConstant.EXTRACTOR_REALTIME_MODE_LOG;
public class IoTDBDataRegionExtractor implements PipeExtractor {
@@ -84,12 +79,7 @@ public class IoTDBDataRegionExtractor implements PipeExtractor {
// Validate extractor.realtime.mode
if (validator.getParameters().getBooleanOrDefault(EXTRACTOR_REALTIME_ENABLE, true)) {
validator.validateAttributeValueRange(
- EXTRACTOR_REALTIME_MODE,
- true,
- EXTRACTOR_REALTIME_MODE_FILE,
- EXTRACTOR_REALTIME_MODE_HYBRID,
- EXTRACTOR_REALTIME_MODE_LOG,
- EXTRACTOR_REALTIME_MODE_FORCED_LOG);
+ EXTRACTOR_REALTIME_MODE, true, EXTRACTOR_REALTIME_MODE_FILE);
}
constructHistoricalExtractor();
@@ -112,32 +102,7 @@ public class IoTDBDataRegionExtractor implements PipeExtractor {
return;
}
- // Use hybrid mode by default
- if (!parameters.hasAttribute(EXTRACTOR_REALTIME_MODE)) {
- realtimeExtractor = new PipeRealtimeDataRegionHybridExtractor();
- LOGGER.info("'{}' is not set, use hybrid mode by default.", EXTRACTOR_REALTIME_MODE);
- return;
- }
-
- switch (parameters.getString(EXTRACTOR_REALTIME_MODE)) {
- case EXTRACTOR_REALTIME_MODE_FILE:
- realtimeExtractor = new PipeRealtimeDataRegionTsFileExtractor();
- break;
- case EXTRACTOR_REALTIME_MODE_HYBRID:
- case EXTRACTOR_REALTIME_MODE_LOG:
- realtimeExtractor = new PipeRealtimeDataRegionHybridExtractor();
- break;
- case EXTRACTOR_REALTIME_MODE_FORCED_LOG:
- realtimeExtractor = new PipeRealtimeDataRegionLogExtractor();
- break;
- default:
- realtimeExtractor = new PipeRealtimeDataRegionHybridExtractor();
- if (LOGGER.isWarnEnabled()) {
- LOGGER.warn(
- "Unsupported extractor realtime mode: {}, create a hybrid extractor.",
- parameters.getString(EXTRACTOR_REALTIME_MODE));
- }
- }
+ realtimeExtractor = new PipeRealtimeDataRegionTsFileExtractor();
}
@Override