Proposed patch for Tomcat 4.1: Replacing JarURLHandler with Ant's ZipFile class

[Jochen Wiedmann <jo...@apache.org>]

Hi,

in

      http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26275

it turned out, that Tomcat suffers from a problem in Java's zip file
handling, which persists since years and most probably won't be fixed in the
next years. It also turned out, that the problem could be fixed by using
Ant's ZipFile class.

In the last days I inspected Tomcat's (4.1.30) sources for extracting WAR
files. To be honest, I find them a real mess. The design decision for
dealing with jar: and file: URL's seems to me to be severely broken,
because in the end it depends on an underlying File anyways.

Attached you find a patch, which is *not* necessary to fix bug 26275.
(Changes in ExtractWar would be sufficient.) However, I find it worth
looking at, because you'll easily see that replacing URL's with File's
reduces the code complexity quite much.

The attached patch is *not* ready for checkin, because I did not even
test it. (That's why I omitted the [PATCH] in the subject.) I just wanted a
first sign, whether it's worth to continue. If you don't like this work,
let me know and I'll return with a smaller fix for 26275.


Jochen

Re: Proposed patch for Tomcat 4.1: Replacing JarURLHandler with Ant's ZipFile class

[MagicDraw Support Team <bu...@magicdraw.com>]

Hello Jochen Wiedmann <jo...@apache.org>:

Thank you for your inquiry. This is an automated response from MagicDraw support team. We have received
your message regarding "Proposed patch for Tomcat 4.1: Replacing JarURLHandler with Ant's
 ZipFile class"

We would like to offer our sincere thanks to you for emailing us!

Your message has been recorded into our customer service database.

Our staff responds to messages during regular business hours European time,
although we also attempt to answer messages in the weekends whenever
possible. Messages are normally answered within one to two business days.

For even faster assistance, you can browse our FAQ list at:
http://www.magicdraw.com/faq.php

Sincerely,

MagicDraw Support Team


---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org

Re: Proposed patch for Tomcat 4.1: Replacing JarURLHandler with Ant's ZipFile class

[Remy Maucherat <re...@apache.org>]

Jochen Wiedmann wrote:
>      http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26275
> 
> it turned out, that Tomcat suffers from a problem in Java's zip file
> handling, which persists since years and most probably won't be fixed in 
> the
> next years. It also turned out, that the problem could be fixed by using
> Ant's ZipFile class.
> 
> In the last days I inspected Tomcat's (4.1.30) sources for extracting WAR
> files. To be honest, I find them a real mess. The design decision for
> dealing with jar: and file: URL's seems to me to be severely broken,
> because in the end it depends on an underlying File anyways.
> 
> Attached you find a patch, which is *not* necessary to fix bug 26275.
> (Changes in ExtractWar would be sufficient.) However, I find it worth
> looking at, because you'll easily see that replacing URL's with File's
> reduces the code complexity quite much.
> 
> The attached patch is *not* ready for checkin, because I did not even
> test it. (That's why I omitted the [PATCH] in the subject.) I just wanted a
> first sign, whether it's worth to continue. If you don't like this work,
> let me know and I'll return with a smaller fix for 26275.

-1. I don't like your patch, sorry.

Rémy


---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org