You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2015/01/12 13:15:27 UTC

[GitHub] spark pull request: [SPARK-5201][CORE] deal with int overflow in t...

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4002#discussion_r22786476
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/ParallelCollectionRDD.scala ---
    @@ -127,18 +127,12 @@ private object ParallelCollectionRDD {
           })
         }
         seq match {
    -      case r: Range.Inclusive => {
    -        val sign = if (r.step < 0) {
    -          -1
    -        } else {
    -          1
    -        }
    -        slice(new Range(
    -          r.start, r.end + sign, r.step).asInstanceOf[Seq[T]], numSlices)
    -      }
           case r: Range => {
    -        positions(r.length, numSlices).map({
    -          case (start, end) =>
    +        val sign = r.isInclusive && (r.end == Int.MaxValue || r.end == Int.MinValue)
    --- End diff --
    
    Maybe I'm missing it but why is `IntMinValue` a special case here? Also the `({` on the next line is redundant. Just one is needed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org