You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@devicemap.apache.org by Radu Cotescu <ra...@apache.org> on 2014/07/15 23:19:47 UTC
[VOTE] Release Apache DeviceMap BrowserMap version 1.4.1
Hi,
I've prepared an official release of the Apache DeviceMap BrowserMap
module. Due to how this module was versioned before the first official
release at ASF will be 1.4.1.
Staging URL: https://people.apache.org/~radu/browsermap/
The project's keys file is available at:
https://people.apache.org/keys/group/devicemap.asc
In case you need to import the keys, after downloading the keys file, run
the following command:
gpg --import devicemap.asc
You can use this UNIX script to download the release and verify the
signatures:
http://svn.apache.org/repos/asf/incubator/devicemap/trunk/check_staged_release.sh
Usage:
sh check_staged_release.sh [staging URL]
Please vote to approve this release:
[ ] +1 Approve the release
[ ] 0 Don't care
[ ] -1 Don't release, because ...
This majority vote is open for at least 72 hours.
Regards,
Radu
Re: [VOTE] Release Apache DeviceMap BrowserMap version 1.4.1
Posted by Kevan Miller <ke...@gmail.com>.
Hi Radu,
+1
I have one minor comment. The NOTICE file includes the following text,
which should be deleted:
Apache DeviceMap includes subcomponents with separate copyright notices and
license terms. Your use of these subcomponents is subject to the terms
and conditions of those licenses.
This does not need to block a release. However, should be fixed in trunk.
On Fri, Jul 18, 2014 at 3:41 PM, Radu Cotescu <ra...@apache.org> wrote:
> Hi,
>
> I've staged yet another set of release artifacts after eliminating some
> redundant development dependencies. I've also updated the README.md file to
> remove some of the instructions advising on installing 'jscoverage'
> globally.
>
> Due to the fact that I've used version 1.4.1-rc1 in package.json, the
> previously staged artifacts were not compliant for a 1.4.1 release. I've
> now updated package.json to indicate a 1.4.1 release, while the newly
> staged artifacts are named like browsermap-1.4.1-rc2-incubating.tar.gz*.
>
> After the vote passes, renaming them to 1.4.1 won't change the checksums
> and the package.json will indicate the correct version.
>
> A full diff between rc1:rc2 can be found at
> https://gist.github.com/raducotescu/f876348e82183d412a3d
>
>
> #####################################################################################
>
> Staging URL: https://people.apache.org/~radu/browsermap/
>
> The project's keys file is available at:
> https://people.apache.org/keys/group/devicemap.asc
>
> In case you need to import the keys, after downloading the keys file, run
> the following command:
> gpg --import devicemap.asc
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> http://svn.apache.org/repos/asf/incubator/devicemap/trunk/check_staged_release.sh
>
> Usage:
> sh check_staged_release.sh https://people.apache.org/~radu/browsermap/
>
> An Apache Creadur Rat exclude file is provided at
>
> http://svn.apache.org/repos/asf/incubator/devicemap/trunk/browsermap/trunk/rat.exclude
> .
>
> To check the licensing compliance you could run the following command after
> expanding the browsermap-1.4.1-rc2-incubating.tar.gz archive:
> java -jar apache-rat.jar -E browsermap-1.4.1-incubating/rat.exclude -d
> browsermap-1.4.1-incubating
>
> The current artifacts correspond to tag
>
> http://svn.apache.org/viewvc/incubator/devicemap/trunk/browsermap/tags/browsermap-1.4.1-rc2/
> .
>
> Once the release is approved we have to:
> 1. tag the release under
>
> https://svn.apache.org/viewvc/incubator/devicemap/tags/releases/browsermap-1.4.1
> 2. upload the new artifacts to the dist location
>
> Please vote to approve this release:
> [ ] +1 Approve the release
> [ ] 0 Don't care
> [ ] -1 Don't release, because ...
>
> Regards,
> Radu
>
>
> On Thu, Jul 17, 2014 at 7:20 PM, Radu Cotescu <ra...@apache.org> wrote:
>
> > Hi Bertrand,
> >
> > I've successfully built BrowserMap on a fresh Linux box (when it comes to
> > Node.js and npm) and had no problems. I've also checked my environment
> and
> > I cannot see anything special which has not been covered by the module's
> > README file regarding development.
> >
> > Therefore I'm inclining to think that there might be something which
> > hasn't been set up as expected on your box - most probably related to
> node,
> > rather than the BrowserMap module.
> >
> > Regards,
> > Radu
> >
> > On Thu, Jul 17, 2014 at 6:34 PM, Bertrand Delacretaz <
> > bdelacretaz@apache.org> wrote:
> >
> >> "sudo grunt package" works, so I guess that's really a problem with my
> >> grunt/node environment
> >>
> >
> >
> >
>
Re: [VOTE] Release Apache DeviceMap BrowserMap version 1.4.1
Posted by Radu Cotescu <ra...@apache.org>.
Hi,
I've staged yet another set of release artifacts after eliminating some
redundant development dependencies. I've also updated the README.md file to
remove some of the instructions advising on installing 'jscoverage'
globally.
Due to the fact that I've used version 1.4.1-rc1 in package.json, the
previously staged artifacts were not compliant for a 1.4.1 release. I've
now updated package.json to indicate a 1.4.1 release, while the newly
staged artifacts are named like browsermap-1.4.1-rc2-incubating.tar.gz*.
After the vote passes, renaming them to 1.4.1 won't change the checksums
and the package.json will indicate the correct version.
A full diff between rc1:rc2 can be found at
https://gist.github.com/raducotescu/f876348e82183d412a3d
#####################################################################################
Staging URL: https://people.apache.org/~radu/browsermap/
The project's keys file is available at:
https://people.apache.org/keys/group/devicemap.asc
In case you need to import the keys, after downloading the keys file, run
the following command:
gpg --import devicemap.asc
You can use this UNIX script to download the release and verify the
signatures:
http://svn.apache.org/repos/asf/incubator/devicemap/trunk/check_staged_release.sh
Usage:
sh check_staged_release.sh https://people.apache.org/~radu/browsermap/
An Apache Creadur Rat exclude file is provided at
http://svn.apache.org/repos/asf/incubator/devicemap/trunk/browsermap/trunk/rat.exclude
.
To check the licensing compliance you could run the following command after
expanding the browsermap-1.4.1-rc2-incubating.tar.gz archive:
java -jar apache-rat.jar -E browsermap-1.4.1-incubating/rat.exclude -d
browsermap-1.4.1-incubating
The current artifacts correspond to tag
http://svn.apache.org/viewvc/incubator/devicemap/trunk/browsermap/tags/browsermap-1.4.1-rc2/
.
Once the release is approved we have to:
1. tag the release under
https://svn.apache.org/viewvc/incubator/devicemap/tags/releases/browsermap-1.4.1
2. upload the new artifacts to the dist location
Please vote to approve this release:
[ ] +1 Approve the release
[ ] 0 Don't care
[ ] -1 Don't release, because ...
Regards,
Radu
On Thu, Jul 17, 2014 at 7:20 PM, Radu Cotescu <ra...@apache.org> wrote:
> Hi Bertrand,
>
> I've successfully built BrowserMap on a fresh Linux box (when it comes to
> Node.js and npm) and had no problems. I've also checked my environment and
> I cannot see anything special which has not been covered by the module's
> README file regarding development.
>
> Therefore I'm inclining to think that there might be something which
> hasn't been set up as expected on your box - most probably related to node,
> rather than the BrowserMap module.
>
> Regards,
> Radu
>
> On Thu, Jul 17, 2014 at 6:34 PM, Bertrand Delacretaz <
> bdelacretaz@apache.org> wrote:
>
>> "sudo grunt package" works, so I guess that's really a problem with my
>> grunt/node environment
>>
>
>
>
Re: [VOTE] Release Apache DeviceMap BrowserMap version 1.4.1
Posted by Radu Cotescu <ra...@apache.org>.
Hi Bertrand,
I've successfully built BrowserMap on a fresh Linux box (when it comes to
Node.js and npm) and had no problems. I've also checked my environment and
I cannot see anything special which has not been covered by the module's
README file regarding development.
Therefore I'm inclining to think that there might be something which hasn't
been set up as expected on your box - most probably related to node, rather
than the BrowserMap module.
Regards,
Radu
On Thu, Jul 17, 2014 at 6:34 PM, Bertrand Delacretaz <bdelacretaz@apache.org
> wrote:
> "sudo grunt package" works, so I guess that's really a problem with my
> grunt/node environment
>
Re: [VOTE] Release Apache DeviceMap BrowserMap version 1.4.1
Posted by Bertrand Delacretaz <bd...@apache.org>.
On Thu, Jul 17, 2014 at 3:16 PM, Bertrand Delacretaz
<bd...@apache.org> wrote:
> The build ("grunt package") fails for me...
"sudo grunt package" works, so I guess that's really a problem with my
grunt/node environment.
-Bertrand
Re: [VOTE] Release Apache DeviceMap BrowserMap version 1.4.1
Posted by Bertrand Delacretaz <bd...@apache.org>.
Hi Radu,
On Tue, Jul 15, 2014 at 11:19 PM, Radu Cotescu <ra...@apache.org> wrote:
> ...Staging URL: https://people.apache.org/~radu/browsermap/ ...
I have checked the following archives according to
http://incubator.apache.org/guides/releasemanagement.html#check-list
SHA1(browsermap-1.4.1-rc1-incubating-dist.tar.gz)=
ac452fefe60fbd784345325e62d3dc9a687ee1ae
SHA1(browsermap-1.4.1-rc1-incubating.tar.gz)=
ded29b1b0c7b1f78a00c06bfdf883834c6a6ba8d
IIUC browsermap-1.4.1-rc1-incubating-dist.tar.gz contains the results
of building the module from browsermap-1.4.1-rc1-incubating.tar.gz, so
I suggest considering only the latter as an Apache release, the former
being a convenience archive, and omitting the former from the upcoming
Incubator PMC vote.
Signatures and digests match.
The build ("grunt package") fails for me with
>> An error occurs in jsdoc process:
>> Error: Could not find or load main class
org.mozilla.javascript.tools.shell.Main
But that might just by my setup, I'm not familiar with Grunt.
DISCLAIMER, NOTICE and LICENSE look good to me - the latter mentions
dependencies which have acceptable licenses IMO.
Apache license headers look good to me.
So, +1 for releasing browsermap-1.4.1-rc1-incubating.tar.gz - I'm
ignoring the other archive as noted above. And assuming others can
build successfully, as I said I might have a broken setup.
Thanks for preparing this release!
-Bertrand
Re: [VOTE] Release Apache DeviceMap BrowserMap version 1.4.1
Posted by Reza <re...@yahoo.com.INVALID>.
+1
________________________________
From: Radu Cotescu <ra...@apache.org>
To: devicemap-dev <de...@incubator.apache.org>
Sent: Tuesday, July 15, 2014 5:19 PM
Subject: [VOTE] Release Apache DeviceMap BrowserMap version 1.4.1
Hi,
I've prepared an official release of the Apache DeviceMap BrowserMap
module. Due to how this module was versioned before the first official
release at ASF will be 1.4.1.
Staging URL: https://people.apache.org/~radu/browsermap/
The project's keys file is available at:
https://people.apache.org/keys/group/devicemap.asc
In case you need to import the keys, after downloading the keys file, run
the following command:
gpg --import devicemap.asc
You can use this UNIX script to download the release and verify the
signatures:
http://svn.apache.org/repos/asf/incubator/devicemap/trunk/check_staged_release.sh
Usage:
sh check_staged_release.sh [staging URL]
Please vote to approve this release:
[ ] +1 Approve the release
[ ] 0 Don't care
[ ] -1 Don't release, because ...
This majority vote is open for at least 72 hours.
Regards,
Radu
Re: [VOTE] Release Apache DeviceMap BrowserMap version 1.4.1
Posted by Werner Keil <we...@gmail.com>.
So looks like it was a bug/inability by a webmaster to do this properly?[?]
Well hopefully if we can get a Git repo after graduation works, then having
multiple repos (DeltaSpike has only one btw, including all the modules, but
Cordova or CouchDB got dozens each[?])
Regards,
Werner
On Thu, Jul 17, 2014 at 4:17 PM, Radu Cotescu <ra...@apache.org> wrote:
> The links I'm pasting in my messages are meant to be read sometimes.
> Here's another one [4]. That comments says:
>
> Gavin added a comment - 10/Jul/13 14:39
>> not had much success with this so far, any chance this project sub-dir
>> can get the standard [trunk/Branches/tags] layout done to it?
>> [~radu.cotescu]
>
>
> Regards,
> Radu
>
> [4] -
> https://issues.apache.org/jira/browse/INFRA-6220?focusedCommentId=13704458&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13704458
>
> On Thu, Jul 17, 2014 at 5:01 PM, Werner Keil <we...@gmail.com>
> wrote:
>
>> The name "trunk" for the part that's synchronized with Git was extremely
>> bad, don't think that was a mandatory requirement or seriously INFRA's
>> recommendation to do that, but let's hope these things can get untangled
>> soon[?]
>>
>
>
>
Re: [VOTE] Release Apache DeviceMap BrowserMap version 1.4.1
Posted by Radu Cotescu <ra...@apache.org>.
The links I'm pasting in my messages are meant to be read sometimes. Here's
another one [4]. That comments says:
Gavin added a comment - 10/Jul/13 14:39
> not had much success with this so far, any chance this project sub-dir can
> get the standard [trunk/Branches/tags] layout done to it? [~radu.cotescu]
Regards,
Radu
[4] -
https://issues.apache.org/jira/browse/INFRA-6220?focusedCommentId=13704458&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13704458
On Thu, Jul 17, 2014 at 5:01 PM, Werner Keil <we...@gmail.com> wrote:
> The name "trunk" for the part that's synchronized with Git was extremely
> bad, don't think that was a mandatory requirement or seriously INFRA's
> recommendation to do that, but let's hope these things can get untangled
> soon[?]
>
Re: [VOTE] Release Apache DeviceMap BrowserMap version 1.4.1
Posted by Werner Keil <we...@gmail.com>.
The name "trunk" for the part that's synchronized with Git was extremely
bad, don't think that was a mandatory requirement or seriously INFRA's
recommendation to do that, but let's hope these things can get untangled
soon[?]
I recall DeltaSpike has quite a few Git repos. Same for PhoneGap/Cordova
from what I've seen.
Cheers,
Werner
On Thu, Jul 17, 2014 at 3:25 PM, Radu Cotescu <ra...@apache.org> wrote:
> Hi Werner,
>
> As discussed before [0], we need that structure for the TravisCI
> integration [1]. If the project graduates we could ask for multiple
> repositories (I'm thinking of a main GitHub repo with several repos hosting
> sub-modules like browsermap, for example) in order to get rid of the
> sub-tree you don't like that much.
>
> However, until then, following INFRA's recommendation is the way to go for
> now. Tagging browsermap milestones under the browsermap/tags structure also
> provides us with automatically imported tags on GitHub [2].
>
> Also, now there's a README.md [3] file in the repo that tries to clarify
> the ambiguities of that sub-tree.
>
> Cheers,
> Radu
>
> [0] - http://markmail.org/message/wraggdgsab2utkl7
> [1] - https://travis-ci.org/apache/devicemap-browsermap/builds
> [2] - https://github.com/apache/devicemap-browsermap/releases
> [3] -
> http://svn.apache.org/viewvc/incubator/devicemap/trunk/browsermap/README.md?view=markup
>
>
> On Thu, Jul 17, 2014 at 1:00 PM, Werner Keil <we...@gmail.com>
> wrote:
>
>> Assuming this happens
>>
>> Once the release is approved we have to:
>> 1. bump the version to 1.4.1 in the module's package.json file
>> *2. tag the release
>> under https://svn.apache.org/viewvc/incubator/devicemap/tags/releases/
>> <https://svn.apache.org/viewvc/incubator/devicemap/tags/releases/>browsermap-1.4.1*
>>
>> (the /trunk/trunk is highly disturbing, but /trunk/tags is even worse, it
>> creates a "parallel universe" for BrowserMap that's confusing to any
>> potential adopter who checks out all or most of the SVN codebase[?])
>>
>> I am fine to stick to my +1.
>>
>> I haven't studied a graduation path upfront, but assuming the
>> /incubator/devicemap may be replaced by something without /incubator if
>> graduation was successful, please let's clean this mess no later than
>> graduation for browsermap[?]
>>
>> Thanks,
>> Werner
>>
>>
>> On Wed, Jul 16, 2014 at 4:33 PM, Kevan Miller <ke...@gmail.com>
>> wrote:
>>
>>> Looks good. Thanks Radu!
>>>
>>> +1
>>>
>>> --kevan
>>>
>>>
>>> On Wed, Jul 16, 2014 at 5:16 AM, Radu Cotescu <ra...@apache.org> wrote:
>>>
>>>> Hi,
>>>>
>>>> I've staged another set of release artifacts. @Kevan, @Bertrand, could
>>>> you please check that everything's ok this time?
>>>>
>>>> Staging URL: https://people.apache.org/~radu/browsermap/
>>>>
>>>> The project's keys file is available at:
>>>> https://people.apache.org/keys/group/devicemap.asc
>>>>
>>>> In case you need to import the keys, after downloading the keys file,
>>>> run the following command:
>>>> gpg --import devicemap.asc
>>>>
>>>> You can use this UNIX script to download the release and verify the
>>>> signatures:
>>>> http://svn.apache.org/repos/asf/incubator/devicemap/trunk/check_staged_release.sh
>>>>
>>>> Usage:
>>>> sh check_staged_release.sh https://people.apache.org/~radu/browsermap/
>>>>
>>>> An Apache Creadur Rat exclude file is provided at
>>>> http://svn.apache.org/repos/asf/incubator/devicemap/trunk/browsermap/trunk/rat.exclude
>>>> .
>>>>
>>>> To check the licensing compliance you could run the following command
>>>> after expanding the browsermap-1.4.1-rc1-incubating.tar.gz archive:
>>>> java -jar apache-rat.jar -E browsermap-1.4.1-rc1-incubating/rat.exclude
>>>> -d browsermap-1.4.1-rc1-incubating
>>>>
>>>> The current artifacts correspond to tag
>>>> http://svn.apache.org/viewvc/incubator/devicemap/trunk/browsermap/tags/browsermap-1.4.1-rc1/
>>>> .
>>>>
>>>> Once the release is approved we have to:
>>>> 1. bump the version to 1.4.1 in the module's package.json file
>>>> 2. tag the release under
>>>> https://svn.apache.org/viewvc/incubator/devicemap/tags/releases/
>>>> browsermap-1.4.1
>>>> 3. upload the new artifacts to the dist location
>>>>
>>>> Please vote to approve this release:
>>>> [ ] +1 Approve the release
>>>> [ ] 0 Don't care
>>>> [ ] -1 Don't release, because ...
>>>>
>>>> Regards,
>>>> Radu
>>>>
>>>>
>>>> On Wed, Jul 16, 2014 at 12:42 PM, Werner Keil <we...@gmail.com>
>>>> wrote:
>>>>
>>>>> Thanks for bringing that up here.
>>>>>
>>>>> RAT among other plugins is in those top level POMs, so projects that
>>>>> wish to do can run such screenings on a regular basis[?]
>>>>>
>>>>> As the W3C library is now used in binary form (JAR) I don't expect
>>>>> issues in any of the Java components including those using W3C right now.
>>>>>
>>>>> Werner
>>>>>
>>>>> On Wed, Jul 16, 2014 at 8:58 AM, Bertrand Delacretaz <
>>>>> bdelacretaz@apache.org> wrote:
>>>>>
>>>>>> On Tue, Jul 15, 2014 at 11:19 PM, Radu Cotescu <ra...@apache.org>
>>>>>> wrote:
>>>>>> > Please vote to approve this release...
>>>>>>
>>>>>> So -1 for now, until we clarify the RAT issue and whether we can
>>>>>> remove "derived" files from the release.
>>>>>>
>>>>>> -Bertrand
>>>>>>
>>>>>
>>>>>
>>>>
>>>
>>
>
Re: [VOTE] Release Apache DeviceMap BrowserMap version 1.4.1
Posted by Radu Cotescu <ra...@apache.org>.
Hi Werner,
As discussed before [0], we need that structure for the TravisCI
integration [1]. If the project graduates we could ask for multiple
repositories (I'm thinking of a main GitHub repo with several repos hosting
sub-modules like browsermap, for example) in order to get rid of the
sub-tree you don't like that much.
However, until then, following INFRA's recommendation is the way to go for
now. Tagging browsermap milestones under the browsermap/tags structure also
provides us with automatically imported tags on GitHub [2].
Also, now there's a README.md [3] file in the repo that tries to clarify
the ambiguities of that sub-tree.
Cheers,
Radu
[0] - http://markmail.org/message/wraggdgsab2utkl7
[1] - https://travis-ci.org/apache/devicemap-browsermap/builds
[2] - https://github.com/apache/devicemap-browsermap/releases
[3] -
http://svn.apache.org/viewvc/incubator/devicemap/trunk/browsermap/README.md?view=markup
On Thu, Jul 17, 2014 at 1:00 PM, Werner Keil <we...@gmail.com> wrote:
> Assuming this happens
>
> Once the release is approved we have to:
> 1. bump the version to 1.4.1 in the module's package.json file
> *2. tag the release
> under https://svn.apache.org/viewvc/incubator/devicemap/tags/releases/
> <https://svn.apache.org/viewvc/incubator/devicemap/tags/releases/>browsermap-1.4.1*
>
> (the /trunk/trunk is highly disturbing, but /trunk/tags is even worse, it
> creates a "parallel universe" for BrowserMap that's confusing to any
> potential adopter who checks out all or most of the SVN codebase[?])
>
> I am fine to stick to my +1.
>
> I haven't studied a graduation path upfront, but assuming the
> /incubator/devicemap may be replaced by something without /incubator if
> graduation was successful, please let's clean this mess no later than
> graduation for browsermap[?]
>
> Thanks,
> Werner
>
>
> On Wed, Jul 16, 2014 at 4:33 PM, Kevan Miller <ke...@gmail.com>
> wrote:
>
>> Looks good. Thanks Radu!
>>
>> +1
>>
>> --kevan
>>
>>
>> On Wed, Jul 16, 2014 at 5:16 AM, Radu Cotescu <ra...@apache.org> wrote:
>>
>>> Hi,
>>>
>>> I've staged another set of release artifacts. @Kevan, @Bertrand, could
>>> you please check that everything's ok this time?
>>>
>>> Staging URL: https://people.apache.org/~radu/browsermap/
>>>
>>> The project's keys file is available at:
>>> https://people.apache.org/keys/group/devicemap.asc
>>>
>>> In case you need to import the keys, after downloading the keys file,
>>> run the following command:
>>> gpg --import devicemap.asc
>>>
>>> You can use this UNIX script to download the release and verify the
>>> signatures:
>>> http://svn.apache.org/repos/asf/incubator/devicemap/trunk/check_staged_release.sh
>>>
>>> Usage:
>>> sh check_staged_release.sh https://people.apache.org/~radu/browsermap/
>>>
>>> An Apache Creadur Rat exclude file is provided at
>>> http://svn.apache.org/repos/asf/incubator/devicemap/trunk/browsermap/trunk/rat.exclude
>>> .
>>>
>>> To check the licensing compliance you could run the following command
>>> after expanding the browsermap-1.4.1-rc1-incubating.tar.gz archive:
>>> java -jar apache-rat.jar -E browsermap-1.4.1-rc1-incubating/rat.exclude
>>> -d browsermap-1.4.1-rc1-incubating
>>>
>>> The current artifacts correspond to tag
>>> http://svn.apache.org/viewvc/incubator/devicemap/trunk/browsermap/tags/browsermap-1.4.1-rc1/
>>> .
>>>
>>> Once the release is approved we have to:
>>> 1. bump the version to 1.4.1 in the module's package.json file
>>> 2. tag the release under
>>> https://svn.apache.org/viewvc/incubator/devicemap/tags/releases/
>>> browsermap-1.4.1
>>> 3. upload the new artifacts to the dist location
>>>
>>> Please vote to approve this release:
>>> [ ] +1 Approve the release
>>> [ ] 0 Don't care
>>> [ ] -1 Don't release, because ...
>>>
>>> Regards,
>>> Radu
>>>
>>>
>>> On Wed, Jul 16, 2014 at 12:42 PM, Werner Keil <we...@gmail.com>
>>> wrote:
>>>
>>>> Thanks for bringing that up here.
>>>>
>>>> RAT among other plugins is in those top level POMs, so projects that
>>>> wish to do can run such screenings on a regular basis[?]
>>>>
>>>> As the W3C library is now used in binary form (JAR) I don't expect
>>>> issues in any of the Java components including those using W3C right now.
>>>>
>>>> Werner
>>>>
>>>> On Wed, Jul 16, 2014 at 8:58 AM, Bertrand Delacretaz <
>>>> bdelacretaz@apache.org> wrote:
>>>>
>>>>> On Tue, Jul 15, 2014 at 11:19 PM, Radu Cotescu <ra...@apache.org>
>>>>> wrote:
>>>>> > Please vote to approve this release...
>>>>>
>>>>> So -1 for now, until we clarify the RAT issue and whether we can
>>>>> remove "derived" files from the release.
>>>>>
>>>>> -Bertrand
>>>>>
>>>>
>>>>
>>>
>>
>
Re: [VOTE] Release Apache DeviceMap BrowserMap version 1.4.1
Posted by Werner Keil <we...@gmail.com>.
Assuming this happens
Once the release is approved we have to:
1. bump the version to 1.4.1 in the module's package.json file
*2. tag the release
under https://svn.apache.org/viewvc/incubator/devicemap/tags/releases/
<https://svn.apache.org/viewvc/incubator/devicemap/tags/releases/>browsermap-1.4.1*
(the /trunk/trunk is highly disturbing, but /trunk/tags is even worse, it
creates a "parallel universe" for BrowserMap that's confusing to any
potential adopter who checks out all or most of the SVN codebase[?])
I am fine to stick to my +1.
I haven't studied a graduation path upfront, but assuming the
/incubator/devicemap may be replaced by something without /incubator if
graduation was successful, please let's clean this mess no later than
graduation for browsermap[?]
Thanks,
Werner
On Wed, Jul 16, 2014 at 4:33 PM, Kevan Miller <ke...@gmail.com>
wrote:
> Looks good. Thanks Radu!
>
> +1
>
> --kevan
>
>
> On Wed, Jul 16, 2014 at 5:16 AM, Radu Cotescu <ra...@apache.org> wrote:
>
>> Hi,
>>
>> I've staged another set of release artifacts. @Kevan, @Bertrand, could
>> you please check that everything's ok this time?
>>
>> Staging URL: https://people.apache.org/~radu/browsermap/
>>
>> The project's keys file is available at:
>> https://people.apache.org/keys/group/devicemap.asc
>>
>> In case you need to import the keys, after downloading the keys file, run
>> the following command:
>> gpg --import devicemap.asc
>>
>> You can use this UNIX script to download the release and verify the
>> signatures:
>> http://svn.apache.org/repos/asf/incubator/devicemap/trunk/check_staged_release.sh
>>
>> Usage:
>> sh check_staged_release.sh https://people.apache.org/~radu/browsermap/
>>
>> An Apache Creadur Rat exclude file is provided at
>> http://svn.apache.org/repos/asf/incubator/devicemap/trunk/browsermap/trunk/rat.exclude
>> .
>>
>> To check the licensing compliance you could run the following command
>> after expanding the browsermap-1.4.1-rc1-incubating.tar.gz archive:
>> java -jar apache-rat.jar -E browsermap-1.4.1-rc1-incubating/rat.exclude
>> -d browsermap-1.4.1-rc1-incubating
>>
>> The current artifacts correspond to tag
>> http://svn.apache.org/viewvc/incubator/devicemap/trunk/browsermap/tags/browsermap-1.4.1-rc1/
>> .
>>
>> Once the release is approved we have to:
>> 1. bump the version to 1.4.1 in the module's package.json file
>> 2. tag the release under
>> https://svn.apache.org/viewvc/incubator/devicemap/tags/releases/
>> browsermap-1.4.1
>> 3. upload the new artifacts to the dist location
>>
>> Please vote to approve this release:
>> [ ] +1 Approve the release
>> [ ] 0 Don't care
>> [ ] -1 Don't release, because ...
>>
>> Regards,
>> Radu
>>
>>
>> On Wed, Jul 16, 2014 at 12:42 PM, Werner Keil <we...@gmail.com>
>> wrote:
>>
>>> Thanks for bringing that up here.
>>>
>>> RAT among other plugins is in those top level POMs, so projects that
>>> wish to do can run such screenings on a regular basis[?]
>>>
>>> As the W3C library is now used in binary form (JAR) I don't expect
>>> issues in any of the Java components including those using W3C right now.
>>>
>>> Werner
>>>
>>> On Wed, Jul 16, 2014 at 8:58 AM, Bertrand Delacretaz <
>>> bdelacretaz@apache.org> wrote:
>>>
>>>> On Tue, Jul 15, 2014 at 11:19 PM, Radu Cotescu <ra...@apache.org> wrote:
>>>> > Please vote to approve this release...
>>>>
>>>> So -1 for now, until we clarify the RAT issue and whether we can
>>>> remove "derived" files from the release.
>>>>
>>>> -Bertrand
>>>>
>>>
>>>
>>
>
Re: [VOTE] Release Apache DeviceMap BrowserMap version 1.4.1
Posted by Kevan Miller <ke...@gmail.com>.
Looks good. Thanks Radu!
+1
--kevan
On Wed, Jul 16, 2014 at 5:16 AM, Radu Cotescu <ra...@apache.org> wrote:
> Hi,
>
> I've staged another set of release artifacts. @Kevan, @Bertrand, could you
> please check that everything's ok this time?
>
> Staging URL: https://people.apache.org/~radu/browsermap/
>
> The project's keys file is available at:
> https://people.apache.org/keys/group/devicemap.asc
>
> In case you need to import the keys, after downloading the keys file, run
> the following command:
> gpg --import devicemap.asc
>
> You can use this UNIX script to download the release and verify the
> signatures:
> http://svn.apache.org/repos/asf/incubator/devicemap/trunk/check_staged_release.sh
>
> Usage:
> sh check_staged_release.sh https://people.apache.org/~radu/browsermap/
>
> An Apache Creadur Rat exclude file is provided at
> http://svn.apache.org/repos/asf/incubator/devicemap/trunk/browsermap/trunk/rat.exclude
> .
>
> To check the licensing compliance you could run the following command
> after expanding the browsermap-1.4.1-rc1-incubating.tar.gz archive:
> java -jar apache-rat.jar -E browsermap-1.4.1-rc1-incubating/rat.exclude
> -d browsermap-1.4.1-rc1-incubating
>
> The current artifacts correspond to tag
> http://svn.apache.org/viewvc/incubator/devicemap/trunk/browsermap/tags/browsermap-1.4.1-rc1/
> .
>
> Once the release is approved we have to:
> 1. bump the version to 1.4.1 in the module's package.json file
> 2. tag the release under
> https://svn.apache.org/viewvc/incubator/devicemap/tags/releases/
> browsermap-1.4.1
> 3. upload the new artifacts to the dist location
>
> Please vote to approve this release:
> [ ] +1 Approve the release
> [ ] 0 Don't care
> [ ] -1 Don't release, because ...
>
> Regards,
> Radu
>
>
> On Wed, Jul 16, 2014 at 12:42 PM, Werner Keil <we...@gmail.com>
> wrote:
>
>> Thanks for bringing that up here.
>>
>> RAT among other plugins is in those top level POMs, so projects that wish
>> to do can run such screenings on a regular basis[?]
>>
>> As the W3C library is now used in binary form (JAR) I don't expect issues
>> in any of the Java components including those using W3C right now.
>>
>> Werner
>>
>> On Wed, Jul 16, 2014 at 8:58 AM, Bertrand Delacretaz <
>> bdelacretaz@apache.org> wrote:
>>
>>> On Tue, Jul 15, 2014 at 11:19 PM, Radu Cotescu <ra...@apache.org> wrote:
>>> > Please vote to approve this release...
>>>
>>> So -1 for now, until we clarify the RAT issue and whether we can
>>> remove "derived" files from the release.
>>>
>>> -Bertrand
>>>
>>
>>
>
Re: [VOTE] Release Apache DeviceMap BrowserMap version 1.4.1
Posted by Radu Cotescu <ra...@apache.org>.
Hi,
I've staged another set of release artifacts. @Kevan, @Bertrand, could you
please check that everything's ok this time?
Staging URL: https://people.apache.org/~radu/browsermap/
The project's keys file is available at:
https://people.apache.org/keys/group/devicemap.asc
In case you need to import the keys, after downloading the keys file, run
the following command:
gpg --import devicemap.asc
You can use this UNIX script to download the release and verify the
signatures:
http://svn.apache.org/repos/asf/incubator/devicemap/trunk/check_staged_release.sh
Usage:
sh check_staged_release.sh https://people.apache.org/~radu/browsermap/
An Apache Creadur Rat exclude file is provided at
http://svn.apache.org/repos/asf/incubator/devicemap/trunk/browsermap/trunk/rat.exclude
.
To check the licensing compliance you could run the following command after
expanding the browsermap-1.4.1-rc1-incubating.tar.gz archive:
java -jar apache-rat.jar -E browsermap-1.4.1-rc1-incubating/rat.exclude -d
browsermap-1.4.1-rc1-incubating
The current artifacts correspond to tag
http://svn.apache.org/viewvc/incubator/devicemap/trunk/browsermap/tags/browsermap-1.4.1-rc1/
.
Once the release is approved we have to:
1. bump the version to 1.4.1 in the module's package.json file
2. tag the release under
https://svn.apache.org/viewvc/incubator/devicemap/tags/releases/
browsermap-1.4.1
3. upload the new artifacts to the dist location
Please vote to approve this release:
[ ] +1 Approve the release
[ ] 0 Don't care
[ ] -1 Don't release, because ...
Regards,
Radu
On Wed, Jul 16, 2014 at 12:42 PM, Werner Keil <we...@gmail.com> wrote:
> Thanks for bringing that up here.
>
> RAT among other plugins is in those top level POMs, so projects that wish
> to do can run such screenings on a regular basis[?]
>
> As the W3C library is now used in binary form (JAR) I don't expect issues
> in any of the Java components including those using W3C right now.
>
> Werner
>
> On Wed, Jul 16, 2014 at 8:58 AM, Bertrand Delacretaz <
> bdelacretaz@apache.org> wrote:
>
>> On Tue, Jul 15, 2014 at 11:19 PM, Radu Cotescu <ra...@apache.org> wrote:
>> > Please vote to approve this release...
>>
>> So -1 for now, until we clarify the RAT issue and whether we can
>> remove "derived" files from the release.
>>
>> -Bertrand
>>
>
>
Re: [VOTE] Release Apache DeviceMap BrowserMap version 1.4.1
Posted by Werner Keil <we...@gmail.com>.
Thanks for bringing that up here.
RAT among other plugins is in those top level POMs, so projects that wish
to do can run such screenings on a regular basis[?]
As the W3C library is now used in binary form (JAR) I don't expect issues
in any of the Java components including those using W3C right now.
Werner
On Wed, Jul 16, 2014 at 8:58 AM, Bertrand Delacretaz <bdelacretaz@apache.org
> wrote:
> On Tue, Jul 15, 2014 at 11:19 PM, Radu Cotescu <ra...@apache.org> wrote:
> > Please vote to approve this release...
>
> So -1 for now, until we clarify the RAT issue and whether we can
> remove "derived" files from the release.
>
> -Bertrand
>
Re: [VOTE] Release Apache DeviceMap BrowserMap version 1.4.1
Posted by Bertrand Delacretaz <bd...@apache.org>.
On Tue, Jul 15, 2014 at 11:19 PM, Radu Cotescu <ra...@apache.org> wrote:
> Please vote to approve this release...
So -1 for now, until we clarify the RAT issue and whether we can
remove "derived" files from the release.
-Bertrand
Re: [VOTE] Release Apache DeviceMap BrowserMap version 1.4.1
Posted by Bertrand Delacretaz <bd...@apache.org>.
Hi,
Thanks Radu for preparing this release!
On Wed, Jul 16, 2014 at 6:51 AM, Kevan Miller <ke...@gmail.com> wrote:
> Unapproved licenses...
> ./demo/js/browsermap.min.js
> ./dist/browsermap.min.js...
Adding an Apache header to those minified js files would kill their
purpose, which is to be small ;-)
OTOH, do we really need to release them? I suppose they can be
recreated from the source code, so by analogy with java where we
release .java and users create .class files, the browsermap release
should only contain the primary source code along with the scripts
that allow users to create the minified versions? Same for the
cobertura coverage reports which are currently in the release archive
- IMO anything that can be recreated from other files shouldn't be in
an Apache release archive.
Radu, WDYT?
-Bertrand
Re: [VOTE] Release Apache DeviceMap BrowserMap version 1.4.1
Posted by Kevan Miller <ke...@gmail.com>.
Super. Thanks Reza!
I ran a RAT report on the release (http://creadur.apache.org/rat/).
Apologies for not doing it sooner (I have a new laptop/work environment)
and don't have it completely set up, yet. RAT will run some simple checks
of source license headers. It identified the following as having potential
problems:
Unapproved licenses:
./README.md
./demo/js/browsermap.min.js
./dist/browsermap.min.js
./doc/BrowserMap.html
./doc/BrowserMapUtil.CookieManager.html
./doc/BrowserMapUtil.File.html
./doc/BrowserMapUtil.Url.html
./doc/BrowserMapUtil.html
./doc/Cookie.html
./doc/index.html
./doc/scripts/linenumber.js
./doc/scripts/prettify/lang-css.js
./doc/scripts/prettify/prettify.js
./doc/styles/jsdoc-default.css
./doc/styles/prettify-jsdoc.css
./doc/styles/prettify-tomorrow.css
./reporting/cobertura-coverage.xml
./reporting/coverage/index.html
./reporting/coverage/prettify.css
./reporting/coverage/prettify.js
./reporting/coverage/js/index.html
./source/.gitignore
./source/README.md
./source/src/main/lib/matchMedia/matchMedia.js
./source/src/main/lib/modernizr/modernizr.custom.js
./source/src/test/resources/qunit/qunit-1.9.0.css
./source/src/test/resources/qunit/qunit-1.9.0.js
Note that some of these are not a problem (e.g. README files), but some
are. doc/* files are missing license headers. The license of the
doc/scripts/prettify/ files is missing from LICENSE file. gunit license
seems to be missing, also. If the cobertura-coverage.xml file is licensed
under https://github.com/cobertura/cobertura/blob/master/LICENSE.txt then
that's a problem, since it's GPL.
May be possible to release with some of these problems, but let's see what
can be fixed, also...
Also, NOTICE file contains Modernizr and matchMedia.js licenses. They
belong in LICENSE files.
--kevan
On Tue, Jul 15, 2014 at 2:19 PM, Radu Cotescu <ra...@apache.org> wrote:
> Hi,
>
> I've prepared an official release of the Apache DeviceMap BrowserMap
> module. Due to how this module was versioned before the first official
> release at ASF will be 1.4.1.
>
> Staging URL: https://people.apache.org/~radu/browsermap/
>
> The project's keys file is available at:
> https://people.apache.org/keys/group/devicemap.asc
>
> In case you need to import the keys, after downloading the keys file, run
> the following command:
> gpg --import devicemap.asc
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> http://svn.apache.org/repos/asf/incubator/devicemap/trunk/check_staged_release.sh
>
> Usage:
> sh check_staged_release.sh [staging URL]
>
> Please vote to approve this release:
> [ ] +1 Approve the release
> [ ] 0 Don't care
> [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Regards,
> Radu
>
Re: [VOTE] Release Apache DeviceMap BrowserMap version 1.4.1
Posted by Kevan Miller <ke...@gmail.com>.
On Tue, Jul 15, 2014 at 3:06 PM, Werner Keil <we...@gmail.com> wrote:
> Assuming all committers, not just Mentors or board members shall vote
> +1
>
All votes are welcome and should be encouraged. Release votes require a
minimum of 3 +1 votes from the PMC. Podling release votes are slightly
different in that 3 Incubator PMC votes are needed. However, that's a minor
detail.
--kevan
Re: [VOTE] Release Apache DeviceMap BrowserMap version 1.4.1
Posted by Werner Keil <we...@gmail.com>.
Assuming all committers, not just Mentors or board members shall vote
+1
Werner
Am 15.07.2014 23:19 schrieb "Radu Cotescu" <ra...@apache.org>:
> Hi,
>
> I've prepared an official release of the Apache DeviceMap BrowserMap
> module. Due to how this module was versioned before the first official
> release at ASF will be 1.4.1.
>
> Staging URL: https://people.apache.org/~radu/browsermap/
>
> The project's keys file is available at:
> https://people.apache.org/keys/group/devicemap.asc
>
> In case you need to import the keys, after downloading the keys file, run
> the following command:
> gpg --import devicemap.asc
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> http://svn.apache.org/repos/asf/incubator/devicemap/trunk/check_staged_release.sh
>
> Usage:
> sh check_staged_release.sh [staging URL]
>
> Please vote to approve this release:
> [ ] +1 Approve the release
> [ ] 0 Don't care
> [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Regards,
> Radu
>
Re: [VOTE] Release Apache DeviceMap BrowserMap version 1.4.1
Posted by "eberhard speer jr." <se...@ducis.net>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
+1
esjr
> Hi,
>
> I've prepared an official release of the Apache DeviceMap
> BrowserMap module. Due to how this module was versioned before the
> first official release at ASF will be 1.4.1.
>
> Staging URL: https://people.apache.org/~radu/browsermap/
>
> The project's keys file is available at:
> https://people.apache.org/keys/group/devicemap.asc
>
> In case you need to import the keys, after downloading the keys
> file, run the following command: gpg --import devicemap.asc
>
> You can use this UNIX script to download the release and verify
> the signatures:
> http://svn.apache.org/repos/asf/incubator/devicemap/trunk/check_staged_release.sh
>
> Usage: sh check_staged_release.sh [staging URL]
>
> Please vote to approve this release: [ ] +1 Approve the release [ ]
> 0 Don't care [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Regards, Radu
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQEcBAEBAgAGBQJTxhMxAAoJEOxywXcFLKYcb7IH/3lNZ8df7DXGuv+DdTbj7bVF
I4RvI8GMuFWyj5d0M25phQG4dNGK1/IeobxF4KM9e0Ctq/lb3L7TDT295oGsH1Qa
29alSnTWpC7vKW/R12ldMPXvXUg/A6LVedzojp2KSG6YK2Y+A/73q1UcYkqV964X
SjtI746rHJSLHpYT98VAi24CmXO2mfZ6sGt9/ys5AEIl3qtcCej0mxGgBa9OFk0D
w13kmAhBahvD+bxZTLoBqsp1/kPXphQ6JP5wHf8aLI7rrBAPL1XZNIhLnd1zDM0x
2Edm5wZr4E7F7gkwp187Tjx5Q4rvmwfZw20bPBHlddr7KV/5VVdYw4CrzuMBFSE=
=SUhz
-----END PGP SIGNATURE-----