You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by Sowmya Krishnan <so...@citrix.com> on 2013/08/25 19:10:51 UTC

Review Request 13800: CLOUDSTACK-4487 Offering deletes are not enforced including the waits

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13800/
-----------------------------------------------------------

Review request for cloudstack and Prasanna Santhanam.


Bugs: CLOUDSTACK-4487


Repository: cloudstack-git


Description
-------

Fixes CLOUDSTACK-4487.
Offering deletes are not needed anymore - hence removing them. So also the unnecessary waits on the same


Diffs
-----

  test/integration/component/test_netscaler_configs.py bcea254 
  test/integration/component/test_netscaler_lb.py 3942f94 
  test/integration/component/test_netscaler_lb_algo.py 477bd69 
  test/integration/component/test_netscaler_lb_sticky.py 1edfd7b 
  test/integration/component/test_netscaler_nw_off.py 84616e1 

Diff: https://reviews.apache.org/r/13800/diff/


Testing
-------

Tested locally and it passes


Thanks,

Sowmya Krishnan

Re: Review Request 13800: CLOUDSTACK-4487 Offering deletes are not enforced including the waits

Posted by Prasanna Santhanam <ts...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13800/#review25531
-----------------------------------------------------------

Ship it!


- Prasanna Santhanam


On Aug. 25, 2013, 5:10 p.m., Sowmya Krishnan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13800/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2013, 5:10 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-4487
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Fixes CLOUDSTACK-4487.
> Offering deletes are not needed anymore - hence removing them. So also the unnecessary waits on the same
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_netscaler_configs.py bcea254 
>   test/integration/component/test_netscaler_lb.py 3942f94 
>   test/integration/component/test_netscaler_lb_algo.py 477bd69 
>   test/integration/component/test_netscaler_lb_sticky.py 1edfd7b 
>   test/integration/component/test_netscaler_nw_off.py 84616e1 
> 
> Diff: https://reviews.apache.org/r/13800/diff/
> 
> 
> Testing
> -------
> 
> Tested locally and it passes
> 
> 
> Thanks,
> 
> Sowmya Krishnan
> 
>

Re: Review Request 13800: CLOUDSTACK-4487 Offering deletes are not enforced including the waits

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13800/#review25532
-----------------------------------------------------------


Commit f724c912969fb4c6fcfe02d48d31afcd82480b43 in branch refs/heads/master from Sowmya Krishnan
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f724c91 ]

CLOUDSTACK-4487: No need to delete offerings or wait on offering cleanup

Signed-off-by: Prasanna Santhanam <ts...@apache.org>
(cherry picked from commit bc5b6ae0e41a04ab2c892ce53199c1d7f1d0902c)


- ASF Subversion and Git Services


On Aug. 25, 2013, 5:10 p.m., Sowmya Krishnan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13800/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2013, 5:10 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-4487
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Fixes CLOUDSTACK-4487.
> Offering deletes are not needed anymore - hence removing them. So also the unnecessary waits on the same
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_netscaler_configs.py bcea254 
>   test/integration/component/test_netscaler_lb.py 3942f94 
>   test/integration/component/test_netscaler_lb_algo.py 477bd69 
>   test/integration/component/test_netscaler_lb_sticky.py 1edfd7b 
>   test/integration/component/test_netscaler_nw_off.py 84616e1 
> 
> Diff: https://reviews.apache.org/r/13800/diff/
> 
> 
> Testing
> -------
> 
> Tested locally and it passes
> 
> 
> Thanks,
> 
> Sowmya Krishnan
> 
>

Re: Review Request 13800: CLOUDSTACK-4487 Offering deletes are not enforced including the waits

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13800/#review25533
-----------------------------------------------------------


Commit bc5b6ae0e41a04ab2c892ce53199c1d7f1d0902c in branch refs/heads/4.2-forward from Sowmya Krishnan
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=bc5b6ae ]

CLOUDSTACK-4487: No need to delete offerings or wait on offering cleanup

Signed-off-by: Prasanna Santhanam <ts...@apache.org>


- ASF Subversion and Git Services


On Aug. 25, 2013, 5:10 p.m., Sowmya Krishnan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13800/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2013, 5:10 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-4487
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Fixes CLOUDSTACK-4487.
> Offering deletes are not needed anymore - hence removing them. So also the unnecessary waits on the same
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_netscaler_configs.py bcea254 
>   test/integration/component/test_netscaler_lb.py 3942f94 
>   test/integration/component/test_netscaler_lb_algo.py 477bd69 
>   test/integration/component/test_netscaler_lb_sticky.py 1edfd7b 
>   test/integration/component/test_netscaler_nw_off.py 84616e1 
> 
> Diff: https://reviews.apache.org/r/13800/diff/
> 
> 
> Testing
> -------
> 
> Tested locally and it passes
> 
> 
> Thanks,
> 
> Sowmya Krishnan
> 
>