You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/08/23 20:53:05 UTC
[GitHub] [helix] jiajunwang opened a new pull request #1848: Add stop server wait time to be 10 seconds in MockMetadataStoreDirectoryServer to avoid test failure.
jiajunwang opened a new pull request #1848:
URL: https://github.com/apache/helix/pull/1848
### Issues
- [X] My PR addresses the following Helix issues and references them in the PR description:
Fixes #1839
### Description
- [X] Here are some details about my PR, including screenshots of any UI changes:
This change aims to reduce the unexpected test failure due to http endpoint in use. The additional timeout shall help the test terminate server instances gracefully.
### Tests
- [X] The following tests are written for this issue:
This PR fixes test.
- The following is the result of the "mvn test" command on the appropriate module:
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on a change in pull request #1848: Add stop server wait time to be 10 seconds in MockMetadataStoreDirectoryServer to avoid test failure.
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on a change in pull request #1848:
URL: https://github.com/apache/helix/pull/1848#discussion_r694364987
##########
File path: metadata-store-directory-common/src/main/java/org/apache/helix/msdcommon/mock/MockMetadataStoreDirectoryServer.java
##########
@@ -103,7 +104,7 @@ public void startServer() throws IOException {
}
public void stopServer() {
- _server.stop(0);
+ _server.stop(STOP_WAIT_SEC);
Review comment:
* @param delay the maximum time in seconds to wait until exchanges have finished.
I think it is the wait time and usually returns earlier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] junkaixue commented on a change in pull request #1848: Add stop server wait time to be 10 seconds in MockMetadataStoreDirectoryServer to avoid test failure.
Posted by GitBox <gi...@apache.org>.
junkaixue commented on a change in pull request #1848:
URL: https://github.com/apache/helix/pull/1848#discussion_r694357046
##########
File path: metadata-store-directory-common/src/main/java/org/apache/helix/msdcommon/mock/MockMetadataStoreDirectoryServer.java
##########
@@ -103,7 +104,7 @@ public void startServer() throws IOException {
}
public void stopServer() {
- _server.stop(0);
+ _server.stop(STOP_WAIT_SEC);
Review comment:
Is this timeout meaning wait 10 seconds and try stop or totally timeout is 10 second can be terminated anytime during the middle as long as it is free?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang merged pull request #1848: Add stop server wait time to be 10 seconds in MockMetadataStoreDirectoryServer to avoid test failure.
Posted by GitBox <gi...@apache.org>.
jiajunwang merged pull request #1848:
URL: https://github.com/apache/helix/pull/1848
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on pull request #1848: Add stop server wait time to be 10 seconds in MockMetadataStoreDirectoryServer to avoid test failure.
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on pull request #1848:
URL: https://github.com/apache/helix/pull/1848#issuecomment-904200783
Approved by @junkaixue, I will merge the code after the test is done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org