[jira] [Comment Edited] (FLINK-25614) Let LocalWindowAggregate be chained with upstream

["Q Kang (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-25614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17473245#comment-17473245 ] 

Q Kang edited comment on FLINK-25614 at 1/12/22, 2:23 AM:
----------------------------------------------------------

The original intention of this change is to eliminate ser/deser between `LocalWindowAggregate` and its upstream, especially under heavy dataflows. However, when this change is deployed, the compacted event timestamp (row time) can no longer be serialized into a single Long value anymore, requiring multiple modifications to test cases.

 


was (Author: lmagics):
The original intention of this change is to eliminate ser/deser between `LocalWindowAggregate` and its upstream, especially under heavy dataflows. However, when this change is deployed, the compacted event timestamp (row time) can no longer be serialized into a single Long values anymore, requiring multiple modifications to test cases.

 

> Let LocalWindowAggregate be chained with upstream
> -------------------------------------------------
>
>                 Key: FLINK-25614
>                 URL: https://issues.apache.org/jira/browse/FLINK-25614
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table SQL / Runtime
>    Affects Versions: 1.14.2
>            Reporter: Q Kang
>            Priority: Minor
>              Labels: pull-request-available
>
> When enabling two-phase aggregation (local-global) strategy for Window TVF, the physical plan is shown as follows:
> {code:java}
> TableSourceScan -> Calc -> WatermarkAssigner -> Calc
> ||
> || [FORWARD]
> ||
> LocalWindowAggregate
> ||
> || [HASH]
> ||
> GlobalWindowAggregate
> ||
> ||
> ...{code}
> We can let the `LocalWindowAggregate` node be chained with upstream operators in order to improve efficiency, just like the non-windowing counterpart `LocalGroupAggregate`.
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)