You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2015/08/14 15:50:54 UTC
Review Request 37478: LENS-490: Document partition timeline in user
guide
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37478/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-490
https://issues.apache.org/jira/browse/LENS-490
Repository: lens
Description
-------
This task is to document the partition timeline.
It should document who are the users of it, what is timeline,
how to to use the cache, what are the defaults and why they are chosen, how/when to migrate, how/when to update existing timeline.
Diffs
-----
src/site/apt/user/olap-cube.apt 87fd659d28ce305460da43905a147f66b7b28824
Diff: https://reviews.apache.org/r/37478/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 37478: LENS-490: Document partition timeline in
user guide
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37478/#review95854
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Aug. 19, 2015, 12:11 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37478/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2015, 12:11 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-490
> https://issues.apache.org/jira/browse/LENS-490
>
>
> Repository: lens
>
>
> Description
> -------
>
> This task is to document the partition timeline.
> It should document who are the users of it, what is timeline,
> how to to use the cache, what are the defaults and why they are chosen, how/when to migrate, how/when to update existing timeline.
>
>
> Diffs
> -----
>
> src/site/apt/user/olap-cube.apt 87fd659d28ce305460da43905a147f66b7b28824
>
> Diff: https://reviews.apache.org/r/37478/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 37478: LENS-490: Document partition timeline in
user guide
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37478/
-----------------------------------------------------------
(Updated Aug. 19, 2015, 5:41 p.m.)
Review request for lens.
Bugs: LENS-490
https://issues.apache.org/jira/browse/LENS-490
Repository: lens
Description
-------
This task is to document the partition timeline.
It should document who are the users of it, what is timeline,
how to to use the cache, what are the defaults and why they are chosen, how/when to migrate, how/when to update existing timeline.
Diffs (updated)
-----
src/site/apt/user/olap-cube.apt 87fd659d28ce305460da43905a147f66b7b28824
Diff: https://reviews.apache.org/r/37478/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 37478: LENS-490: Document partition timeline in
user guide
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37478/#review95848
-----------------------------------------------------------
src/site/apt/user/olap-cube.apt (line 144)
<https://reviews.apache.org/r/37478/#comment150994>
Typo : also and
src/site/apt/user/olap-cube.apt (line 205)
<https://reviews.apache.org/r/37478/#comment150995>
Move the paragraph below the next paragraph?
Why are saying "tables are supposed to be snapshotted." tables need not be snapshotted always.
- Amareshwari Sriramadasu
On Aug. 18, 2015, 1:28 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37478/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2015, 1:28 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-490
> https://issues.apache.org/jira/browse/LENS-490
>
>
> Repository: lens
>
>
> Description
> -------
>
> This task is to document the partition timeline.
> It should document who are the users of it, what is timeline,
> how to to use the cache, what are the defaults and why they are chosen, how/when to migrate, how/when to update existing timeline.
>
>
> Diffs
> -----
>
> src/site/apt/user/index.apt d48c7347314876989cf8de8f3e330dc972e3ec5d
> src/site/apt/user/olap-cube.apt 87fd659d28ce305460da43905a147f66b7b28824
>
> Diff: https://reviews.apache.org/r/37478/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 37478: LENS-490: Document partition timeline in
user guide
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37478/
-----------------------------------------------------------
(Updated Aug. 18, 2015, 6:58 p.m.)
Review request for lens.
Bugs: LENS-490
https://issues.apache.org/jira/browse/LENS-490
Repository: lens
Description
-------
This task is to document the partition timeline.
It should document who are the users of it, what is timeline,
how to to use the cache, what are the defaults and why they are chosen, how/when to migrate, how/when to update existing timeline.
Diffs (updated)
-----
src/site/apt/user/index.apt d48c7347314876989cf8de8f3e330dc972e3ec5d
src/site/apt/user/olap-cube.apt 87fd659d28ce305460da43905a147f66b7b28824
Diff: https://reviews.apache.org/r/37478/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 37478: LENS-490: Document partition timeline in
user guide
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Aug. 18, 2015, 2:42 p.m., Amareshwari Sriramadasu wrote:
> > src/site/apt/user/olap-cube.apt, line 251
> > <https://reviews.apache.org/r/37478/diff/3/?file=1042954#file1042954line251>
> >
> > Please add following in wiki, if they are already not there. And timeline being present in properties should not highlighted to users. They should be encouraged to use cli to see timelines, instead of properties. The implementation can change to use timelines somewhere else in later versions.
removed properties, described cli and rest.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37478/#review95703
-----------------------------------------------------------
On Aug. 18, 2015, 6:58 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37478/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2015, 6:58 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-490
> https://issues.apache.org/jira/browse/LENS-490
>
>
> Repository: lens
>
>
> Description
> -------
>
> This task is to document the partition timeline.
> It should document who are the users of it, what is timeline,
> how to to use the cache, what are the defaults and why they are chosen, how/when to migrate, how/when to update existing timeline.
>
>
> Diffs
> -----
>
> src/site/apt/user/index.apt d48c7347314876989cf8de8f3e330dc972e3ec5d
> src/site/apt/user/olap-cube.apt 87fd659d28ce305460da43905a147f66b7b28824
>
> Diff: https://reviews.apache.org/r/37478/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 37478: LENS-490: Document partition timeline in
user guide
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37478/#review95703
-----------------------------------------------------------
src/site/apt/user/olap-cube.apt (line 143)
<https://reviews.apache.org/r/37478/#comment150798>
Did not understand - "Logical drop the concern of of join chains fully and expressions partially."
src/site/apt/user/olap-cube.apt (line 153)
<https://reviews.apache.org/r/37478/#comment150799>
Facts are defined below. Similar to facts is missing information here.
src/site/apt/user/olap-cube.apt (line 159)
<https://reviews.apache.org/r/37478/#comment150800>
"derived cubes will only act as constraints" does not make sense here. You can Derived cube will inherit all its base cube facts.
src/site/apt/user/olap-cube.apt (line 169)
<https://reviews.apache.org/r/37478/#comment150803>
Seems Update Period section is moved above, change this accordingly.
src/site/apt/user/olap-cube.apt (line 204)
<https://reviews.apache.org/r/37478/#comment150804>
Please add the below as well :
----
Dimension storage table is the physical dimension table for the associated storage. Dimension storage table can have snapshot dumps at specified regular intervals or a table with no dumps, so the storage table can have zero or one update period.
----
Also, change "Dimension storage tables are supposed to be snapshotted" to the following applies to snapped dimtable storage tables.
src/site/apt/user/olap-cube.apt (line 221)
<https://reviews.apache.org/r/37478/#comment150805>
typo unlike ?
src/site/apt/user/olap-cube.apt (line 230)
<https://reviews.apache.org/r/37478/#comment150812>
typo - "there is need" ?
src/site/apt/user/olap-cube.apt (line 235)
<https://reviews.apache.org/r/37478/#comment150816>
Please add following in wiki, if they are already not there. And timeline being present in properties should not highlighted to users. They should be encouraged to use cli to see timelines, instead of properties. The implementation can change to use timelines somewhere else in later versions.
- Amareshwari Sriramadasu
On Aug. 18, 2015, 7:12 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37478/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2015, 7:12 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-490
> https://issues.apache.org/jira/browse/LENS-490
>
>
> Repository: lens
>
>
> Description
> -------
>
> This task is to document the partition timeline.
> It should document who are the users of it, what is timeline,
> how to to use the cache, what are the defaults and why they are chosen, how/when to migrate, how/when to update existing timeline.
>
>
> Diffs
> -----
>
> src/site/apt/user/index.apt d48c7347314876989cf8de8f3e330dc972e3ec5d
> src/site/apt/user/olap-cube.apt 87fd659d28ce305460da43905a147f66b7b28824
>
> Diff: https://reviews.apache.org/r/37478/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 37478: LENS-490: Document partition timeline in
user guide
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37478/
-----------------------------------------------------------
(Updated Aug. 18, 2015, 12:42 p.m.)
Review request for lens.
Bugs: LENS-490
https://issues.apache.org/jira/browse/LENS-490
Repository: lens
Description
-------
This task is to document the partition timeline.
It should document who are the users of it, what is timeline,
how to to use the cache, what are the defaults and why they are chosen, how/when to migrate, how/when to update existing timeline.
Diffs (updated)
-----
src/site/apt/user/index.apt d48c7347314876989cf8de8f3e330dc972e3ec5d
src/site/apt/user/olap-cube.apt 87fd659d28ce305460da43905a147f66b7b28824
Diff: https://reviews.apache.org/r/37478/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 37478: LENS-490: Document partition timeline in
user guide
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37478/
-----------------------------------------------------------
(Updated Aug. 17, 2015, 2:17 p.m.)
Review request for lens.
Bugs: LENS-490
https://issues.apache.org/jira/browse/LENS-490
Repository: lens
Description
-------
This task is to document the partition timeline.
It should document who are the users of it, what is timeline,
how to to use the cache, what are the defaults and why they are chosen, how/when to migrate, how/when to update existing timeline.
Diffs (updated)
-----
src/site/apt/user/olap-cube.apt 87fd659d28ce305460da43905a147f66b7b28824
Diff: https://reviews.apache.org/r/37478/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 37478: LENS-490: Document partition timeline in
user guide
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Aug. 17, 2015, 12:56 p.m., Amareshwari Sriramadasu wrote:
> > src/site/apt/user/olap-cube.apt, line 60
> > <https://reviews.apache.org/r/37478/diff/1/?file=1040073#file1040073line60>
> >
> > What is this logical table here? seems confusing.
>
> Amareshwari Sriramadasu wrote:
> XField is an internal implementation detail and i think it requires no mention of it in user doc.
Cubes and Dimensions -> Logical Tables
Facts and Dimtables -> Physical tables.
Have followed this semantics in CLI code and also in the video demo.
Regarding XField, we can remove it, but I thought it shows a nice heirarchy to the user by showing that measure and dim attribute are connected at ground level.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37478/#review95568
-----------------------------------------------------------
On Aug. 14, 2015, 7:20 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37478/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2015, 7:20 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-490
> https://issues.apache.org/jira/browse/LENS-490
>
>
> Repository: lens
>
>
> Description
> -------
>
> This task is to document the partition timeline.
> It should document who are the users of it, what is timeline,
> how to to use the cache, what are the defaults and why they are chosen, how/when to migrate, how/when to update existing timeline.
>
>
> Diffs
> -----
>
> src/site/apt/user/olap-cube.apt 87fd659d28ce305460da43905a147f66b7b28824
>
> Diff: https://reviews.apache.org/r/37478/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 37478: LENS-490: Document partition timeline in
user guide
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Aug. 17, 2015, 12:56 p.m., Amareshwari Sriramadasu wrote:
> > src/site/apt/user/olap-cube.apt, line 76
> > <https://reviews.apache.org/r/37478/diff/1/?file=1040073#file1040073line76>
> >
> > Let us not give links to lens-cube from doc. They are not public and are likely to change.
Just giving links to javadoc(which *is* public). Would be helpful for a developer reading the documentation for quick ramp-up.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37478/#review95568
-----------------------------------------------------------
On Aug. 14, 2015, 7:20 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37478/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2015, 7:20 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-490
> https://issues.apache.org/jira/browse/LENS-490
>
>
> Repository: lens
>
>
> Description
> -------
>
> This task is to document the partition timeline.
> It should document who are the users of it, what is timeline,
> how to to use the cache, what are the defaults and why they are chosen, how/when to migrate, how/when to update existing timeline.
>
>
> Diffs
> -----
>
> src/site/apt/user/olap-cube.apt 87fd659d28ce305460da43905a147f66b7b28824
>
> Diff: https://reviews.apache.org/r/37478/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 37478: LENS-490: Document partition timeline in
user guide
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Aug. 17, 2015, 7:26 a.m., Amareshwari Sriramadasu wrote:
> > src/site/apt/user/olap-cube.apt, line 60
> > <https://reviews.apache.org/r/37478/diff/1/?file=1040073#file1040073line60>
> >
> > What is this logical table here? seems confusing.
XField is an internal implementation detail and i think it requires no mention of it in user doc.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37478/#review95568
-----------------------------------------------------------
On Aug. 14, 2015, 1:50 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37478/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2015, 1:50 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-490
> https://issues.apache.org/jira/browse/LENS-490
>
>
> Repository: lens
>
>
> Description
> -------
>
> This task is to document the partition timeline.
> It should document who are the users of it, what is timeline,
> how to to use the cache, what are the defaults and why they are chosen, how/when to migrate, how/when to update existing timeline.
>
>
> Diffs
> -----
>
> src/site/apt/user/olap-cube.apt 87fd659d28ce305460da43905a147f66b7b28824
>
> Diff: https://reviews.apache.org/r/37478/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 37478: LENS-490: Document partition timeline in
user guide
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37478/#review95568
-----------------------------------------------------------
src/site/apt/user/olap-cube.apt (line 58)
<https://reviews.apache.org/r/37478/#comment150585>
What is this logical table here? seems confusing.
src/site/apt/user/olap-cube.apt (line 72)
<https://reviews.apache.org/r/37478/#comment150584>
Let us not give links to lens-cube from doc. They are not public and are likely to change.
src/site/apt/user/olap-cube.apt (line 114)
<https://reviews.apache.org/r/37478/#comment150586>
make it 'derived cubes can act as'. There need not be constraints always
- Amareshwari Sriramadasu
On Aug. 14, 2015, 1:50 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37478/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2015, 1:50 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-490
> https://issues.apache.org/jira/browse/LENS-490
>
>
> Repository: lens
>
>
> Description
> -------
>
> This task is to document the partition timeline.
> It should document who are the users of it, what is timeline,
> how to to use the cache, what are the defaults and why they are chosen, how/when to migrate, how/when to update existing timeline.
>
>
> Diffs
> -----
>
> src/site/apt/user/olap-cube.apt 87fd659d28ce305460da43905a147f66b7b28824
>
> Diff: https://reviews.apache.org/r/37478/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>