You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@activemq.apache.org by ro...@apache.org on 2022/07/01 14:44:16 UTC

[activemq-artemis] 08/14: get generated log facade to compile with errorprone enabled

This is an automated email from the ASF dual-hosted git repository.

robbie pushed a commit to branch new-logging
in repository https://gitbox.apache.org/repos/asf/activemq-artemis.git

commit 249bb59bf63737112c01c5a7dad07e534cd15aac
Author: Robbie Gemmell <ro...@apache.org>
AuthorDate: Mon Jun 27 17:32:38 2022 +0100

    get generated log facade to compile with errorprone enabled
---
 .../java/org/apache/activemq/artemis/logprocessor/CodeFactory.java    | 1 +
 .../java/org/apache/activemq/artemis/logprocessor/LogProcessor.java   | 4 +++-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/artemis-log-facade/src/main/java/org/apache/activemq/artemis/logprocessor/CodeFactory.java b/artemis-log-facade/src/main/java/org/apache/activemq/artemis/logprocessor/CodeFactory.java
index 03695d9d85..16c368dee6 100644
--- a/artemis-log-facade/src/main/java/org/apache/activemq/artemis/logprocessor/CodeFactory.java
+++ b/artemis-log-facade/src/main/java/org/apache/activemq/artemis/logprocessor/CodeFactory.java
@@ -30,6 +30,7 @@ public class CodeFactory {
 
    public static <T> T getCodeClass(final Class<T> type, String category) {
       return doPrivileged(new PrivilegedAction<T>() {
+         @Override
          public T run() {
             try {
                String className = type.getName() + "_impl";
diff --git a/artemis-log-processor/src/main/java/org/apache/activemq/artemis/logprocessor/LogProcessor.java b/artemis-log-processor/src/main/java/org/apache/activemq/artemis/logprocessor/LogProcessor.java
index a78fffc747..b772add78b 100644
--- a/artemis-log-processor/src/main/java/org/apache/activemq/artemis/logprocessor/LogProcessor.java
+++ b/artemis-log-processor/src/main/java/org/apache/activemq/artemis/logprocessor/LogProcessor.java
@@ -217,6 +217,7 @@ public class LogProcessor extends AbstractProcessor {
       // This is really a debug output
       writerOutput.println("   // " + encodeSpecialChars(messageAnnotation.toString()));
 
+      writerOutput.println("   @Override");
       writerOutput.write("   public " + executableMember.getReturnType() + " " + executableMember.getSimpleName() + "(");
 
       Iterator<? extends VariableElement> parameters = executableMember.getParameters().iterator();
@@ -335,6 +336,7 @@ public class LogProcessor extends AbstractProcessor {
 
       // This is really a debug output
       writerOutput.println("   // " + loggerAnnotation.toString());
+      writerOutput.println("   @Override");
       writerOutput.println("   public Logger " + executableMember.getSimpleName() + "() { return logger; }");
       writerOutput.println();
    }
@@ -356,7 +358,7 @@ public class LogProcessor extends AbstractProcessor {
 
       // This is really a debug output
       writerOutput.println("   // " + encodeSpecialChars(messageAnnotation.toString()));
-
+      writerOutput.println("   @Override");
       writerOutput.write("   public void " + executableMember.getSimpleName() + "(");
 
       Iterator<? extends VariableElement> parameters = executableMember.getParameters().iterator();