You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by "Michael Vorburger (Jira)" <ji...@apache.org> on 2020/05/21 16:26:00 UTC
[jira] [Comment Edited] (FINERACT-828) StorageTest is flaky and
sometimes arbitrarily fails
[ https://issues.apache.org/jira/browse/FINERACT-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113326#comment-17113326 ]
Michael Vorburger edited comment on FINERACT-828 at 5/21/20, 4:25 PM:
----------------------------------------------------------------------
Re-opening, as this was just seen AGAIN on https://travis-ci.org/github/apache/fineract/builds/689694131 for FINERACT-888 ...
{noformat}org.apache.fineract.notification.StorageTest > testNotificationStorage FAILED
Argument(s) are different! Wanted:
notificationMapperWritePlatformService.create(
refEq(NotificationMapper [notification=Notification [objectType=CLIENT, objectIdentifier=1, action=created, actorId=1, isSystemGenerated=false, notificationContent=A client was created, createdAt=2020-05-21 21:08:30, getId()=null], userId=AppUser [username=J.J., getId()=null], isRead=false, createdAt=2020-05-21 21:08:30, getId()=null])
);
-> at org.apache.fineract.notification.StorageTest.testNotificationStorage(StorageTest.java:125)
Actual invocations have different arguments:
notificationMapperWritePlatformService.create(
NotificationMapper [notification=null, userId=AppUser [username=J.J., getId()=null], isRead=false, createdAt=2020-05-21 21:08:31, getId()=null]
);
-> at org.apache.fineract.notification.service.NotificationWritePlatformServiceImpl.insertIntoNotificationMapper(NotificationWritePlatformServiceImpl.java:75)
at org.apache.fineract.notification.StorageTest.testNotificationStorage(StorageTest.java:125){noformat}
The the problem is that that _notication_ was not set (yet, presumably, concurrency issue? but how, in a simple Mockito...).
https://github.com/apache/fineract/pull/918 raised to ignore it, for now.
was (Author: vorburger):
Re-opening, as this was just seen AGAIN on https://travis-ci.org/github/apache/fineract/builds/689694131 for FINERACT-888 ...
> StorageTest is flaky and sometimes arbitrarily fails
> ----------------------------------------------------
>
> Key: FINERACT-828
> URL: https://issues.apache.org/jira/browse/FINERACT-828
> Project: Apache Fineract
> Issue Type: Improvement
> Reporter: Michael Vorburger
> Assignee: Michael Vorburger
> Priority: Major
> Fix For: 1.4.0
>
> Attachments: image-2020-05-15-03-50-57-624.png
>
>
> https://github.com/apache/fineract/pull/692, a trivial Pull Request adding a new GitHub Action but not modifying any code, failed on https://travis-ci.org/apache/fineract/builds/636252981 due to:
> {code}> Task :test
> org.apache.fineract.notification.StorageTest > testNotificationStorage FAILED
> org.mockito.exceptions.verification.junit.ArgumentsAreDifferent at StorageTest.java:124
> (...)
> 17 tests completed, 1 failed, 2 skipped{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)