You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by corneadoug <gi...@git.apache.org> on 2015/07/03 07:47:54 UTC

[GitHub] incubator-zeppelin pull request: Reintegrate Ping

GitHub user corneadoug opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/137

    Reintegrate Ping

    Ping feature to keep websocket was introduced in #109 .
    But it was deleted during the merge of #56.
    
    This is bringing it back

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/corneadoug/incubator-zeppelin fix/ping

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/137.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #137
    
----
commit 4ccb2469deca42f7f95ab3b1164bb7e2c014d9c9
Author: Damien Corneau <co...@gmail.com>
Date:   2015-07-03T05:44:08Z

    Fix ZEPPELIN-113

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Reintegrate Ping

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/137


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Reintegrate Ping

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/137#issuecomment-118397211
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Reintegrate Ping

Posted by corneadoug <gi...@git.apache.org>.

Github user corneadoug commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/137#issuecomment-118244533
  
    This is ready, let's wait for CI


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---