[GitHub] [cassandra] rustyrazorblade commented on a change in pull request #488: CASSANDRA-15661 improve logging

[GitBox <gi...@apache.org>]

rustyrazorblade commented on a change in pull request #488: CASSANDRA-15661 improve logging
URL: https://github.com/apache/cassandra/pull/488#discussion_r399447394
 
 

 ##########
 File path: src/java/org/apache/cassandra/transport/ConnectionLimitHandler.java
 ##########
 @@ -61,7 +61,7 @@ public void channelActive(ChannelHandlerContext ctx) throws Exception
         if (count > limit)
         {
             // The decrement will be done in channelClosed(...)
-            noSpamLogger.warn("Exceeded maximum native connection limit of {} by using {} connections", limit, count);
+            noSpamLogger.error("Exceeded maximum native connection limit of {} by using {} connections", limit, count);
 
 Review comment:
   The nospam logger has some logic to prevent flooding logs with too much information.  The comment on the class says this:
   
   ```
   Logging that limits each log statement to firing based on time since the statement last fired.
   ```
   
   You'd see this if you had misconfigured your client to make too many connections to the DB.  For example if you did `.setConnectionsPerHost(1000)`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org