You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/07/09 07:38:33 UTC

[GitHub] [iotdb] neuyilan commented on a change in pull request #3532: Fix cluster auto create schema bug when retry locally

neuyilan commented on a change in pull request #3532:
URL: https://github.com/apache/iotdb/pull/3532#discussion_r666700843



##########
File path: cluster/src/main/java/org/apache/iotdb/cluster/metadata/CMManager.java
##########
@@ -732,7 +732,10 @@ private boolean createTimeseries(
     }
     if (result.getCode() != TSStatusCode.SUCCESS_STATUS.getStatusCode()
         && result.getCode() != TSStatusCode.PATH_ALREADY_EXIST_ERROR.getStatusCode()
-        && result.getCode() != TSStatusCode.NEED_REDIRECTION.getStatusCode()) {
+        && result.getCode() != TSStatusCode.NEED_REDIRECTION.getStatusCode()
+        && result.getCode() == TSStatusCode.MULTIPLE_ERROR.getStatusCode()
+        && result.getSubStatus().stream()
+            .allMatch(s -> s.getCode() == TSStatusCode.PATH_ALREADY_EXIST_ERROR.getStatusCode())) {

Review comment:
       if 
   ```
   result.getCode() == TSStatusCode.MULTIPLE_ERROR.getStatusCode() && esult.getSubStatus().stream()
               .allMatch(s -> s.getCode() == TSStatusCode.PATH_ALREADY_EXIST_ERROR.getStatusCode()))
   ```
   return true, it means all the timeseries have been created? 
   so why the final return result is false?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org