[GitHub] spark pull request #16689: [SPARK-19342][SPARKR] bug fixed in collect method...

[felixcheung <gi...@git.apache.org>]

Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16689#discussion_r97508643
  
    --- Diff: R/pkg/R/DataFrame.R ---
    @@ -1136,9 +1136,17 @@ setMethod("collect",
     
                       # Note that "binary" columns behave like complex types.
                       if (!is.null(PRIMITIVE_TYPES[[colType]]) && colType != "binary") {
    -                    vec <- do.call(c, col)
    +                    valueIndex <- which(!is.na(col))
    +                    if (length(valueIndex) > 0 && valueIndex[1] > 1) {
    +                      colTail <- col[-(1 : (valueIndex[1] - 1))]
    +                      vec <- do.call(c, colTail)
    +                      classVal <- class(vec)
    +                      vec <- c(rep(NA, valueIndex[1] - 1), vec)
    +                      class(vec) <- classVal
    --- End diff --
    
    Hmm, what happened here?
    if you want to drop the NA and use the rest to infer the class you can do `col[!is.na(col)]`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org