[GitHub] [daffodil] mbeckerle commented on a diff in pull request #976: Update test to use valid UTF-8

["mbeckerle (via GitHub)" <gi...@apache.org>]

mbeckerle commented on code in PR #976:
URL: https://github.com/apache/daffodil/pull/976#discussion_r1123805199


##########
daffodil-test/src/test/resources/org/apache/daffodil/section06/entities/Entities.tdml:
##########
@@ -495,7 +495,7 @@ is multiple bytes in UTF-8 encoding that is used - DFDL-6-042R"
 is multiple bytes in UTF-8 encoding that is used"
     model="Entities_01-Embedded.dfdl.xsd" root="seq_10" roundTrip="false">
     <tdml:document>
-      <tdml:documentPart type="byte">30 ab 31 32 32 7f</tdml:documentPart>
+      <tdml:documentPart type="byte">30 c2 ab 31 32 32 7f</tdml:documentPart>

Review Comment:
   Wow, I missed this entirely.
   
   You are definitely on it. Implementing raw-bytes in delimiters requires an entirely different non-text-based scanner be used. One must lower the characters of the delimiter to bytes so that the scanner is just looking for sequences of bytes. (It all becomes raw bytes)
   
   We need a way to say this issue is V.Never i.e., we have no plan/roadmap to fix this issue and implement rawbytes. 
   
   Maybe we just make sure this is in the unimpemented features page on the Daffodil site, and close the ticket with Won't fix?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org