You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Xiaojian Zhou <zh...@vmware.com> on 2020/10/27 21:21:57 UTC
[PROPOSAL] backport GEODE-8651 to 1.13, 9.10, 9.9
Hi, all:
The fix is to resolve a hang when Connection called notifyHandshakeWaiter the 2nd time and cleared the NioFilter’s unwrapped buffer by mistake.
The 2nd call should consider if the 1st call has finished handshake. If yes, do nothing. The fix is fully tested and has no risk. This problem exists in earlier versions and should be backported.
Regards
Xiaojian Zhou
Re: [PROPOSAL] backport GEODE-8651 to 1.13, 9.10, 9.9
Posted by Jinmei Liao <ji...@vmware.com>.
+1
On Oct 27, 2020 3:00 PM, Donal Evans <do...@vmware.com> wrote:
+1
________________________________
From: Anthony Baker <ba...@vmware.com>
Sent: Tuesday, October 27, 2020 2:53 PM
To: dev@geode.apache.org <de...@geode.apache.org>
Subject: Re: [PROPOSAL] backport GEODE-8651 to 1.13, 9.10, 9.9
+1 from me
> On Oct 27, 2020, at 2:21 PM, Xiaojian Zhou <zh...@vmware.com> wrote:
>
> Hi, all:
>
> The fix is to resolve a hang when Connection called notifyHandshakeWaiter the 2nd time and cleared the NioFilter’s unwrapped buffer by mistake.
>
> The 2nd call should consider if the 1st call has finished handshake. If yes, do nothing. The fix is fully tested and has no risk. This problem exists in earlier versions and should be backported.
>
> Regards
>
> Xiaojian Zhou
Re: [PROPOSAL] backport GEODE-8651 to 1.13, 9.10, 9.9
Posted by Donal Evans <do...@vmware.com>.
+1
________________________________
From: Anthony Baker <ba...@vmware.com>
Sent: Tuesday, October 27, 2020 2:53 PM
To: dev@geode.apache.org <de...@geode.apache.org>
Subject: Re: [PROPOSAL] backport GEODE-8651 to 1.13, 9.10, 9.9
+1 from me
> On Oct 27, 2020, at 2:21 PM, Xiaojian Zhou <zh...@vmware.com> wrote:
>
> Hi, all:
>
> The fix is to resolve a hang when Connection called notifyHandshakeWaiter the 2nd time and cleared the NioFilter’s unwrapped buffer by mistake.
>
> The 2nd call should consider if the 1st call has finished handshake. If yes, do nothing. The fix is fully tested and has no risk. This problem exists in earlier versions and should be backported.
>
> Regards
>
> Xiaojian Zhou
Re: [PROPOSAL] backport GEODE-8651 to 1.13, 9.10, 9.9
Posted by Anthony Baker <ba...@vmware.com>.
+1 from me
> On Oct 27, 2020, at 2:21 PM, Xiaojian Zhou <zh...@vmware.com> wrote:
>
> Hi, all:
>
> The fix is to resolve a hang when Connection called notifyHandshakeWaiter the 2nd time and cleared the NioFilter’s unwrapped buffer by mistake.
>
> The 2nd call should consider if the 1st call has finished handshake. If yes, do nothing. The fix is fully tested and has no risk. This problem exists in earlier versions and should be backported.
>
> Regards
>
> Xiaojian Zhou