You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/09/14 13:59:43 UTC
[GitHub] [lucene-solr] cpoerschke opened a new pull request #1870: SOLR-14865: 'Index Merge Metrics' documentation clarification
cpoerschke opened a new pull request #1870:
URL: https://github.com/apache/lucene-solr/pull/1870
https://issues.apache.org/jira/browse/SOLR-14865
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] cpoerschke commented on pull request #1870: SOLR-14865: 'Index Merge Metrics' documentation correction
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on pull request #1870:
URL: https://github.com/apache/lucene-solr/pull/1870#issuecomment-708388622
@ctargett and/or @sigram would you have any thoughts on this documentation change, with a view towards it perhaps being included in the upcoming 8.7 Solr Reference Guide? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] cpoerschke edited a comment on pull request #1870: SOLR-14865: 'Index Merge Metrics' documentation correction
Posted by GitBox <gi...@apache.org>.
cpoerschke edited a comment on pull request #1870:
URL: https://github.com/apache/lucene-solr/pull/1870#issuecomment-708388622
@ctargett and/or @sigram would you have any thoughts on this documentation change, with a view towards it perhaps being included in the upcoming 8.7 Solr Reference Guide? Thanks!
edit: github won't let me add both of you as reviewers, for some reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #1870: SOLR-14865: 'Index Merge Metrics' documentation correction
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on a change in pull request #1870:
URL: https://github.com/apache/lucene-solr/pull/1870#discussion_r505680828
##########
File path: solr/solr-ref-guide/src/metrics-reporting.adoc
##########
@@ -534,15 +534,34 @@ These metrics are available only on a per-core basis. Metrics can be aggregated
These metrics are collected in respective registries for each core (e.g., `solr.core.collection1....`), under the `INDEX` category.
-Basic metrics are always collected - collection of additional metrics can be turned on using boolean parameters in the `/config/indexConfig/metrics` section of `solrconfig.xml`:
+Metrics collection is controlled by boolean parameters in the `/config/indexConfig/metrics` section of `solrconfig.xml`:
+
Review comment:
Interesting find! Yes, I can see that above the _"The metrics available in your system can be customized by modifying the `<metrics>` element in `solr.xml`."_ wording is used and `<metrics>` is more pleasant to read than `/config/indexConfig/metrics` though that's subjective of course. The context helps differentiate between the different `<metrics>` elements and so yes, I agree it would be less jarring (and shorter!) to not use the fully qualified XML path here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] cpoerschke merged pull request #1870: SOLR-14865: 'Index Merge Metrics' documentation correction
Posted by GitBox <gi...@apache.org>.
cpoerschke merged pull request #1870:
URL: https://github.com/apache/lucene-solr/pull/1870
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] ctargett commented on a change in pull request #1870: SOLR-14865: 'Index Merge Metrics' documentation correction
Posted by GitBox <gi...@apache.org>.
ctargett commented on a change in pull request #1870:
URL: https://github.com/apache/lucene-solr/pull/1870#discussion_r504903798
##########
File path: solr/solr-ref-guide/src/metrics-reporting.adoc
##########
@@ -534,15 +534,34 @@ These metrics are available only on a per-core basis. Metrics can be aggregated
These metrics are collected in respective registries for each core (e.g., `solr.core.collection1....`), under the `INDEX` category.
-Basic metrics are always collected - collection of additional metrics can be turned on using boolean parameters in the `/config/indexConfig/metrics` section of `solrconfig.xml`:
+Metrics collection is controlled by boolean parameters in the `/config/indexConfig/metrics` section of `solrconfig.xml`:
+
Review comment:
I was a little confused by the fully qualified XML path here, we don't do that in other places in the docs so it jumped out at me. If we think maybe we should do that more often, this would be fine and I can make an issue to update other places in the Guide to someday be consistent but otherwise I only wonder if it would be jarring for others also (I might be alone in my impression).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org