How should we handle the Java files for native?

[Rainer Jung <ra...@kippdata.de>]

On 16.09.2009 17:24, Mladen Turk wrote:
> On 16/09/09 16:18, Mark Thomas wrote:
>> rjung@apache.org wrote:
>>> Author: rjung
>>> Date: Wed Sep 16 13:24:54 2009
>>> New Revision: 815768
>>>
>>> URL: http://svn.apache.org/viewvc?rev=815768&view=rev
>>> Log:
>>> Sync java parts of tcnative with C part.
>>
>> Do we need the java part here any more? 5.5.x, 6.0.x and trunk all have
>> their own copies.
>>
> 
> Yes, we need the java part as well, at least for
> the tomcat-native-xxx.src. Not sure how Apache Mina
> folks build their suff with tomcat native but I
> suppose by using the source archive.
> 
> However we can modify the dist script to
> pull the java part from the 6.0.x branch so it doesn't
> have to be duplicated.

Hmmm, how are users support to build? Until recently we were using a
build.xml. If we don't include the sources, ant would need to retrieve
them either via svn (for that you need an additional ant library), or
by downloading a tomcat src distribution.

So I guess the latter is the suggested way of doing it.

Furthermore, there were three directories with Java classes for jni:
java, test and examples. Only java made it into the TC 6 sources. The
other two dirs are gone. They are still available in the TC 4.1 and 5.5
sources though.

If we want to get every Java related file for jni from Tomcat, we would
need to add the test and examples files back.

build.xml and build.properties.default might make more sense in native
itself.

Comments?

Regards,

Rainer

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

Re: How should we handle the Java files for native?

[Rainer Jung <ra...@kippdata.de>]

On 16.09.2009 20:58, Mladen Turk wrote:
> On 16/09/09 18:53, Rainer Jung wrote:
>> If we want to get every Java related file for jni from Tomcat, we would
>> need to add the test and examples files back.
>>
>> build.xml and build.properties.default might make more sense in native
>> itself.
>>
>> Comments?
>>
> 
> Sure, we should bring back java/examples and java/test
> The sources do not overlap with Tomcat sources.
> build.xml and properties should be brought back as well.
> They are usable for standalone builds.
> 
> However we should probably create two source packages
> one with jni code only and one with jni + java (eg. src-all)
> for third-party users outside tomcat.
> 
> OTOH one can easily get those files directly from tomcat source.
> But then again, which tomcat src matches which tomcat-native
> src mess would arise.
> So IMO having two source packages should make less trouble.

examples, test and build.* are back and hopefully somewhat improved.

I added "ant download" to native trunk, which retrieves the TC 6 sources
for the version defined in build.properties(.default).

"ant compile" then copies over the needed package.

One can also fake the downloaded Tomcat sources by setting tomcat.src to
the source directory (e.g. when the TC release including Java changes
waits for the native release including native changes, so there's no
correct Tomcat source download yet available).

I didn't yet add the two distributions option to the jnirelease.sh.

I also added two proposals to clean up the TC 5.5 jni copy to the TC 5.5
status file.

Regards,

Rainer

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

Re: How should we handle the Java files for native?

[Mladen Turk <mt...@apache.org>]

On 16/09/09 18:53, Rainer Jung wrote:
> If we want to get every Java related file for jni from Tomcat, we would
> need to add the test and examples files back.
>
> build.xml and build.properties.default might make more sense in native
> itself.
>
> Comments?
>

Sure, we should bring back java/examples and java/test
The sources do not overlap with Tomcat sources.
build.xml and properties should be brought back as well.
They are usable for standalone builds.

However we should probably create two source packages
one with jni code only and one with jni + java (eg. src-all)
for third-party users outside tomcat.

OTOH one can easily get those files directly from tomcat source.
But then again, which tomcat src matches which tomcat-native
src mess would arise.
So IMO having two source packages should make less trouble.


Regards
-- 
^TM


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

Re: How should we handle the Java files for native?

[jean-frederic clere <jf...@gmail.com>]

On 09/16/2009 06:53 PM, Rainer Jung wrote:
> On 16.09.2009 17:24, Mladen Turk wrote:
>> On 16/09/09 16:18, Mark Thomas wrote:
>>> rjung@apache.org wrote:
>>>> Author: rjung
>>>> Date: Wed Sep 16 13:24:54 2009
>>>> New Revision: 815768
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=815768&view=rev
>>>> Log:
>>>> Sync java parts of tcnative with C part.
>>>
>>> Do we need the java part here any more? 5.5.x, 6.0.x and trunk all have
>>> their own copies.
>>>
>>
>> Yes, we need the java part as well, at least for
>> the tomcat-native-xxx.src. Not sure how Apache Mina
>> folks build their suff with tomcat native but I
>> suppose by using the source archive.
>>
>> However we can modify the dist script to
>> pull the java part from the 6.0.x branch so it doesn't
>> have to be duplicated.
>
> Hmmm, how are users support to build? Until recently we were using a
> build.xml. If we don't include the sources, ant would need to retrieve
> them either via svn (for that you need an additional ant library), or
> by downloading a tomcat src distribution.
>
> So I guess the latter is the suggested way of doing it.
>
> Furthermore, there were three directories with Java classes for jni:
> java, test and examples. Only java made it into the TC 6 sources. The
> other two dirs are gone. They are still available in the TC 4.1 and 5.5
> sources though.
>
> If we want to get every Java related file for jni from Tomcat, we would
> need to add the test and examples files back.

+1

Cheers

Jean-Frederic

>
> build.xml and build.properties.default might make more sense in native
> itself.
>
> Comments?
>
> Regards,
>
> Rainer
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org