You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "dawidwys (via GitHub)" <gi...@apache.org> on 2023/01/31 13:00:05 UTC
[GitHub] [flink] dawidwys commented on a diff in pull request #21808: [FLINK-24456][Connectors / Kafka,Table SQL / Ecosystem] Support bounded offset in the Kafka table connector
dawidwys commented on code in PR #21808:
URL: https://github.com/apache/flink/pull/21808#discussion_r1091890518
##########
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/table/KafkaTableITCase.java:
##########
@@ -179,6 +180,66 @@ public void testKafkaSourceSink() throws Exception {
deleteTestTopic(topic);
}
+ @Test
+ public void testKafkaSourceSinkWithBoundedSpecificOffsets() throws Exception {
Review Comment:
Sure, I can.
So far I did not want to add too many IT tests, as this PR does not introduce a new feature, but only exposes what has been implemented already for DataStream. I assumed, but I haven't checked, this should've been covered by the DataStream tests.
I left that single test as a smoke test for the entire stack, but I can add one more, which can serve as an example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org