You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@synapse.apache.org by "Asanka Abeysinghe (JIRA)" <ji...@apache.org> on 2008/07/07 20:42:32 UTC

[jira] Created: (SYNAPSE-394) FIX transport dose not handle a XML based FIX message payload with XML namespace

FIX transport dose not handle a XML based FIX message payload with XML namespace 
---------------------------------------------------------------------------------

                 Key: SYNAPSE-394
                 URL: https://issues.apache.org/jira/browse/SYNAPSE-394
             Project: Synapse
          Issue Type: Bug
          Components: Transports
    Affects Versions: 1.2
         Environment: Ubuntu-Gutsy 
            Reporter: Asanka Abeysinghe


When a FIX message that defines in a XML structure with a namespace, will not accept by the FIX transport layer. It fails when try to read the first element of the SOAP message body.
Sample input message: 
			<m0:message xmlns:m0="http://services.samples/xsd/">
						<m0:header>
						   <m0:field m0:id="35"><![CDATA[8]]></m0:field>
						   <m0:field m0:id="52"><![CDATA[20080618-08:41:56]]></m0:field>
						</m0:header>
						<m0:body>
Current implementation uses QName(<tag name>) to fetch the elements instead of using QName(<tag name>,<namespace URI>)						

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Resolved: (SYNAPSE-394) FIX transport dose not handle a XML based FIX message payload with XML namespace

Posted by "Asanka Abeysinghe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SYNAPSE-394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Asanka Abeysinghe resolved SYNAPSE-394.
---------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.3

Fix available with the attached patch SYNAPSE-394.patch. 

> FIX transport dose not handle a XML based FIX message payload with XML namespace 
> ---------------------------------------------------------------------------------
>
>                 Key: SYNAPSE-394
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-394
>             Project: Synapse
>          Issue Type: Bug
>          Components: Transports
>    Affects Versions: 1.2
>         Environment: Ubuntu-Gutsy 
>            Reporter: Asanka Abeysinghe
>             Fix For: 1.3
>
>         Attachments: SYNAPSE-394.patch
>
>
> When a FIX message that defines in a XML structure with a namespace, will not accept by the FIX transport layer. It fails when try to read the first element of the SOAP message body.
> Sample input message: 
> 			<m0:message xmlns:m0="http://services.samples/xsd/">
> 						<m0:header>
> 						   <m0:field m0:id="35"><![CDATA[8]]></m0:field>
> 						   <m0:field m0:id="52"><![CDATA[20080618-08:41:56]]></m0:field>
> 						</m0:header>
> 						<m0:body>
> Current implementation uses QName(<tag name>) to fetch the elements instead of using QName(<tag name>,<namespace URI>)						

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Updated: (SYNAPSE-394) FIX transport dose not handle a XML based FIX message payload with XML namespace

Posted by "Asanka Abeysinghe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SYNAPSE-394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Asanka Abeysinghe updated SYNAPSE-394:
--------------------------------------

    Attachment: SYNAPSE-394.patch

With this patch FIX transport layer can convert XML infoset with a namespace. 
Tested with the FIX samples 257, 258 and new scenarios.  

> FIX transport dose not handle a XML based FIX message payload with XML namespace 
> ---------------------------------------------------------------------------------
>
>                 Key: SYNAPSE-394
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-394
>             Project: Synapse
>          Issue Type: Bug
>          Components: Transports
>    Affects Versions: 1.2
>         Environment: Ubuntu-Gutsy 
>            Reporter: Asanka Abeysinghe
>         Attachments: SYNAPSE-394.patch
>
>
> When a FIX message that defines in a XML structure with a namespace, will not accept by the FIX transport layer. It fails when try to read the first element of the SOAP message body.
> Sample input message: 
> 			<m0:message xmlns:m0="http://services.samples/xsd/">
> 						<m0:header>
> 						   <m0:field m0:id="35"><![CDATA[8]]></m0:field>
> 						   <m0:field m0:id="52"><![CDATA[20080618-08:41:56]]></m0:field>
> 						</m0:header>
> 						<m0:body>
> Current implementation uses QName(<tag name>) to fetch the elements instead of using QName(<tag name>,<namespace URI>)						

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Resolved: (SYNAPSE-394) FIX transport dose not handle a XML based FIX message payload with XML namespace

Posted by "Hiranya Jayathilaka (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SYNAPSE-394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hiranya Jayathilaka resolved SYNAPSE-394.
-----------------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 1.3)
                   NIGHTLY

Committed the patch from Asanka A with minor changes and tested the old scenarios and the new scenarios against the trunk. Thanks for all the contributions Asanka.

> FIX transport dose not handle a XML based FIX message payload with XML namespace 
> ---------------------------------------------------------------------------------
>
>                 Key: SYNAPSE-394
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-394
>             Project: Synapse
>          Issue Type: Bug
>          Components: Transports
>    Affects Versions: 1.2
>         Environment: Ubuntu-Gutsy 
>            Reporter: Asanka Abeysinghe
>            Assignee: Hiranya Jayathilaka
>             Fix For: NIGHTLY
>
>         Attachments: SYNAPSE-394.patch
>
>
> When a FIX message that defines in a XML structure with a namespace, will not accept by the FIX transport layer. It fails when try to read the first element of the SOAP message body.
> Sample input message: 
> 			<m0:message xmlns:m0="http://services.samples/xsd/">
> 						<m0:header>
> 						   <m0:field m0:id="35"><![CDATA[8]]></m0:field>
> 						   <m0:field m0:id="52"><![CDATA[20080618-08:41:56]]></m0:field>
> 						</m0:header>
> 						<m0:body>
> Current implementation uses QName(<tag name>) to fetch the elements instead of using QName(<tag name>,<namespace URI>)						

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


Re: [jira] Reopened: (SYNAPSE-394) FIX transport dose not handle a XML based FIX message payload with XML namespace

Posted by Asanka Abeysinghe <as...@wso2.com>.
Thx for the update, please review the patch and do the needful.
Asanka A.

Asankha C. Perera (JIRA) wrote:
>      [ https://issues.apache.org/jira/browse/SYNAPSE-394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Asankha C. Perera reopened SYNAPSE-394:
> ---------------------------------------
>
>       Assignee: Asankha C. Perera
>
> Asanka A
>
> I do not think this patch was yet applied to the SVN? Hence this should not be marked resolved until such time
>
> asankha
>
>   


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Reopened: (SYNAPSE-394) FIX transport dose not handle a XML based FIX message payload with XML namespace

Posted by "Asankha C. Perera (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SYNAPSE-394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Asankha C. Perera reopened SYNAPSE-394:
---------------------------------------

      Assignee: Asankha C. Perera

Asanka A

I do not think this patch was yet applied to the SVN? Hence this should not be marked resolved until such time

asankha

> FIX transport dose not handle a XML based FIX message payload with XML namespace 
> ---------------------------------------------------------------------------------
>
>                 Key: SYNAPSE-394
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-394
>             Project: Synapse
>          Issue Type: Bug
>          Components: Transports
>    Affects Versions: 1.2
>         Environment: Ubuntu-Gutsy 
>            Reporter: Asanka Abeysinghe
>            Assignee: Asankha C. Perera
>             Fix For: 1.3
>
>         Attachments: SYNAPSE-394.patch
>
>
> When a FIX message that defines in a XML structure with a namespace, will not accept by the FIX transport layer. It fails when try to read the first element of the SOAP message body.
> Sample input message: 
> 			<m0:message xmlns:m0="http://services.samples/xsd/">
> 						<m0:header>
> 						   <m0:field m0:id="35"><![CDATA[8]]></m0:field>
> 						   <m0:field m0:id="52"><![CDATA[20080618-08:41:56]]></m0:field>
> 						</m0:header>
> 						<m0:body>
> Current implementation uses QName(<tag name>) to fetch the elements instead of using QName(<tag name>,<namespace URI>)						

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Assigned: (SYNAPSE-394) FIX transport dose not handle a XML based FIX message payload with XML namespace

Posted by "Asankha C. Perera (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SYNAPSE-394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Asankha C. Perera reassigned SYNAPSE-394:
-----------------------------------------

    Assignee: Hiranya Jayathilaka  (was: Asankha C. Perera)

Hiranya

Can you own the action on this patch since you are involved with the FIX transport? 

thanks
asankha

> FIX transport dose not handle a XML based FIX message payload with XML namespace 
> ---------------------------------------------------------------------------------
>
>                 Key: SYNAPSE-394
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-394
>             Project: Synapse
>          Issue Type: Bug
>          Components: Transports
>    Affects Versions: 1.2
>         Environment: Ubuntu-Gutsy 
>            Reporter: Asanka Abeysinghe
>            Assignee: Hiranya Jayathilaka
>             Fix For: 1.3
>
>         Attachments: SYNAPSE-394.patch
>
>
> When a FIX message that defines in a XML structure with a namespace, will not accept by the FIX transport layer. It fails when try to read the first element of the SOAP message body.
> Sample input message: 
> 			<m0:message xmlns:m0="http://services.samples/xsd/">
> 						<m0:header>
> 						   <m0:field m0:id="35"><![CDATA[8]]></m0:field>
> 						   <m0:field m0:id="52"><![CDATA[20080618-08:41:56]]></m0:field>
> 						</m0:header>
> 						<m0:body>
> Current implementation uses QName(<tag name>) to fetch the elements instead of using QName(<tag name>,<namespace URI>)						

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


Re: [jira] Commented: (SYNAPSE-394) FIX transport dose not handle a XML based FIX message payload with XML namespace

Posted by Hiranya Jayathilaka <hi...@gmail.com>.
Hi Asanka A.,

On Mon, Jul 21, 2008 at 12:31 AM, Asanka Abeysinghe <as...@wso2.com>
wrote:

> I did this patch as a value addition to allow the user to use a namespace
> (if they required) when injecting a FIX message to Synapse from protocols
> like HTTP, JMS, AMQP, A fn user might use namespaces like EQ: (equity), FX:
> (forex), OP:(options), CR:, IRD: differentiate the usage.


OK that makes sense.
Since this patch simply provides a value addition (may be along with some
new potential usecases) and since it does not alter the existing
functionality I'll check it in.

Thanks

Best Regards,
Hiranya


> If Synapse do not allow namespaces for the FIX input messages, that need to
> be add to the document and provide the valid format for the input
> message(s).
> This functional issue found with the issue posted before about JMS
> transport [1], I thought it was a problem in AXIOM layer till I saw
> SYNAPSE-402. Workaround I used for SYNAPSE-402 is a XSLT mediator to remove
> namespaces before FIX message process.
> Asanka A.


>
> [1]
> http://www.nabble.com/Problem-with-JMS---%3E-FIX-communication-td18224877.htmlHiranyaJayathilaka (JIRA) wrote:
>
>>    [
>> https://issues.apache.org/jira/browse/SYNAPSE-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615091#action_12615091]
>> Hiranya Jayathilaka commented on SYNAPSE-394:
>> ---------------------------------------------
>>
>> Asanka A,
>>
>> Is the purpose of fixing this issue is only to get around the problem
>> described at
>> http://www.nabble.com/Problem-with-JMS---%3E-FIX-communication-td18224877.html
>> ?
>>
>> If that is the case I agree with Andreas and we should wait till
>> SYNAPSE-402 is resolved. If there are other practical cases where this fix
>> can come in handy I'm +1 to commit this patch. Thoughts?
>>
>>
>>
>>
>>
>>
>>> FIX transport dose not handle a XML based FIX message payload with XML
>>> namespace
>>> ---------------------------------------------------------------------------------
>>>
>>>                Key: SYNAPSE-394
>>>                URL: https://issues.apache.org/jira/browse/SYNAPSE-394
>>>            Project: Synapse
>>>         Issue Type: Bug
>>>         Components: Transports
>>>   Affects Versions: 1.2
>>>        Environment: Ubuntu-Gutsy           Reporter: Asanka Abeysinghe
>>>           Assignee: Asankha C. Perera
>>>            Fix For: 1.3
>>>
>>>        Attachments: SYNAPSE-394.patch
>>>
>>>
>>> When a FIX message that defines in a XML structure with a namespace, will
>>> not accept by the FIX transport layer. It fails when try to read the first
>>> element of the SOAP message body.
>>> Sample input message:                        <m0:message xmlns:m0="
>>> http://services.samples/xsd/">
>>>                                                <m0:header>
>>>                                                   <m0:field
>>> m0:id="35"><![CDATA[8]]></m0:field>
>>>                                                   <m0:field
>>> m0:id="52"><![CDATA[20080618-08:41:56]]></m0:field>
>>>                                                </m0:header>
>>>                                                <m0:body>
>>> Current implementation uses QName(<tag name>) to fetch the elements
>>> instead of using QName(<tag name>,<namespace URI>)
>>>
>>>
>>>
>>
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
> For additional commands, e-mail: dev-help@synapse.apache.org
>
>

Re: [jira] Commented: (SYNAPSE-394) FIX transport dose not handle a XML based FIX message payload with XML namespace

Posted by Asanka Abeysinghe <as...@wso2.com>.
I did this patch as a value addition to allow the user to use a 
namespace (if they required) when injecting a FIX message to Synapse 
from protocols like HTTP, JMS, AMQP, A fn user might use namespaces like 
EQ: (equity), FX: (forex), OP:(options), CR:, IRD: differentiate the usage.
If Synapse do not allow namespaces for the FIX input messages, that need 
to be add to the document and provide the valid format for the input 
message(s).
This functional issue found with the issue posted before about JMS 
transport [1], I thought it was a problem in AXIOM layer till I saw 
SYNAPSE-402. Workaround I used for SYNAPSE-402 is a XSLT mediator to 
remove namespaces before FIX message process.
Asanka A.

[1] 
http://www.nabble.com/Problem-with-JMS---%3E-FIX-communication-td18224877.htmlHiranya 
Jayathilaka (JIRA) wrote:
>     [ https://issues.apache.org/jira/browse/SYNAPSE-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615091#action_12615091 ] 
>
> Hiranya Jayathilaka commented on SYNAPSE-394:
> ---------------------------------------------
>
> Asanka A,
>
> Is the purpose of fixing this issue is only to get around the problem described at http://www.nabble.com/Problem-with-JMS---%3E-FIX-communication-td18224877.html
> ?
>
> If that is the case I agree with Andreas and we should wait till SYNAPSE-402 is resolved. If there are other practical cases where this fix can come in handy I'm +1 to commit this patch. Thoughts?
>
>
>
>
>   
>> FIX transport dose not handle a XML based FIX message payload with XML namespace 
>> ---------------------------------------------------------------------------------
>>
>>                 Key: SYNAPSE-394
>>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-394
>>             Project: Synapse
>>          Issue Type: Bug
>>          Components: Transports
>>    Affects Versions: 1.2
>>         Environment: Ubuntu-Gutsy 
>>            Reporter: Asanka Abeysinghe
>>            Assignee: Asankha C. Perera
>>             Fix For: 1.3
>>
>>         Attachments: SYNAPSE-394.patch
>>
>>
>> When a FIX message that defines in a XML structure with a namespace, will not accept by the FIX transport layer. It fails when try to read the first element of the SOAP message body.
>> Sample input message: 
>> 			<m0:message xmlns:m0="http://services.samples/xsd/">
>> 						<m0:header>
>> 						   <m0:field m0:id="35"><![CDATA[8]]></m0:field>
>> 						   <m0:field m0:id="52"><![CDATA[20080618-08:41:56]]></m0:field>
>> 						</m0:header>
>> 						<m0:body>
>> Current implementation uses QName(<tag name>) to fetch the elements instead of using QName(<tag name>,<namespace URI>)						
>>     
>
>   


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Commented: (SYNAPSE-394) FIX transport dose not handle a XML based FIX message payload with XML namespace

Posted by "Hiranya Jayathilaka (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SYNAPSE-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615091#action_12615091 ] 

Hiranya Jayathilaka commented on SYNAPSE-394:
---------------------------------------------

Asanka A,

Is the purpose of fixing this issue is only to get around the problem described at http://www.nabble.com/Problem-with-JMS---%3E-FIX-communication-td18224877.html
?

If that is the case I agree with Andreas and we should wait till SYNAPSE-402 is resolved. If there are other practical cases where this fix can come in handy I'm +1 to commit this patch. Thoughts?




> FIX transport dose not handle a XML based FIX message payload with XML namespace 
> ---------------------------------------------------------------------------------
>
>                 Key: SYNAPSE-394
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-394
>             Project: Synapse
>          Issue Type: Bug
>          Components: Transports
>    Affects Versions: 1.2
>         Environment: Ubuntu-Gutsy 
>            Reporter: Asanka Abeysinghe
>            Assignee: Asankha C. Perera
>             Fix For: 1.3
>
>         Attachments: SYNAPSE-394.patch
>
>
> When a FIX message that defines in a XML structure with a namespace, will not accept by the FIX transport layer. It fails when try to read the first element of the SOAP message body.
> Sample input message: 
> 			<m0:message xmlns:m0="http://services.samples/xsd/">
> 						<m0:header>
> 						   <m0:field m0:id="35"><![CDATA[8]]></m0:field>
> 						   <m0:field m0:id="52"><![CDATA[20080618-08:41:56]]></m0:field>
> 						</m0:header>
> 						<m0:body>
> Current implementation uses QName(<tag name>) to fetch the elements instead of using QName(<tag name>,<namespace URI>)						

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Commented: (SYNAPSE-394) FIX transport dose not handle a XML based FIX message payload with XML namespace

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SYNAPSE-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615088#action_12615088 ] 

Andreas Veithen commented on SYNAPSE-394:
-----------------------------------------

I don't see why the FIX transport should accept an XML structure with an arbitrary namespace. If the purpose of this change is to provide a workaround for SYNAPSE-402, then my vote is definitely -1.

> FIX transport dose not handle a XML based FIX message payload with XML namespace 
> ---------------------------------------------------------------------------------
>
>                 Key: SYNAPSE-394
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-394
>             Project: Synapse
>          Issue Type: Bug
>          Components: Transports
>    Affects Versions: 1.2
>         Environment: Ubuntu-Gutsy 
>            Reporter: Asanka Abeysinghe
>            Assignee: Asankha C. Perera
>             Fix For: 1.3
>
>         Attachments: SYNAPSE-394.patch
>
>
> When a FIX message that defines in a XML structure with a namespace, will not accept by the FIX transport layer. It fails when try to read the first element of the SOAP message body.
> Sample input message: 
> 			<m0:message xmlns:m0="http://services.samples/xsd/">
> 						<m0:header>
> 						   <m0:field m0:id="35"><![CDATA[8]]></m0:field>
> 						   <m0:field m0:id="52"><![CDATA[20080618-08:41:56]]></m0:field>
> 						</m0:header>
> 						<m0:body>
> Current implementation uses QName(<tag name>) to fetch the elements instead of using QName(<tag name>,<namespace URI>)						

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org