[jira] [Resolved] (FLEX-14154) Unrequired setting of variable in DateField

["Justin Mclean (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FLEX-14154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Justin Mclean resolved FLEX-14154.
----------------------------------

    Resolution: Not A Problem

selectedDate is a setter and inside does this:
        selectedDateSet = true;
So 
        selectedDateSet = false;
May be still required.
                
> Unrequired setting of variable in DateField
> -------------------------------------------
>
>                 Key: FLEX-14154
>                 URL: https://issues.apache.org/jira/browse/FLEX-14154
>             Project: Apache Flex
>          Issue Type: Improvement
>          Components: mx: DateField
>    Affects Versions: Adobe Flex SDK Previous
>         Environment: Affected OS(s): All OS Platforms
> Affected OS(s): All OS Platforms
> Language Found: English
>            Reporter: Adobe JIRA
>
> line 741 we check that 'selectedDateSet' is false. If so the body of the 'if' statement is ran, and 'selectedDateSet' is set to false, but it already has the value false, or else the 'if' statements body wouldn't have ran.
> if (!selectedDateSet)
> {
>        selectedDate = newDate;
>        selectedDateSet = false;   <--------------- there is no reason for this line as we have already checked that 'selectedDateSet' is false.
>  }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira