You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2014/05/01 22:27:55 UTC
Review Request 20977: Updated libprocess to satisfy whitespace/line_length.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20977/
-----------------------------------------------------------
Review request for mesos and Adam B.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/3rdparty/Makefile.am 8ccf0ef60391c0a530cf27655b97b6f8e7589bd1
3rdparty/libprocess/include/process/async.hpp 316998541f76dc8fe5e8e333317266c0425ff266
3rdparty/libprocess/include/process/c++11/defer.hpp de041adb85a10312106ff2609ab92a8aa381ffbe
3rdparty/libprocess/include/process/c++11/deferred.hpp 4a25e125f01cf888f2e5545490b36453d1e26f9f
3rdparty/libprocess/include/process/future.hpp 8bbd14d61ca9ef3a45796f70202a62ffa347d41e
3rdparty/libprocess/include/process/gtest.hpp 11db008ed78b7329ede1b3c75842c7d6985630d5
3rdparty/libprocess/include/process/help.hpp 8d50419d9e794c64aecc5c8a906d3b1f6a288fac
3rdparty/libprocess/include/process/logging.hpp 08822667af758f480d78efabdd65833993b6f6a0
3rdparty/libprocess/src/decoder.hpp 44f7cd4b387441f789a27bcbd36ec1b4753748c3
3rdparty/libprocess/src/gate.hpp 200fce258ab81f9286d1e42adbf3375fd3bab056
3rdparty/libprocess/src/process.cpp 27ca5bb63be6e5c6d6514577ce13952affcc6b48
3rdparty/libprocess/src/synchronized.hpp 0804e5bdbaac6226ea061bd41c3f5fea998892de
3rdparty/libprocess/src/tests/http_tests.cpp 06ce1786a90bb408d6f48b2efd10d59f2f854c9f
Diff: https://reviews.apache.org/r/20977/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 20977: Updated libprocess to satisfy
whitespace/line_length.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20977/#review41952
-----------------------------------------------------------
Ship it!
Looks good besides the base64 build failure.
3rdparty/libprocess/3rdparty/Makefile.am
<https://reviews.apache.org/r/20977/#comment75622>
I guess this is the bugfix you wanted to include. Unfortunately, this test fails to build for me. Seems the base64 stuff is in the stout::base64 namespace, and the test tries to use base64::encode/decode directly (outside of the stout namespace). I removed "namespace stout {" from base64.hpp (since nothing else is in namespace stout) and everything builds.
Perhaps this should go in a separate review? Or at least the stout review?
- Adam B
On May 1, 2014, 1:27 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20977/
> -----------------------------------------------------------
>
> (Updated May 1, 2014, 1:27 p.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 8ccf0ef60391c0a530cf27655b97b6f8e7589bd1
> 3rdparty/libprocess/include/process/async.hpp 316998541f76dc8fe5e8e333317266c0425ff266
> 3rdparty/libprocess/include/process/c++11/defer.hpp de041adb85a10312106ff2609ab92a8aa381ffbe
> 3rdparty/libprocess/include/process/c++11/deferred.hpp 4a25e125f01cf888f2e5545490b36453d1e26f9f
> 3rdparty/libprocess/include/process/future.hpp 8bbd14d61ca9ef3a45796f70202a62ffa347d41e
> 3rdparty/libprocess/include/process/gtest.hpp 11db008ed78b7329ede1b3c75842c7d6985630d5
> 3rdparty/libprocess/include/process/help.hpp 8d50419d9e794c64aecc5c8a906d3b1f6a288fac
> 3rdparty/libprocess/include/process/logging.hpp 08822667af758f480d78efabdd65833993b6f6a0
> 3rdparty/libprocess/src/decoder.hpp 44f7cd4b387441f789a27bcbd36ec1b4753748c3
> 3rdparty/libprocess/src/gate.hpp 200fce258ab81f9286d1e42adbf3375fd3bab056
> 3rdparty/libprocess/src/process.cpp 27ca5bb63be6e5c6d6514577ce13952affcc6b48
> 3rdparty/libprocess/src/synchronized.hpp 0804e5bdbaac6226ea061bd41c3f5fea998892de
> 3rdparty/libprocess/src/tests/http_tests.cpp 06ce1786a90bb408d6f48b2efd10d59f2f854c9f
>
> Diff: https://reviews.apache.org/r/20977/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>