You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2020/07/08 14:28:33 UTC

[GitHub] [knox] pzampino commented on a change in pull request #358: KNOX-2395 - Make Gateway Services Pluggable

pzampino commented on a change in pull request #358:
URL: https://github.com/apache/knox/pull/358#discussion_r451583820



##########
File path: gateway-release/home/conf/gateway-site.xml
##########
@@ -18,6 +18,11 @@ limitations under the License.
 -->
 <configuration>
 
+    <property>
+        <name>gateway.services</name>

Review comment:
       I had envisioned the use of distinct properties, rather than a single "list" property.
   Something more explicit, like:
   `<property><name>gateway.service.alias</name><value>org.apache.knox.gateway.services.security.impl.RemoteAliasService</value></property>
   <property><name>gateway.service.tokenstate</name><value>org.apache.knox.gateway.services.token.impl.JournalBasedTokenStateService</value></property>`
   
   I think explicit class name values will make it easier for developers to create and deploy Knox customizations/extensions. Given this, I think a _list_ of such things could quickly become difficult to read.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org