You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "eldenmoon (via GitHub)" <gi...@apache.org> on 2026/02/02 15:15:08 UTC
[PR] [Fix](Variant) predicate should be pushed down when conjunct contains CAST [doris]
eldenmoon opened a new pull request, #60448:
URL: https://github.com/apache/doris/pull/60448
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](Variant) predicate should be pushed down when conjunct contains CAST [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60448:
URL: https://github.com/apache/doris/pull/60448#issuecomment-3837041311
# BE Regression && UT Coverage Report
Increment line coverage `85.71% (12/14)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60448_c39cca70e05284ef0e1b45992258a5d0e63ed135_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60448_c39cca70e05284ef0e1b45992258a5d0e63ed135_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 57.18% (20643/36103) |
| Line Coverage | 40.17% (200018/497979) |
| Region Coverage | 37.00% (160885/434856) |
| Branch Coverage | 37.56% (68194/181564) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](Variant) predicate should be pushed down when conjunct contains CAST [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60448:
URL: https://github.com/apache/doris/pull/60448#issuecomment-3836414954
<details>
<summary>ClickBench: <b>Total hot run time: 28.29 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c39cca70e05284ef0e1b45992258a5d0e63ed135, data reload: false
query1 0.04 0.05 0.05
query2 0.10 0.05 0.04
query3 0.26 0.08 0.09
query4 1.60 0.11 0.11
query5 0.28 0.26 0.26
query6 1.17 0.69 0.67
query7 0.04 0.02 0.02
query8 0.05 0.03 0.04
query9 0.56 0.52 0.49
query10 0.55 0.55 0.54
query11 0.15 0.10 0.10
query12 0.15 0.10 0.11
query13 0.64 0.62 0.62
query14 1.05 1.06 1.06
query15 0.88 0.88 0.88
query16 0.40 0.40 0.42
query17 1.13 1.14 1.10
query18 0.23 0.22 0.22
query19 2.10 1.95 2.01
query20 0.02 0.01 0.02
query21 15.49 0.28 0.14
query22 5.19 0.05 0.05
query23 15.93 0.26 0.10
query24 1.31 0.67 0.37
query25 0.10 0.07 0.05
query26 0.14 0.14 0.14
query27 0.05 0.10 0.05
query28 3.78 1.14 0.96
query29 12.60 3.88 3.11
query30 0.28 0.15 0.12
query31 2.81 0.63 0.40
query32 3.23 0.60 0.49
query33 3.27 3.30 3.26
query34 16.17 5.37 4.72
query35 4.76 4.79 4.74
query36 0.65 0.52 0.48
query37 0.12 0.07 0.07
query38 0.07 0.04 0.03
query39 0.04 0.03 0.03
query40 0.19 0.15 0.15
query41 0.09 0.04 0.03
query42 0.05 0.03 0.03
query43 0.05 0.04 0.04
Total cold run time: 97.77 s
Total hot run time: 28.29 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](Variant) predicate should be pushed down when conjunct contains CAST [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60448:
URL: https://github.com/apache/doris/pull/60448#issuecomment-3839548327
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](Variant) predicate should be pushed down when conjunct contains CAST [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #60448:
URL: https://github.com/apache/doris/pull/60448#issuecomment-3835757670
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](Variant) predicate should be pushed down when conjunct contains CAST [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60448:
URL: https://github.com/apache/doris/pull/60448#issuecomment-3839222952
<details>
<summary>ClickBench: <b>Total hot run time: 28.12 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5574ba17465d2c713ab4569b5c1dcc0d9fba6932, data reload: false
query1 0.05 0.05 0.05
query2 0.10 0.05 0.04
query3 0.25 0.08 0.08
query4 1.61 0.10 0.11
query5 0.26 0.24 0.24
query6 1.16 0.66 0.68
query7 0.03 0.03 0.02
query8 0.05 0.04 0.03
query9 0.56 0.49 0.49
query10 0.53 0.54 0.55
query11 0.14 0.10 0.09
query12 0.14 0.10 0.11
query13 0.63 0.61 0.62
query14 1.06 1.06 1.04
query15 0.89 0.88 0.87
query16 0.39 0.43 0.39
query17 1.09 1.11 1.14
query18 0.24 0.21 0.22
query19 2.01 2.01 2.02
query20 0.02 0.02 0.02
query21 15.41 0.27 0.15
query22 5.23 0.06 0.05
query23 16.09 0.29 0.11
query24 1.46 0.60 0.18
query25 0.11 0.06 0.05
query26 0.14 0.14 0.13
query27 0.09 0.05 0.06
query28 4.27 1.15 0.97
query29 12.57 3.92 3.13
query30 0.29 0.12 0.11
query31 2.81 0.65 0.42
query32 3.28 0.61 0.50
query33 3.35 3.20 3.17
query34 16.00 5.40 4.73
query35 4.70 4.79 4.80
query36 0.66 0.49 0.49
query37 0.10 0.07 0.06
query38 0.07 0.04 0.04
query39 0.04 0.04 0.03
query40 0.17 0.17 0.16
query41 0.08 0.03 0.04
query42 0.04 0.03 0.03
query43 0.05 0.04 0.04
Total cold run time: 98.22 s
Total hot run time: 28.12 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](Variant) predicate should be pushed down when conjunct contains CAST [doris]
Posted by "eldenmoon (via GitHub)" <gi...@apache.org>.
eldenmoon merged PR #60448:
URL: https://github.com/apache/doris/pull/60448
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](Variant) predicate should be pushed down when conjunct contains CAST [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60448:
URL: https://github.com/apache/doris/pull/60448#issuecomment-3839520941
# BE UT Coverage Report
Increment line coverage `55.56% (10/18)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/5574ba17465d2c713ab4569b5c1dcc0d9fba6932_5574ba17465d2c713ab4569b5c1dcc0d9fba6932/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/5574ba17465d2c713ab4569b5c1dcc0d9fba6932_5574ba17465d2c713ab4569b5c1dcc0d9fba6932/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.54% (19354/36838) |
| Line Coverage | 36.00% (179725/499181) |
| Region Coverage | 32.38% (139366/430458) |
| Branch Coverage | 33.36% (60323/180848) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](Variant) predicate should be pushed down when conjunct contains CAST [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60448:
URL: https://github.com/apache/doris/pull/60448#issuecomment-3839802924
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (18/18)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60448_5574ba17465d2c713ab4569b5c1dcc0d9fba6932_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60448_5574ba17465d2c713ab4569b5c1dcc0d9fba6932_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.67% (25875/36103) |
| Line Coverage | 54.26% (270218/497983) |
| Region Coverage | 51.62% (224451/434851) |
| Branch Coverage | 53.16% (96526/181574) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](Variant) predicate should be pushed down when conjunct contains CAST [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60448:
URL: https://github.com/apache/doris/pull/60448#issuecomment-3839548456
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](Variant) predicate should be pushed down when conjunct contains CAST [doris]
Posted by "eldenmoon (via GitHub)" <gi...@apache.org>.
eldenmoon commented on PR #60448:
URL: https://github.com/apache/doris/pull/60448#issuecomment-3838906668
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](Variant) predicate should be pushed down when conjunct contains CAST [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60448:
URL: https://github.com/apache/doris/pull/60448#issuecomment-3839169175
<details>
<summary>TPC-H: <b>Total hot run time: 32157 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5574ba17465d2c713ab4569b5c1dcc0d9fba6932, data reload: false
------ Round 1 ----------------------------------
q1 17692 5307 5093 5093
q2 2051 338 199 199
q3 10167 1325 771 771
q4 10195 816 314 314
q5 7529 2201 1909 1909
q6 204 185 156 156
q7 858 759 601 601
q8 9268 1440 1079 1079
q9 5447 4810 4799 4799
q10 6833 1956 1566 1566
q11 529 294 288 288
q12 400 379 224 224
q13 17797 4064 3295 3295
q14 240 246 214 214
q15 904 827 815 815
q16 691 672 632 632
q17 633 767 483 483
q18 6821 6410 7439 6410
q19 1233 1020 640 640
q20 426 367 251 251
q21 3068 2191 2133 2133
q22 377 320 285 285
Total cold run time: 103363 ms
Total hot run time: 32157 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5613 5547 5554 5547
q2 270 366 267 267
q3 2362 2853 2428 2428
q4 1472 1883 1423 1423
q5 4935 4535 4554 4535
q6 224 190 147 147
q7 2069 2044 1777 1777
q8 2558 2623 2476 2476
q9 7553 7652 7298 7298
q10 2929 3114 2696 2696
q11 551 470 441 441
q12 659 692 572 572
q13 3792 4313 3193 3193
q14 271 287 269 269
q15 835 786 787 786
q16 621 676 640 640
q17 1078 1246 1260 1246
q18 7594 7275 7224 7224
q19 831 795 776 776
q20 1960 2029 1894 1894
q21 4589 4241 4125 4125
q22 536 521 497 497
Total cold run time: 53302 ms
Total hot run time: 50257 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](Variant) predicate should be pushed down when conjunct contains CAST [doris]
Posted by "eldenmoon (via GitHub)" <gi...@apache.org>.
eldenmoon commented on PR #60448:
URL: https://github.com/apache/doris/pull/60448#issuecomment-3835977746
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](Variant) predicate should be pushed down when conjunct contains CAST [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60448:
URL: https://github.com/apache/doris/pull/60448#issuecomment-3836483724
# BE UT Coverage Report
Increment line coverage `85.71% (12/14)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/c39cca70e05284ef0e1b45992258a5d0e63ed135_c39cca70e05284ef0e1b45992258a5d0e63ed135/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/c39cca70e05284ef0e1b45992258a5d0e63ed135_c39cca70e05284ef0e1b45992258a5d0e63ed135/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.53% (19351/36838) |
| Line Coverage | 36.00% (179681/499177) |
| Region Coverage | 32.37% (139325/430463) |
| Branch Coverage | 33.34% (60291/180838) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](Variant) predicate should be pushed down when conjunct contains CAST [doris]
Posted by "eldenmoon (via GitHub)" <gi...@apache.org>.
eldenmoon commented on PR #60448:
URL: https://github.com/apache/doris/pull/60448#issuecomment-3838954111
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org