You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@brooklyn.apache.org by he...@apache.org on 2022/07/18 16:07:33 UTC

[brooklyn-server] 03/04: don't log on deproxying; there are many valid use cases for this

This is an automated email from the ASF dual-hosted git repository.

heneveld pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/brooklyn-server.git

commit a0bcb2c0f890d36948b6a35e1514f80dae5ec919
Author: Alex Heneveld <al...@cloudsoft.io>
AuthorDate: Mon Jul 18 17:05:08 2022 +0100

    don't log on deproxying; there are many valid use cases for this
---
 core/src/main/java/org/apache/brooklyn/core/entity/Entities.java | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/core/src/main/java/org/apache/brooklyn/core/entity/Entities.java b/core/src/main/java/org/apache/brooklyn/core/entity/Entities.java
index dfc0402514..7550881b9d 100644
--- a/core/src/main/java/org/apache/brooklyn/core/entity/Entities.java
+++ b/core/src/main/java/org/apache/brooklyn/core/entity/Entities.java
@@ -832,7 +832,8 @@ public class Entities {
     @Beta @VisibleForTesting
     public static AbstractEntity deproxy(Entity e) {
         if (!(Proxy.isProxyClass(e.getClass()))) {
-            log.warn("Attempt to deproxy non-proxy "+e, new Throwable("Location of attempt to deproxy non-proxy "+e));
+        // there are a few valid cases where callers might want to deproxy, so don't warn
+//            log.warn("Attempt to deproxy non-proxy "+e, new Throwable("Location of attempt to deproxy non-proxy "+e));
             return (AbstractEntity) e;
         }
         return (AbstractEntity) ((EntityProxyImpl)Proxy.getInvocationHandler(e)).getDelegate();