Locks on deleted files get broken when a commit fails over DAV

[Philip Martin <ph...@wandisco.com>]

If I lock a file, modify it and commit over DAV then the lock is
visible in the pre-commit hook, and if the commit fails the lock
remains valid.

If I delete the file, rather than modify it, then the lock gets
removed before the pre-commit hook runs, and if the commit fails the
lock is gone.  This leaves a broken lock in the working copy.

Would people agree that's a bug?

Commit has a --no-unlock option that causes locks to remain after the
commit, and this keeps the lock for deleted files as well.  So it
should be possible for locks on deleted files to behave more like
locks on modified files: to persist through pre-commit and not break
if the commit fails.

-- 
Philip

Re: Locks on deleted files get broken when a commit fails over DAV

["C. Michael Pilato" <cm...@collab.net>]

On 09/08/2010 12:53 PM, Philip Martin wrote:
> If I lock a file, modify it and commit over DAV then the lock is
> visible in the pre-commit hook, and if the commit fails the lock
> remains valid.
> 
> If I delete the file, rather than modify it, then the lock gets
> removed before the pre-commit hook runs, and if the commit fails the
> lock is gone.  This leaves a broken lock in the working copy.
> 
> Would people agree that's a bug?

I would.  And have in the past, too:

http://subversion.tigris.org/issues/show_bug.cgi?id=3534

-- 
C. Michael Pilato <cm...@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand