You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/09/14 18:38:36 UTC

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #4506: LCD: Merge files for ST7735 and ST7789 into ST77XX

acassis commented on a change in pull request #4506:
URL: https://github.com/apache/incubator-nuttx/pull/4506#discussion_r708533978



##########
File path: drivers/lcd/Kconfig
##########
@@ -619,15 +625,15 @@ if LCD_ST7789
 		---help---
 			Specifies the Y offset of the LCD.
 
-	config LCD_ST7789_BPP
+	config LCD_ST77XX_BPP

Review comment:
       @michallenc maybe you can define the CONFIG_LCD_ST77XX as main option and after enabling it the user can select (using choice) his model as ST7735 or ST7789




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org